Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp5261188ybc; Wed, 27 Nov 2019 01:02:30 -0800 (PST) X-Google-Smtp-Source: APXvYqz6H5ZqK4g4t3xpIyP9Xw583PNXz0p7FziVMO0/iI7T4utyq+k0EkxuuMT/vMOXTnFuTZGu X-Received: by 2002:a17:906:9458:: with SMTP id z24mr47389541ejx.289.1574845350814; Wed, 27 Nov 2019 01:02:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574845350; cv=none; d=google.com; s=arc-20160816; b=TJMtJfvcp9f7y/QuAbjU3iwlpgmr/6OMw6ZNssJRRreUX/H4a97v1ykFPdVVpustpp ZKQ8fM9VG4odytYlXbizXEUdiooe4eul8CVJtkLJb0TnMTdTbAeDSvK1LiGoY+Nimj4/ gJPhgC9izCl498WcyV2IJ2pXJb9oxeHusoI6J6TcwHZO5xqaTPHX4NYNtJQpb5titIoe r6ttir3Q6++MiVRm1wjsP1NIgShVPzE1xWOO1h8hiChFXWTPrLY/EePdNNN4aTCh0zKJ AhKcioOL5WbeYEDSTrcgZ7QoGfhyA/y4/F3k7F7h+UxoyjHuuPgYDLzXkkAC44UlC/Zr aD+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=JmTonCKgBwtH6ZCVvvwC0xYOpQiZgyClbkDvnybuHtY=; b=Z/Di9KkyyBMqO/IG8TXAi+Gk2hpbahss20YpyqzL9N2QEyBXcSEDYMj81G7Cx4PzqR XzziuP0t/4Ansgz2xgQ0pr8SfpUf7Vl/pxILszNBHkUonNGo1Ozubw53qMTpZa2QHuUS u6TH8ukFIZmz3yO7vtUs+ENPNneg7A6MU0576olXIKxWeHswafWLwpmZxb/z1NsYpBMq HDA2or+51BgV2DH1yxqugg+FzKq9Maz2MTsNMDTBkJqz/DEYfiPCLyqsOnIfNn8QCkL6 jmELnYtv4PUSkkH1fApLxIG0As4LGMr/0qsGMy727ustuUyoCkwfoTJuVHCMx2N6VR2w j7vA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=qyNGXAML; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f10si9046579ejq.289.2019.11.27.01.02.05; Wed, 27 Nov 2019 01:02:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=qyNGXAML; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726267AbfK0JAc (ORCPT + 99 others); Wed, 27 Nov 2019 04:00:32 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:55510 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726112AbfK0JAc (ORCPT ); Wed, 27 Nov 2019 04:00:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=JmTonCKgBwtH6ZCVvvwC0xYOpQiZgyClbkDvnybuHtY=; b=qyNGXAMLgO2TTMGb2Td8AI4m+ PCOkAfCO0joXtNVP9+JPW9awSmqB2GzhLrHj22gsOAtVSrKg6d/6W6adhJorKoXkY5BaplSIhIeYp EjT+nB1V747ljsacXboUhg6x76TOwqjflIHqx4eI+/jpRx6bUcdLDF3kCpgFBMxhGFD+LjyONGCWP mD22ZsmLp6peakUCMmRIYJPnNA0N2cawuDYgEP5hMDU8E3Z3eX75UEqvGktfu3xtV8EMCYVy6PJzE WScVHuOl59ZGVaNGCA+FrLA6DeALfOia6cydMSnVZQwgFWtudK2Qoyz9fCvNihRp6R3xfAt5BIXe2 GYvMy1H5Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iZtBP-0000Io-Jy; Wed, 27 Nov 2019 09:00:23 +0000 Date: Wed, 27 Nov 2019 01:00:23 -0800 From: Christoph Hellwig To: Hannes Reinecke Cc: Arnd Bergmann , "(Exiting) Baolin Wang" , Baolin Wang , Adrian Hunter , Ulf Hansson , asutoshd@codeaurora.org, Orson Zhai , Lyra Zhang , Linus Walleij , Vincent Guittot , linux-mmc , "linux-kernel@vger.kernel.org" , Hannes Reinecke , linux-block , Paolo Valente Subject: Re: [PATCH v6 0/4] Add MMC software queue support Message-ID: <20191127090023.GA23040@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 26, 2019 at 12:17:15PM +0100, Hannes Reinecke wrote: > Aligning with the 'traditional' linux way for partition handling is > definitely the way to go IMO; otherwise you'll end up having to worry > about resource allocation between distinct queues (like you have to do > now), and will be having a hard time trying to map it properly to the > underlying hardware abstraction in blk-mq. Sorry, but this is complete bullshit. Except for the very unfortunate name MMC partitions have nothing to do with partitions. They are a concept roughly equivalent to SCSI logical units and nvme namespace, just with a pretty idiotic design decision that only allows I/O to one of them at a time. The block layer way to deal with them is to use a shared tagset for multiple request queues, which doesn't use up a whole lot of resources. The only hard part is the draining when switching between partitions, and there is no really nice way to deal with that. If requests are batched enough we could just drain and switch every time an other partition access comes in. Especially so if people only use partitions for boot partitions and other rarely used areas. If that doesn't work out we'll just have to reject other partition access and then use a timer and/or counter to eventually switch and provide basic fairness.