Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp5406454ybc; Wed, 27 Nov 2019 03:35:40 -0800 (PST) X-Google-Smtp-Source: APXvYqzma8JXK1smYNVQ9hRrf3UXqE1jQeEoyLPFbbcy6Ijzl0aYaMOVP5CqAzcqovrQJn+gldCJ X-Received: by 2002:a05:6402:148d:: with SMTP id e13mr31470673edv.290.1574854540361; Wed, 27 Nov 2019 03:35:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574854540; cv=none; d=google.com; s=arc-20160816; b=TecSNMxqJW9V4p0ET27VF/rc2ydk9WsfkezdLp8nysmFpMKeRR8BYEW3IXOdFO++JL VIrF61uIl8AJUBU5kHbT4hfR+R+MErTvSXC+qX3110q1GAue0ahi9UIJqoXXVpk9TipM +Q0G9mqjCKnpOLvUc2NuNQyXCBOCg1xdYP6vl4eePaRLaveVQR79DWEa1Ul0qV2DxMEz TcZigTJAJeuVWcJ1KZJikBR2Qwpnzt3aXUWQga6YcD/7yBGWsqGnJr/RUB678iRrWM2l unKkwblyf3nyym8WTI4UE2V50t5DO8TVTp8t02g9aPlV+e2ifUXsW9WACyXOcB8a20n5 PcVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=b/oO5LgHIVezHDa0lWHiVZRMYVl3WjVpcB8Rma2bE0Q=; b=zF+jeyWk4tGH/Of9kP88KGme9s0MTt1tsHdndCCy/88t10lCj7q3qmWCjQRTi8NFJh Y/1YH5ejZ12Ui3u1+IwIuq2B+SCNL+dHe6+BYiJNziYVkNxIVup8SmtMxBb0+Hq810M/ NClfCWOvMHyptWzu4yIF+5wmeljHSNf1rWEumAuChGWSfbKhkiG+mjeC2IKFgF0TML8s QVCIh2MRaCbND4C1dfw/5HxQJDq3hfAB52Azw+vISynwo5Po/BKhj1vwmCcjdXZNc+ye g5Y5qB8kkFJJ7ZTwkUQqZvvjGxdI1dBK7inZ7UPaTJnnZOk+aJeh5PYhhTaCiSPFH111 GaGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=DSeeNl4i; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f12si8819290ejk.81.2019.11.27.03.35.15; Wed, 27 Nov 2019 03:35:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=DSeeNl4i; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726852AbfK0Ldm (ORCPT + 99 others); Wed, 27 Nov 2019 06:33:42 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:35426 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726383AbfK0Ldm (ORCPT ); Wed, 27 Nov 2019 06:33:42 -0500 Received: by mail-wm1-f67.google.com with SMTP id n5so7071836wmc.0 for ; Wed, 27 Nov 2019 03:33:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=b/oO5LgHIVezHDa0lWHiVZRMYVl3WjVpcB8Rma2bE0Q=; b=DSeeNl4igiUFnQKTSKwXvgHohVfm3OC/tKrYXjjxIPHl/mKpkRiGsJPZvB0LRQMR9/ snerCB4pXivXSs9anz2HALpOv2YGaoW118K6PyfcfnYTaemYeB591cJoLMnYhBRclEY6 EP2UpXz33jTdNZJF/IeZy2+EPIyJ2ogsioj3I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=b/oO5LgHIVezHDa0lWHiVZRMYVl3WjVpcB8Rma2bE0Q=; b=CeoVAmwESbyBqAKRwV4QQ/SLrEq40uMNy3y+utVSpOnqyotIffrl+Sh4y9Aee+ZsYw yZcsqt4/r1/TkAYKMRuaRRv/9XXiKPSZwVAtpEb8HnQT1W4dL8nfVOfTAfVWtiiLOHXR KPkS9R1TddS+UDoYWhYH0syanu7IPR4gdnl46UipETyLiPvTapXVZTt4MpqnhKzeUjvK /m4lfVhiW89lYClW5ZOAbCXkxfvGACWzDC1tyveiLOtvett7XEKDIeQ7vgZ3L78PXVj8 QqfpP+C21Qe25Ugjrh/LmuWuzjq/eqj9kpdfAtKtnL/JiNrsD/c+FAuOMQx/U0EjKuHB QA9g== X-Gm-Message-State: APjAAAVPJA2ABPRy9iZ6q8CW+kAweNkQb65FXBVjd0IxgFqPJt46Lr1R fcIkYru4Gb4//oGJ5TcMqO/5Fg== X-Received: by 2002:a1c:3d8a:: with SMTP id k132mr3750438wma.144.1574854418904; Wed, 27 Nov 2019 03:33:38 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-96.fiber7.init7.net. [212.51.149.96]) by smtp.gmail.com with ESMTPSA id m15sm18702608wrq.97.2019.11.27.03.33.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Nov 2019 03:33:38 -0800 (PST) Date: Wed, 27 Nov 2019 12:33:36 +0100 From: Daniel Vetter To: Yannick Fertre Cc: Philippe Cornu , Benjamin Gaignard , David Airlie , Daniel Vetter , Maxime Coquelin , Alexandre Torgue , dri-devel@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/bridge/synopsys: dsi: check post disable Message-ID: <20191127113336.GB406127@phenom.ffwll.local> Mail-Followup-To: Yannick Fertre , Philippe Cornu , Benjamin Gaignard , David Airlie , Maxime Coquelin , Alexandre Torgue , dri-devel@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1574850165-13135-1-git-send-email-yannick.fertre@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1574850165-13135-1-git-send-email-yannick.fertre@st.com> X-Operating-System: Linux phenom 5.3.0-2-amd64 User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 27, 2019 at 11:22:45AM +0100, Yannick Fertre wrote: > From: Yannick Fertr? > > Some bridges did not registered the post_disable function. > To avoid a crash, check it before calling. > > Signed-off-by: Yannick Fertre Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > index cc806ba..1e37233 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > @@ -886,7 +886,8 @@ static void dw_mipi_dsi_bridge_post_disable(struct drm_bridge *bridge) > * This needs to be fixed in the drm_bridge framework and the API > * needs to be updated to manage our own call chains... > */ > - dsi->panel_bridge->funcs->post_disable(dsi->panel_bridge); > + if (dsi->panel_bridge->funcs->post_disable) > + dsi->panel_bridge->funcs->post_disable(dsi->panel_bridge); > > if (dsi->slave) { > dw_mipi_dsi_disable(dsi->slave); > -- > 2.7.4 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch