Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp5596228ybc; Wed, 27 Nov 2019 06:34:58 -0800 (PST) X-Google-Smtp-Source: APXvYqxNzlDyZUCQ8urHOZ/IrO7OayVM5+R75nC9xPKVFwRteP93E4RL53HV7AwA7d51JfKFMg5t X-Received: by 2002:a50:9316:: with SMTP id m22mr32363252eda.39.1574865298222; Wed, 27 Nov 2019 06:34:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574865298; cv=none; d=google.com; s=arc-20160816; b=KPLG6x4z5UlQlzptmPEadm4CcC6jOi9/RT83GsCMq/zHLTSiwmFj+3giJVeV7TNEIB mDvfQEMvxKpLozV6eeBeoN1A0ex0YofoW9y7MGORlfhdky5g7J70hXY5dT+2G/kAV0ls 5LJ+PJj/gdlyYdvKdNe9Qaq9bCeQ2HR3V2+yvNvBuxVJpPELECDUWxksCfsB0h/z9wjb zwP7SUA/R3nTcb7LtlDvfHIOaqZjjQPmLs7xWIWvxGERw7l/XdMXQecdS07Zrz6k+8Qp LH2Ax6DEH9q+iAFeqW/ekaJfPzzlxRpVC3BDZRTkTk4iqCnz5pOqMPiKMs1b+7fJgS1Y 1qMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=kG9k0OfTykQgeiBg3oeLXmEemhzuDtsxs3eE6OvMXoI=; b=HTXEfE3O5XHLCqxhYQHWytrtMk38oqdrkmgBT0VHFUMaTVmI7iFtHEUveTWoPMB3zs nSxb6ysKFNbrcR8UaVfjCF2CYxzY7CmxZzw9+ItllZhIr+C0meWj2jBUfIy6WeRA2vIV 6Y7VugxBUCC3bzukV/UJRBUP17YXW1NWTzeYtY6hjSpucNRNrK6gw2aq9Oc4Ys3xlwU9 kBAhV9TXWq63zCjzgrWt+xrYAehTosiRz/eZLgvhPuHc7Ei1k2gYxwf6EdJl8wGEZUNd HW7yaqJI9juEHgkE2z6eaalBkoeyD5zzFxPp5WJ4z6ZhhZt5c+8OFYH5+M37PHj9A0W4 0EfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=a7W8dW5I; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x4si9526295ejs.376.2019.11.27.06.34.33; Wed, 27 Nov 2019 06:34:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=a7W8dW5I; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727267AbfK0Ocf (ORCPT + 99 others); Wed, 27 Nov 2019 09:32:35 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:40224 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727051AbfK0Ocf (ORCPT ); Wed, 27 Nov 2019 09:32:35 -0500 Received: by mail-lj1-f194.google.com with SMTP id s22so5713852ljs.7; Wed, 27 Nov 2019 06:32:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kG9k0OfTykQgeiBg3oeLXmEemhzuDtsxs3eE6OvMXoI=; b=a7W8dW5I27VP+lEYs5uo4RhMUn5cfdVmuUlQQRlVwB6WqT3EUzgKaP4wvjUpy1F2Lc o2ps4nlHmvRqaE7+VUt3UKaMYbY4EwinrWGydutip/riOFVocCtQ5DVs50FxGUpn4ee+ mgrFqYYa+4W17p7KR2Y8OeZ2BIR8NFSLhtzR2fGc4agtQ5z9FXmWJ+lkSm1tO0y8jBLC 1554bo4M6yM5zCa0mwnkouI58K2BsfJJILaHHFQzUJZ+BP4x8LJeoGguUUsVE0ixmy6O 22bxe/asCLEpGRZ/lrKwgSZNemvFaXjpferfcvpHdyoBtij6sQb+MffZbpTwpZtIa7/C ePcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kG9k0OfTykQgeiBg3oeLXmEemhzuDtsxs3eE6OvMXoI=; b=FEnXPTt3Rk2Www1fY97+NOmxajrTO2IYSfU91R+Ss/teg0tlgQ5Ky240Hkl8vFNY2D tdhRAyCWZnbDjZAp4+vKOW7jxGp/B3gAqZt9INWip8K83M0DW8hl8AK+8lNG/HbDKv1X e5Gd1ygtGRUzWek8ossBhYMuFMe9ZCPkvq9PHaGKuXTmitF4YNdZPqQdXsqL5DKRntWQ eYo1ps/xP+chW3uMrI6ggaDoM9yQX4oCyYBBWn20lOJQ5nTF/mxtAkrbzQjDaqlf/zPi x3wb4Pcml1WH198GkRcZd17Wbf/FPemD5AKhTjkP5P90uApAe/mBpAK8hfhlNYsYc7V0 VjFA== X-Gm-Message-State: APjAAAXCjj4T1hNBfGQfGXncCr9hd7u4h6uWvYahbk4yaz/2Hi7L8DKn e2lAdEie3a92PEivbGenIa/5B6n/ X-Received: by 2002:a05:651c:119b:: with SMTP id w27mr28657996ljo.221.1574865152129; Wed, 27 Nov 2019 06:32:32 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id d7sm7074527lfl.42.2019.11.27.06.32.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Nov 2019 06:32:31 -0800 (PST) Subject: Re: [PATCH v2 06/11] dt-bindings: clock: tegra: Remove pmc clock ids from clock dt-bindings To: Sowjanya Komatineni , thierry.reding@gmail.com, jonathanh@nvidia.com, mperttunen@nvidia.com, gregkh@linuxfoundation.org, sboyd@kernel.org, tglx@linutronix.de, robh+dt@kernel.org, mark.rutland@arm.com Cc: allison@lohutok.net, pdeschrijver@nvidia.com, pgaikwad@nvidia.com, mturquette@baylibre.com, horms+renesas@verge.net.au, Jisheng.Zhang@synaptics.com, krzk@kernel.org, arnd@arndb.de, spujar@nvidia.com, josephl@nvidia.com, vidyas@nvidia.com, daniel.lezcano@linaro.org, mmaddireddy@nvidia.com, markz@nvidia.com, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <1574830773-14892-1-git-send-email-skomatineni@nvidia.com> <1574830773-14892-7-git-send-email-skomatineni@nvidia.com> From: Dmitry Osipenko Message-ID: <22ab4e93-bf94-5c73-b4b9-6cf36d329b97@gmail.com> Date: Wed, 27 Nov 2019 17:32:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <1574830773-14892-7-git-send-email-skomatineni@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 27.11.2019 07:59, Sowjanya Komatineni пишет: > clk_out_1, clk_out_2, clk_out_3, blink are part of Tegra pmc clocks. > > This patch removes ids for these clocks from Tegra clock dt-bindings. > > Signed-off-by: Sowjanya Komatineni > --- > include/dt-bindings/clock/tegra114-car.h | 14 +++++++------- > include/dt-bindings/clock/tegra124-car-common.h | 14 +++++++------- > include/dt-bindings/clock/tegra20-car.h | 2 +- > include/dt-bindings/clock/tegra210-car.h | 14 +++++++------- > include/dt-bindings/clock/tegra30-car.h | 14 +++++++------- > 5 files changed, 29 insertions(+), 29 deletions(-) > > diff --git a/include/dt-bindings/clock/tegra114-car.h b/include/dt-bindings/clock/tegra114-car.h > index bb5c2c999c05..9175cd0571b5 100644 > --- a/include/dt-bindings/clock/tegra114-car.h > +++ b/include/dt-bindings/clock/tegra114-car.h > @@ -270,10 +270,10 @@ > #define TEGRA114_CLK_AUDIO3 242 > #define TEGRA114_CLK_AUDIO4 243 > #define TEGRA114_CLK_SPDIF 244 > -#define TEGRA114_CLK_CLK_OUT_1 245 > -#define TEGRA114_CLK_CLK_OUT_2 246 > -#define TEGRA114_CLK_CLK_OUT_3 247 > -#define TEGRA114_CLK_BLINK 248 > +/* 245 */ > +/* 246 */ > +/* 247 */ > +/* 248 */ > /* 249 */ > /* 250 */ > /* 251 */ > @@ -333,9 +333,9 @@ > #define TEGRA114_CLK_AUDIO3_MUX 303 > #define TEGRA114_CLK_AUDIO4_MUX 304 > #define TEGRA114_CLK_SPDIF_MUX 305 > -#define TEGRA114_CLK_CLK_OUT_1_MUX 306 > -#define TEGRA114_CLK_CLK_OUT_2_MUX 307 > -#define TEGRA114_CLK_CLK_OUT_3_MUX 308 > +/* 306 */ > +/* 307 */ > +/* 308 */ > #define TEGRA114_CLK_DSIA_MUX 309 > #define TEGRA114_CLK_DSIB_MUX 310 > #define TEGRA114_CLK_XUSB_SS_DIV2 311 > diff --git a/include/dt-bindings/clock/tegra124-car-common.h b/include/dt-bindings/clock/tegra124-car-common.h > index 0c4f5be0a742..90a0c5e7eb5f 100644 > --- a/include/dt-bindings/clock/tegra124-car-common.h > +++ b/include/dt-bindings/clock/tegra124-car-common.h > @@ -269,10 +269,10 @@ > #define TEGRA124_CLK_AUDIO3 242 > #define TEGRA124_CLK_AUDIO4 243 > #define TEGRA124_CLK_SPDIF 244 > -#define TEGRA124_CLK_CLK_OUT_1 245 > -#define TEGRA124_CLK_CLK_OUT_2 246 > -#define TEGRA124_CLK_CLK_OUT_3 247 > -#define TEGRA124_CLK_BLINK 248 > +/* 245 */ > +/* 246 */ > +/* 247 */ > +/* 248 */ > /* 249 */ > /* 250 */ > /* 251 */ > @@ -332,9 +332,9 @@ > #define TEGRA124_CLK_AUDIO3_MUX 303 > #define TEGRA124_CLK_AUDIO4_MUX 304 > #define TEGRA124_CLK_SPDIF_MUX 305 > -#define TEGRA124_CLK_CLK_OUT_1_MUX 306 > -#define TEGRA124_CLK_CLK_OUT_2_MUX 307 > -#define TEGRA124_CLK_CLK_OUT_3_MUX 308 > +/* 306 */ > +/* 307 */ > +/* 308 */ > /* 309 */ > /* 310 */ > #define TEGRA124_CLK_SOR0_LVDS 311 /* deprecated */ > diff --git a/include/dt-bindings/clock/tegra20-car.h b/include/dt-bindings/clock/tegra20-car.h > index b21a0eb32921..fe541f627965 100644 > --- a/include/dt-bindings/clock/tegra20-car.h > +++ b/include/dt-bindings/clock/tegra20-car.h > @@ -131,7 +131,7 @@ > #define TEGRA20_CLK_CCLK 108 > #define TEGRA20_CLK_HCLK 109 > #define TEGRA20_CLK_PCLK 110 > -#define TEGRA20_CLK_BLINK 111 > +/* 111 */ > #define TEGRA20_CLK_PLL_A 112 > #define TEGRA20_CLK_PLL_A_OUT0 113 > #define TEGRA20_CLK_PLL_C 114 > diff --git a/include/dt-bindings/clock/tegra210-car.h b/include/dt-bindings/clock/tegra210-car.h > index 44f60623f99b..a3d8d3e75728 100644 > --- a/include/dt-bindings/clock/tegra210-car.h > +++ b/include/dt-bindings/clock/tegra210-car.h > @@ -304,10 +304,10 @@ > #define TEGRA210_CLK_AUDIO3 274 > #define TEGRA210_CLK_AUDIO4 275 > #define TEGRA210_CLK_SPDIF 276 > -#define TEGRA210_CLK_CLK_OUT_1 277 > -#define TEGRA210_CLK_CLK_OUT_2 278 > -#define TEGRA210_CLK_CLK_OUT_3 279 > -#define TEGRA210_CLK_BLINK 280 > +/* 277 */ > +/* 278 */ > +/* 279 */ > +/* 280 */ > #define TEGRA210_CLK_SOR0_LVDS 281 /* deprecated */ > #define TEGRA210_CLK_SOR0_OUT 281 > #define TEGRA210_CLK_SOR1_OUT 282 > @@ -386,9 +386,9 @@ > #define TEGRA210_CLK_AUDIO3_MUX 353 > #define TEGRA210_CLK_AUDIO4_MUX 354 > #define TEGRA210_CLK_SPDIF_MUX 355 > -#define TEGRA210_CLK_CLK_OUT_1_MUX 356 > -#define TEGRA210_CLK_CLK_OUT_2_MUX 357 > -#define TEGRA210_CLK_CLK_OUT_3_MUX 358 > +/* 356 */ > +/* 357 */ > +/* 358 */ > #define TEGRA210_CLK_DSIA_MUX 359 > #define TEGRA210_CLK_DSIB_MUX 360 > /* 361 */ > diff --git a/include/dt-bindings/clock/tegra30-car.h b/include/dt-bindings/clock/tegra30-car.h > index 3c90f1535551..20ef2462d9e1 100644 > --- a/include/dt-bindings/clock/tegra30-car.h > +++ b/include/dt-bindings/clock/tegra30-car.h > @@ -230,11 +230,11 @@ > #define TEGRA30_CLK_AUDIO3 204 > #define TEGRA30_CLK_AUDIO4 205 > #define TEGRA30_CLK_SPDIF 206 > -#define TEGRA30_CLK_CLK_OUT_1 207 /* (extern1) */ > -#define TEGRA30_CLK_CLK_OUT_2 208 /* (extern2) */ > -#define TEGRA30_CLK_CLK_OUT_3 209 /* (extern3) */ > +/* 207 */ > +/* 208 */ > +/* 209 */ > #define TEGRA30_CLK_SCLK 210 > -#define TEGRA30_CLK_BLINK 211 > +/* 211 */ > #define TEGRA30_CLK_CCLK_G 212 > #define TEGRA30_CLK_CCLK_LP 213 > #define TEGRA30_CLK_TWD 214 > @@ -260,9 +260,9 @@ > /* 297 */ > /* 298 */ > /* 299 */ > -#define TEGRA30_CLK_CLK_OUT_1_MUX 300 > -#define TEGRA30_CLK_CLK_OUT_2_MUX 301 > -#define TEGRA30_CLK_CLK_OUT_3_MUX 302 > +/* 300 */ > +/* 301 */ > +/* 302 */ > #define TEGRA30_CLK_AUDIO0_MUX 303 > #define TEGRA30_CLK_AUDIO1_MUX 304 > #define TEGRA30_CLK_AUDIO2_MUX 305 > This a device-tree ABI breakage and I'm not sure that it's okay to break older device-trees (Pixel C Smaug board), maybe some kind of fallback is needed.