Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp5672639ybc; Wed, 27 Nov 2019 07:42:38 -0800 (PST) X-Google-Smtp-Source: APXvYqwj2Xk/XMJdIWE/nHde+zgaW4zJCGg277wJDdO7F0TWRQKM3ny8bW2abB1jJHbiw+Ys+epJ X-Received: by 2002:a17:906:32d3:: with SMTP id k19mr49462812ejk.75.1574869358555; Wed, 27 Nov 2019 07:42:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574869358; cv=none; d=google.com; s=arc-20160816; b=WSG4E2VvlBO692GUUocLuv+QFo9Gx9IjK5KLStStZuODNRGU4HGYMkecB3KUsufBLa eTLu/hPhs6jSkcCuQsTRfXCPiNCSO5fIDCT4LCliJ56ckAlkpJIdM0K/krAh+yDHWKLQ 9i0wW0H27cFXp6rCzVouqLyE8VkljPVnXWxvIRNmCbkH3BU0a0li6jHdwOxWSumtv09m 2Aw5yqamVBgdLGnoQV0PRY0bssI3iKTSVUCDDnSTC6STjSrZ0SS7oxeSbbIIKhmiG7Lu kHwcTcRGyaxpnRF+7XG8xY9XbDX98KXQHRwXsIwJEd1bj5myjsnVy9pMnAy4yOVYMsqL Dyyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=EJ/k5yHpNT/oLJLF5rnururzm7YNKh11wmG1fzM9Fk0=; b=lxjpAvpYHGSTxUyn6rPZapvrYVYi/UWiChMBNZudLCuC+RE+CGLcWd7deNK7QcA4XU uPXUNpGRGwauQ3ktcv+c1IAHepT+U6dmgviovYzfl/weOdgYgzQim1XTSYtJGsOInQ+h iTAlRzmZRUPbTzHaCdEJckRb0OxonWxxMu/4/4RoBTy0xbJKtorpmb0wH9ZGfy5iHeUC 3XMD78oeOfsT51Sy29goyvYJxneZs7S9z+9dTan1jVnMzU9b2I9pkKuK895bsiMckLKO S8j7FPb7idoUx7wGdrZ7NqGmZEIOhpjhwNVGFtRm4hnBTrEQ2EzqXmWGi/nERjT/8CyN kWJQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ca10si10245601edb.67.2019.11.27.07.42.14; Wed, 27 Nov 2019 07:42:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727095AbfK0PkU (ORCPT + 99 others); Wed, 27 Nov 2019 10:40:20 -0500 Received: from gentwo.org ([3.19.106.255]:39426 "EHLO gentwo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726634AbfK0PkU (ORCPT ); Wed, 27 Nov 2019 10:40:20 -0500 Received: by gentwo.org (Postfix, from userid 1002) id D60133EF16; Wed, 27 Nov 2019 15:40:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id D50ED3EC1C; Wed, 27 Nov 2019 15:40:19 +0000 (UTC) Date: Wed, 27 Nov 2019 15:40:19 +0000 (UTC) From: Christopher Lameter X-X-Sender: cl@www.lameter.com To: Michal Hocko cc: LKML , linux-mm@kvack.org Subject: Re: SLUB: purpose of sysfs events on cache creation/removal In-Reply-To: <20191126165420.GL20912@dhcp22.suse.cz> Message-ID: References: <20191126121901.GE20912@dhcp22.suse.cz> <20191126165420.GL20912@dhcp22.suse.cz> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Nov 2019, Michal Hocko wrote: > > I have no idea about what this is. > > It seems to be there since the initial merge. I suspect this is just > following a generic sysfs rule that each file has to provide those > events? I have never heard of anyone using this. > > There have been many people who > > reworked the sysfs support and this has been the cause for a lot of > > breakage over the years. > > Remember any specifics? The sequencing of setup / teardown of sysfs entries has frequently been a problem and that caused numerous issues with slab initialization as well as kmem cache creation. Initially kmalloc DMA caches were created on demand which caused some issues. Then there was the back and forth with cache aliasing during kmem_cache_create() that caused another set of instabilities. > I am mostly interested in potential users. In other words I am thinking > to suppress those events. There is already ke knob to control existence > of memcg caches but I do not see anything like this for root caches. > I am not aware of any users but the deployments of Linux are so diverse these days that I am not sure that there are no users.