Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp5687249ybc; Wed, 27 Nov 2019 07:57:17 -0800 (PST) X-Google-Smtp-Source: APXvYqzaxGoVd/mDEVnBbsAKKhHg9gK7xcNeBkfGbtrAAXSsC4SsIJrunsWZqqx8CV5zgmoddr0O X-Received: by 2002:a17:906:eda9:: with SMTP id sa9mr6340689ejb.297.1574870237338; Wed, 27 Nov 2019 07:57:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574870237; cv=none; d=google.com; s=arc-20160816; b=wSIc6XecdP2ba2OQFJKogSgsc0z9HVHKN9t6OfaMST39qRra7lymj046f2P7qYqCOb 1eb7eWvMOZjKAk/DM/EQsR8VdEYPZmDyip09uopjhTtYYmnvISlLFHZT9mwtaMCetwkw vM9m5+BfG+SJ9yIxJVwiXVLiK3hfujYc4L/Sf0FgTwMinpkZd4A6EHREad20hN1cijyI 7crRfqBGFuZtspyHPDwFitlrB2LkxVrHmM2HFcdPHoofSqUHNYl7Fc7cZFGD1Ca3FfR8 3niCNTaEBS6WyYpPPIyPS+XRCsfvc2hvOdR3KdUCiOOfiW32H//uq4/5FelnwKjIAh6b 5t7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=H08bdYeYs+lqktEjGwBPttA3wx1g62UQoerOl025Ous=; b=iOlmOMvcv93BM1R1NQLjqhaYtqiKY013zKqX+z/lKCWmZMRDh5EaOX90arRfoZYfGJ CtX6ssSCBBVYTMVFfxW06B+lGrrRtMUYiTAgdAKtxqq577mXQoJgHJtL4SRT9vjG342T SQZIMJma0nThiDfqbc7vvhiMXAXafcu4Pov9yF07NrsPSl6RFdfXNLT926WkfSxsPLh3 lyg2cBtuMaV+p/duyMq2QfPvTT2Ioy4STLe23na0BaxLKC26l2PugZy51h3mfL0vt3nJ DhMS1q0GMuxYhIXbzeT8RMGG7YhHkDgwcte+MS18/t3QyDbr1qAjZCD6DyYhXsrwOCdw epWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ci3si9543713ejb.37.2019.11.27.07.56.53; Wed, 27 Nov 2019 07:57:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726983AbfK0PzU (ORCPT + 99 others); Wed, 27 Nov 2019 10:55:20 -0500 Received: from gentwo.org ([3.19.106.255]:39434 "EHLO gentwo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726514AbfK0PzU (ORCPT ); Wed, 27 Nov 2019 10:55:20 -0500 Received: by gentwo.org (Postfix, from userid 1002) id 3C4263EF16; Wed, 27 Nov 2019 15:55:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 3A32F3EC1C; Wed, 27 Nov 2019 15:55:19 +0000 (UTC) Date: Wed, 27 Nov 2019 15:55:19 +0000 (UTC) From: Christopher Lameter X-X-Sender: cl@www.lameter.com To: Luc Van Oostenryck cc: Dennis Zhou , Ben Dooks , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Tejun Heo , Nicholas Piggin , Arnd Bergmann Subject: Re: [PATCH] fix __percpu annotation in asm-generic In-Reply-To: <20191126200619.63348-1-luc.vanoostenryck@gmail.com> Message-ID: References: <20191126200619.63348-1-luc.vanoostenryck@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Nov 2019, Luc Van Oostenryck wrote: > So, fix the declaration of the 'pcp' variable to its correct type: > the plain (non-percpu) pointer corresponding to its address. > Same for raw_cpu_generic_xchg(), raw_cpu_generic_cmpxchg() & > raw_cpu_generic_cmpxchg_double(). Acked-by: Christoph Lameter Maybe a better fix is to come up with a typeof_strip_percu() or so macro for all the places where this needs to be done?