Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 27 Nov 2019 17:19:07 +0100
From:   Sam Ravnborg <sam@ravnborg.org>
To:     Mihail Atanassov <Mihail.Atanassov@arm.com>
Cc:     nd <nd@arm.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        David Airlie <airlied@linux.ie>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Vincent Abriou <vincent.abriou@st.com>
Subject: Re: [PATCH 28/30] drm/sti: sti_vdo: Use drm_bridge_init()
Message-ID: <20191127161907.GA17176@ravnborg.org>
References: <20191126131541.47393-1-mihail.atanassov@arm.com>
 <20191126131541.47393-29-mihail.atanassov@arm.com>
 <20191126193740.GC2044@ravnborg.org>
 <2161383.jsAorMfJJG@e123338-lin>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2161383.jsAorMfJJG@e123338-lin>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Mihail.

> > 
> > I can see from grepping that bridge.driver_private is used
> > in a couple of other files in sti/
> > 
> > Like sti_hdmi.c:
> >         bridge->driver_private = hdmi;
> >         bridge->funcs = &sti_hdmi_bridge_funcs;
> >         drm_bridge_attach(encoder, bridge, NULL);
> > 
> > 
> > I wonder if a drm_bridge_init() should be added there.
> > I did not look closely - but it looked suspisiously.
> 
> My goal with drm_bridge_init() was to get devlinks sorted out for
> cross-module uses of a drm_bridge (via of_drm_find_bridge()), so I only
> considered locations where drm_bridge_add/remove() were used.
> 
> Would you be okay with a promise to push a cleanup of this one and the
> one in sti_hda.c after patch 1/30 lands in some form? I'd rather not
> make this series much longer, it's already pushing it at 30 :).

Absolutely - my drive-by comment was more out of concern if this
was missing. A clean-up later souns good.

	Sam