Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 27 Nov 2019 17:50:25 +0100
From:   Ingo Molnar <mingo@kernel.org>
To:     Borislav Petkov <bp@alien8.de>
Cc:     Jules Irenge <jbi.octave@gmail.com>, tglx@linutronix.de,
        linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com,
        mingo@redhat.com
Subject: Re: [PATCH] cpu: microcode: Add comma to 0
Message-ID: <20191127165025.GA10957@gmail.com>
References: <20191126221519.167145-1-jbi.octave@gmail.com>
 <20191127065436.GC52731@gmail.com>
 <20191127112613.GA3812@zn.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191127112613.GA3812@zn.tnic>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


* Borislav Petkov <bp@alien8.de> wrote:

> On Wed, Nov 27, 2019 at 07:54:36AM +0100, Ingo Molnar wrote:
> > 
> > * Jules Irenge <jbi.octave@gmail.com> wrote:
> > 
> > > Add ","  after 0
> > > Because memory for the struct is being cleared
> > > and elements after "," are missing on purpose
> > >  as they are being cleared to
> > > 
> > > Recommended by Boris Petkov
> > > 
> > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> > > ---
> > >  arch/x86/kernel/cpu/microcode/amd.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/arch/x86/kernel/cpu/microcode/amd.c b/arch/x86/kernel/cpu/microcode/amd.c
> > > index a0e52bd00ecc..04ee649f4acb 100644
> > > --- a/arch/x86/kernel/cpu/microcode/amd.c
> > > +++ b/arch/x86/kernel/cpu/microcode/amd.c
> > > @@ -418,7 +418,7 @@ static int __apply_microcode_amd(struct microcode_amd *mc)
> > >  static bool
> > >  apply_microcode_early_amd(u32 cpuid_1_eax, void *ucode, size_t size, bool save_patch)
> > >  {
> > > -	struct cont_desc desc = { 0 };
> > > +	struct cont_desc desc = { 0, };
> > 
> > This is 100% unnecessary - " = { }" is enough of a structure initializer.
> 
> That was my initial thought but empty initializers are not ISO C
> compliant, I've been told.

Yeah, but the kernel isn't ISO C, and the hive mind has spoken in favor 
of the shortest variant:

  dagon:~/tip> git grep '= { }' | wc -l
  647

  dagon:~/tip> git grep '= { 0, }' | wc -l
  231

  dagon:~/tip> git grep '= { NULL, }' | wc -l
  38

:-)

Thanks,

	Ingo