Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 27 Nov 2019 17:57:53 +0100
From:   Paul Cercueil <paul@crapouillou.net>
Subject: Re: [PATCH v4 4/6] MIPS: Ingenic: Initial YSH & ATIL CU Neo board
 support.
To:     Zhou Yanjie <zhouyanjie@zoho.com>
Cc:     linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, robh+dt@kernel.org,
        paul.burton@mips.com, paulburton@kernel.org, jhogan@kernel.org,
        mripard@kernel.org, shawnguo@kernel.org, mark.rutland@arm.com,
        syq@debian.org, ralf@linux-mips.org, heiko@sntech.de,
        icenowy@aosc.io, laurent.pinchart@ideasonboard.com,
        krzk@kernel.org, geert+renesas@glider.be,
        prasannatsmkumar@gmail.com, sernia.zhou@foxmail.com,
        zhenwenjin@gmail.com, 772753199@qq.com
Message-Id: <1574873873.3.1@crapouillou.net>
In-Reply-To: <1574787974-58040-5-git-send-email-zhouyanjie@zoho.com>
References: <1574787974-58040-1-git-send-email-zhouyanjie@zoho.com>
        <1574787974-58040-5-git-send-email-zhouyanjie@zoho.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Zhou,


Le mer., nov. 27, 2019 at 01:06, Zhou Yanjie <zhouyanjie@zoho.com> a=20
=E9crit :
> Add a device tree for the Ingenic X1000 based YSH & ATIL CU Neo board.
> Note that this is unselectable via Kconfig until the X1000 SoC is made
> selectable in a later commit.
>=20
> Signed-off-by: Zhou Yanjie <zhouyanjie@zoho.com>
> ---
>=20
> Notes:
>     v1->v2:
>     Rebase on top of mips-next, use TCU for system timer and=20
> clocksource.
>=20
>     v2->v3:
>     No change.
>=20
>     v3->v4:
>     1.Adjust "model" in "cu1000.dts" to match the description in=20
> "devices.yaml".
>     2.Adjust "bool" in "Kconfig" to avoid duplicate names with=20
> subsequent boards.
>=20
>  arch/mips/boot/dts/ingenic/Makefile   |   1 +
>  arch/mips/boot/dts/ingenic/cu1000.dts |  52 ++++++++++++++++++
>  arch/mips/configs/cu1000_defconfig    | 100=20
> ++++++++++++++++++++++++++++++++++
>  arch/mips/jz4740/Kconfig              |   4 ++
>  4 files changed, 157 insertions(+)
>  create mode 100644 arch/mips/boot/dts/ingenic/cu1000.dts
>  create mode 100644 arch/mips/configs/cu1000_defconfig
>=20
> diff --git a/arch/mips/boot/dts/ingenic/Makefile=20
> b/arch/mips/boot/dts/ingenic/Makefile
> index 9cc4844..f6db7bb 100644
> --- a/arch/mips/boot/dts/ingenic/Makefile
> +++ b/arch/mips/boot/dts/ingenic/Makefile
> @@ -2,5 +2,6 @@
>  dtb-$(CONFIG_JZ4740_QI_LB60)	+=3D qi_lb60.dtb
>  dtb-$(CONFIG_JZ4770_GCW0)	+=3D gcw0.dtb
>  dtb-$(CONFIG_JZ4780_CI20)	+=3D ci20.dtb
> +dtb-$(CONFIG_X1000_CU1000)	+=3D cu1000.dtb
>=20
>  obj-$(CONFIG_BUILTIN_DTB)	+=3D $(addsuffix .o, $(dtb-y))
> diff --git a/arch/mips/boot/dts/ingenic/cu1000.dts=20
> b/arch/mips/boot/dts/ingenic/cu1000.dts
> new file mode 100644
> index 00000000..f92f6af
> --- /dev/null
> +++ b/arch/mips/boot/dts/ingenic/cu1000.dts
> @@ -0,0 +1,52 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/dts-v1/;
> +
> +#include "x1000.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/clock/ingenic,tcu.h>
> +
> +/ {
> +	compatible =3D "yna,cu1000", "ingenic,x1000";
> +	model =3D "YSH & ATIL General Board CU Neo";
> +
> +	aliases {
> +		serial2 =3D &uart2;
> +	};
> +
> +	chosen {
> +		stdout-path =3D &uart2;
> +	};
> +
> +	memory {
> +		device_type =3D "memory";
> +		reg =3D <0x0 0x04000000>;
> +	};
> +};
> +
> +&exclk {
> +	clock-frequency =3D <24000000>;
> +};
> +
> +&tcu {
> +	/* 1500 kHz for the system timer and clocksource */
> +	assigned-clocks =3D <&tcu TCU_CLK_TIMER0>, <&tcu TCU_CLK_TIMER2>;
> +	assigned-clock-rates =3D <1500000>, <1500000>;
> +
> +	/* Use channel #1 for the system timer channel #2 for the=20
> clocksource */
> +	ingenic,pwm-channels-mask =3D <0xfa>;

 From the mask used, I'm gessing that you're reserving channels #0 and=20
#2, not #1 and #2.

> +};
> +
> +&uart2 {
> +	status =3D "okay";
> +
> +	pinctrl-names =3D "default";
> +	pinctrl-0 =3D <&pins_uart2>;
> +};
> +
> +&pinctrl {
> +	pins_uart2: uart2 {
> +		function =3D "uart2";
> +		groups =3D "uart2-data-d";
> +		bias-disable;
> +	};
> +};
> diff --git a/arch/mips/configs/cu1000_defconfig=20
> b/arch/mips/configs/cu1000_defconfig
> new file mode 100644
> index 00000000..88729ee
> --- /dev/null
> +++ b/arch/mips/configs/cu1000_defconfig
> @@ -0,0 +1,100 @@
> +CONFIG_LOCALVERSION_AUTO=3Dy
> +CONFIG_KERNEL_GZIP=3Dy
> +CONFIG_SYSVIPC=3Dy
> +CONFIG_NO_HZ_IDLE=3Dy
> +CONFIG_HIGH_RES_TIMERS=3Dy
> +CONFIG_PREEMPT=3Dy
> +CONFIG_IKCONFIG=3Dy
> +CONFIG_IKCONFIG_PROC=3Dy
> +CONFIG_LOG_BUF_SHIFT=3D14
> +CONFIG_CGROUPS=3Dy
> +CONFIG_MEMCG=3Dy
> +CONFIG_MEMCG_KMEM=3Dy
> +CONFIG_CGROUP_SCHED=3Dy
> +CONFIG_CGROUP_FREEZER=3Dy
> +CONFIG_CGROUP_DEVICE=3Dy
> +CONFIG_CGROUP_CPUACCT=3Dy
> +CONFIG_NAMESPACES=3Dy
> +CONFIG_USER_NS=3Dy
> +CONFIG_BLK_DEV_INITRD=3Dy
> +CONFIG_INITRAMFS_SOURCE=3D"arch/mips/boot/ramdisk.cpio.gz"
> +CONFIG_CC_OPTIMIZE_FOR_SIZE=3Dy
> +CONFIG_SYSCTL_SYSCALL=3Dy
> +CONFIG_KALLSYMS_ALL=3Dy
> +CONFIG_EMBEDDED=3Dy
> +# CONFIG_VM_EVENT_COUNTERS is not set
> +# CONFIG_COMPAT_BRK is not set
> +CONFIG_SLAB=3Dy
> +CONFIG_MACH_INGENIC=3Dy
> +CONFIG_X1000_CU1000=3Dy
> +CONFIG_HIGHMEM=3Dy
> +CONFIG_HZ_100=3Dy
> +CONFIG_HZ=3D100

This line looks malformed.

> +# CONFIG_SECCOMP is not set
> +# CONFIG_SUSPEND is not set
> +# CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set
> +# CONFIG_COMPACTION is not set
> +CONFIG_CMA=3Dy
> +CONFIG_CMA_AREAS=3D7
> +CONFIG_UEVENT_HELPER=3Dy
> +CONFIG_UEVENT_HELPER_PATH=3D"/sbin/hotplug"
> +CONFIG_DEVTMPFS=3Dy
> +# CONFIG_FW_LOADER is not set
> +# CONFIG_ALLOW_DEV_COREDUMP is not set
> +# CONFIG_INPUT_MOUSEDEV is not set
> +# CONFIG_INPUT_KEYBOARD is not set
> +# CONFIG_INPUT_MOUSE is not set
> +# CONFIG_SERIO is not set
> +CONFIG_VT_HW_CONSOLE_BINDING=3Dy
> +CONFIG_LEGACY_PTY_COUNT=3D2
> +CONFIG_SERIAL_EARLYCON=3Dy
> +CONFIG_SERIAL_8250=3Dy
> +CONFIG_SERIAL_8250_CONSOLE=3Dy
> +CONFIG_SERIAL_8250_NR_UARTS=3D3
> +CONFIG_SERIAL_8250_RUNTIME_UARTS=3D3
> +CONFIG_SERIAL_8250_INGENIC=3Dy
> +CONFIG_SERIAL_OF_PLATFORM=3Dy
> +# CONFIG_HW_RANDOM is not set
> +CONFIG_GPIO_SYSFS=3Dy
> +# CONFIG_HWMON is not set
> +# CONFIG_LCD_CLASS_DEVICE is not set
> +# CONFIG_BACKLIGHT_CLASS_DEVICE is not set
> +# CONFIG_VGA_CONSOLE is not set
> +# CONFIG_HID is not set
> +# CONFIG_USB_SUPPORT is not set
> +# CONFIG_IOMMU_SUPPORT is not set
> +CONFIG_NVMEM=3Dy
> +CONFIG_NVMEM_SYSFS=3Dy
> +CONFIG_EXT4_FS=3Dy
> +# CONFIG_DNOTIFY is not set
> +CONFIG_PROC_KCORE=3Dy
> +# CONFIG_PROC_PAGE_MONITOR is not set
> +CONFIG_TMPFS=3Dy
> +CONFIG_CONFIGFS_FS=3Dy
> +CONFIG_NLS=3Dy
> +CONFIG_NLS_CODEPAGE_936=3Dy
> +CONFIG_NLS_CODEPAGE_950=3Dy
> +CONFIG_NLS_ASCII=3Dy
> +CONFIG_NLS_ISO8859_1=3Dy
> +CONFIG_NLS_UTF8=3Dy
> +CONFIG_CRYPTO_ECHAINIV=3Dy
> +CONFIG_CRYPTO_AES=3Dy
> +CONFIG_CRYPTO_DEFLATE=3Dy
> +CONFIG_CRYPTO_LZO=3Dy
> +CONFIG_PRINTK_TIME=3Dy
> +CONFIG_CONSOLE_LOGLEVEL_DEFAULT=3D15
> +CONFIG_CONSOLE_LOGLEVEL_QUIET=3D15
> +CONFIG_MESSAGE_LOGLEVEL_DEFAULT=3D7
> +CONFIG_DEBUG_INFO=3Dy
> +CONFIG_STRIP_ASM_SYMS=3Dy
> +CONFIG_DEBUG_FS=3Dy
> +CONFIG_MAGIC_SYSRQ=3Dy
> +CONFIG_PANIC_ON_OOPS=3Dy
> +CONFIG_PANIC_TIMEOUT=3D10
> +# CONFIG_SCHED_DEBUG is not set
> +# CONFIG_DEBUG_PREEMPT is not set
> +CONFIG_STACKTRACE=3Dy
> +# CONFIG_FTRACE is not set
> +CONFIG_CMDLINE_BOOL=3Dy
> +CONFIG_CMDLINE=3D"console=3DttyS2,115200n8 mem=3D32M@0x0 earlycon=20
> clk_ignore_unused"

You already specify the stdout-path in the devicetree, no need to pass=20
the "console" parameter.

For the "mem" parameter, it's already set in the devicetree, so no need=20
to set it again here.
Besides, in the devicetree it is set to 64 MiB.

Why is clk_ignore_unused needed?

Cheers,
-Paul

> +CONFIG_CMDLINE_OVERRIDE=3Dy
> diff --git a/arch/mips/jz4740/Kconfig b/arch/mips/jz4740/Kconfig
> index 6b96844..ccaf507 100644
> --- a/arch/mips/jz4740/Kconfig
> +++ b/arch/mips/jz4740/Kconfig
> @@ -16,6 +16,10 @@ config JZ4780_CI20
>  	bool "MIPS Creator CI20"
>  	select MACH_JZ4780
>=20
> +config X1000_CU1000
> +	bool "YSH & ATIL General Module CU1000"
> +	select MACH_X1000
> +
>  endchoice
>=20
>  config MACH_JZ4740
> --
> 2.7.4
>=20
>=20

=