Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp5768002ybc; Wed, 27 Nov 2019 09:08:25 -0800 (PST) X-Google-Smtp-Source: APXvYqwu8oQGm7NM+6j4hqojW8ThHtnADrSS45xgW5LaUGvB3jvSmzELf01rZaA93hj5Z4m+mxUk X-Received: by 2002:a50:ef0b:: with SMTP id m11mr33124336eds.74.1574874505531; Wed, 27 Nov 2019 09:08:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574874505; cv=none; d=google.com; s=arc-20160816; b=aZzbGl7YXFan3TIe/JMciB7zVjjbK+EQxTKhvXybtj4k9EbltKbDdbCEZE8Y48xWkm +wBlbgRzCbsk6eP8HIKfT+/MvVgVIDgzmA0VXPBWWC6hzs/70bLdd3xp7ajjEWk7ulA7 FP5VmGa9RC+VfvGoeEB8mCMWold3vbzZGSBO+gzk6t3DrpO849ki3cvrWrlT4svRJtN6 W/aQlPtLST2L6ALkradQayq3CgfbzaQpU8y1SZvhBIoVnKdQQatgAbUsANADAlxqcLQL jjhicUv/1rxNmi6agB9H9wLNutyKwS49yO+m+JDSXSca/VPQakrRrEmhJxvS6ne6uXuO zexw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=yfFAgovfNlbjMD9teZVuzNd4RTYpPguSrjSnFEf5No0=; b=jBfGSBdVB04YMk+00+wb/zTPy1z7wWEF8zog/DpjLwD5uXHT7w5ObeTMN8Tdq1R7RY THhVfEMpAO2pkXnWUfwspNs5gRWnzyX2E/XF9ar7sYNE1WnXv20YT4by+IZntfKPLJi+ 9Eq16hpDQQw+muDgcBj7IXu5DiWCMYb+jpR2KM9y0JMly+4cT9YQyaqt1nhnNZYPSPzP 2MwSLw9XoKYvMxF0JLfnY9OUAfjFnVHl4CaDzq+jLP5uE4lzEZO+4QqygwWyj9Fs2Pvi 73e+OUufEbtGq9EMfHkcyVSPhWuToAzgrIZG6J88frGpenkgHj58rpg1TUFAB68g8SOr s6Lw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=TKLz+vGx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h49si11162190edh.2.2019.11.27.09.08.01; Wed, 27 Nov 2019 09:08:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=TKLz+vGx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727128AbfK0RG0 (ORCPT + 99 others); Wed, 27 Nov 2019 12:06:26 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:14541 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726729AbfK0RGZ (ORCPT ); Wed, 27 Nov 2019 12:06:25 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 27 Nov 2019 09:06:26 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 27 Nov 2019 09:06:23 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 27 Nov 2019 09:06:23 -0800 Received: from [10.2.169.149] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 27 Nov 2019 17:06:22 +0000 Subject: Re: [PATCH v2 06/11] dt-bindings: clock: tegra: Remove pmc clock ids from clock dt-bindings To: Dmitry Osipenko , , , , , , , , CC: , , , , , , , , , , , , , , , , , References: <1574830773-14892-1-git-send-email-skomatineni@nvidia.com> <1574830773-14892-7-git-send-email-skomatineni@nvidia.com> <22ab4e93-bf94-5c73-b4b9-6cf36d329b97@gmail.com> From: Sowjanya Komatineni Message-ID: <37bc8353-23c3-0ad6-6a91-acea6c2d041f@nvidia.com> Date: Wed, 27 Nov 2019 09:06:24 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <22ab4e93-bf94-5c73-b4b9-6cf36d329b97@gmail.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1574874386; bh=yfFAgovfNlbjMD9teZVuzNd4RTYpPguSrjSnFEf5No0=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=TKLz+vGxVQYWB7gBouOFRzTXHcz9xZMw7RkQSXaPB2lPGvD1tRhYJkjo51h2kYL5m BDksMBDYV1QqtEY3C975oo0DF8G/XWX5UXJWxGKEwnCdEvOFyiourUPX6r6PSWmwbK xHPWya4J0HinoDFWb+8K+orAiI6oetHG08sGtrbzJ5daBFY/tdqgqDjg25U2KahlH7 Fztq3AE2F/A98c5IHN1JYok6QzZauDmZoWjx4bdCvdIFuQ/JRnl6VBaqN4D7Mqmq2u Z1NcAZt3SQerlzYtLS/sA/J2oWh5QNJXjiU6bl1hsJtN0aqvcwuI6PljqhE6KqH/GT kfmlDe6AS+Hsg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/27/19 6:32 AM, Dmitry Osipenko wrote: > 27.11.2019 07:59, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> clk_out_1, clk_out_2, clk_out_3, blink are part of Tegra pmc clocks. >> >> This patch removes ids for these clocks from Tegra clock dt-bindings. >> >> Signed-off-by: Sowjanya Komatineni >> --- >> include/dt-bindings/clock/tegra114-car.h | 14 +++++++------- >> include/dt-bindings/clock/tegra124-car-common.h | 14 +++++++------- >> include/dt-bindings/clock/tegra20-car.h | 2 +- >> include/dt-bindings/clock/tegra210-car.h | 14 +++++++------- >> include/dt-bindings/clock/tegra30-car.h | 14 +++++++------- >> 5 files changed, 29 insertions(+), 29 deletions(-) >> >> diff --git a/include/dt-bindings/clock/tegra114-car.h b/include/dt-bindi= ngs/clock/tegra114-car.h >> index bb5c2c999c05..9175cd0571b5 100644 >> --- a/include/dt-bindings/clock/tegra114-car.h >> +++ b/include/dt-bindings/clock/tegra114-car.h >> @@ -270,10 +270,10 @@ >> #define TEGRA114_CLK_AUDIO3 242 >> #define TEGRA114_CLK_AUDIO4 243 >> #define TEGRA114_CLK_SPDIF 244 >> -#define TEGRA114_CLK_CLK_OUT_1 245 >> -#define TEGRA114_CLK_CLK_OUT_2 246 >> -#define TEGRA114_CLK_CLK_OUT_3 247 >> -#define TEGRA114_CLK_BLINK 248 >> +/* 245 */ >> +/* 246 */ >> +/* 247 */ >> +/* 248 */ >> /* 249 */ >> /* 250 */ >> /* 251 */ >> @@ -333,9 +333,9 @@ >> #define TEGRA114_CLK_AUDIO3_MUX 303 >> #define TEGRA114_CLK_AUDIO4_MUX 304 >> #define TEGRA114_CLK_SPDIF_MUX 305 >> -#define TEGRA114_CLK_CLK_OUT_1_MUX 306 >> -#define TEGRA114_CLK_CLK_OUT_2_MUX 307 >> -#define TEGRA114_CLK_CLK_OUT_3_MUX 308 >> +/* 306 */ >> +/* 307 */ >> +/* 308 */ >> #define TEGRA114_CLK_DSIA_MUX 309 >> #define TEGRA114_CLK_DSIB_MUX 310 >> #define TEGRA114_CLK_XUSB_SS_DIV2 311 >> diff --git a/include/dt-bindings/clock/tegra124-car-common.h b/include/d= t-bindings/clock/tegra124-car-common.h >> index 0c4f5be0a742..90a0c5e7eb5f 100644 >> --- a/include/dt-bindings/clock/tegra124-car-common.h >> +++ b/include/dt-bindings/clock/tegra124-car-common.h >> @@ -269,10 +269,10 @@ >> #define TEGRA124_CLK_AUDIO3 242 >> #define TEGRA124_CLK_AUDIO4 243 >> #define TEGRA124_CLK_SPDIF 244 >> -#define TEGRA124_CLK_CLK_OUT_1 245 >> -#define TEGRA124_CLK_CLK_OUT_2 246 >> -#define TEGRA124_CLK_CLK_OUT_3 247 >> -#define TEGRA124_CLK_BLINK 248 >> +/* 245 */ >> +/* 246 */ >> +/* 247 */ >> +/* 248 */ >> /* 249 */ >> /* 250 */ >> /* 251 */ >> @@ -332,9 +332,9 @@ >> #define TEGRA124_CLK_AUDIO3_MUX 303 >> #define TEGRA124_CLK_AUDIO4_MUX 304 >> #define TEGRA124_CLK_SPDIF_MUX 305 >> -#define TEGRA124_CLK_CLK_OUT_1_MUX 306 >> -#define TEGRA124_CLK_CLK_OUT_2_MUX 307 >> -#define TEGRA124_CLK_CLK_OUT_3_MUX 308 >> +/* 306 */ >> +/* 307 */ >> +/* 308 */ >> /* 309 */ >> /* 310 */ >> #define TEGRA124_CLK_SOR0_LVDS 311 /* deprecated */ >> diff --git a/include/dt-bindings/clock/tegra20-car.h b/include/dt-bindin= gs/clock/tegra20-car.h >> index b21a0eb32921..fe541f627965 100644 >> --- a/include/dt-bindings/clock/tegra20-car.h >> +++ b/include/dt-bindings/clock/tegra20-car.h >> @@ -131,7 +131,7 @@ >> #define TEGRA20_CLK_CCLK 108 >> #define TEGRA20_CLK_HCLK 109 >> #define TEGRA20_CLK_PCLK 110 >> -#define TEGRA20_CLK_BLINK 111 >> +/* 111 */ >> #define TEGRA20_CLK_PLL_A 112 >> #define TEGRA20_CLK_PLL_A_OUT0 113 >> #define TEGRA20_CLK_PLL_C 114 >> diff --git a/include/dt-bindings/clock/tegra210-car.h b/include/dt-bindi= ngs/clock/tegra210-car.h >> index 44f60623f99b..a3d8d3e75728 100644 >> --- a/include/dt-bindings/clock/tegra210-car.h >> +++ b/include/dt-bindings/clock/tegra210-car.h >> @@ -304,10 +304,10 @@ >> #define TEGRA210_CLK_AUDIO3 274 >> #define TEGRA210_CLK_AUDIO4 275 >> #define TEGRA210_CLK_SPDIF 276 >> -#define TEGRA210_CLK_CLK_OUT_1 277 >> -#define TEGRA210_CLK_CLK_OUT_2 278 >> -#define TEGRA210_CLK_CLK_OUT_3 279 >> -#define TEGRA210_CLK_BLINK 280 >> +/* 277 */ >> +/* 278 */ >> +/* 279 */ >> +/* 280 */ >> #define TEGRA210_CLK_SOR0_LVDS 281 /* deprecated */ >> #define TEGRA210_CLK_SOR0_OUT 281 >> #define TEGRA210_CLK_SOR1_OUT 282 >> @@ -386,9 +386,9 @@ >> #define TEGRA210_CLK_AUDIO3_MUX 353 >> #define TEGRA210_CLK_AUDIO4_MUX 354 >> #define TEGRA210_CLK_SPDIF_MUX 355 >> -#define TEGRA210_CLK_CLK_OUT_1_MUX 356 >> -#define TEGRA210_CLK_CLK_OUT_2_MUX 357 >> -#define TEGRA210_CLK_CLK_OUT_3_MUX 358 >> +/* 356 */ >> +/* 357 */ >> +/* 358 */ >> #define TEGRA210_CLK_DSIA_MUX 359 >> #define TEGRA210_CLK_DSIB_MUX 360 >> /* 361 */ >> diff --git a/include/dt-bindings/clock/tegra30-car.h b/include/dt-bindin= gs/clock/tegra30-car.h >> index 3c90f1535551..20ef2462d9e1 100644 >> --- a/include/dt-bindings/clock/tegra30-car.h >> +++ b/include/dt-bindings/clock/tegra30-car.h >> @@ -230,11 +230,11 @@ >> #define TEGRA30_CLK_AUDIO3 204 >> #define TEGRA30_CLK_AUDIO4 205 >> #define TEGRA30_CLK_SPDIF 206 >> -#define TEGRA30_CLK_CLK_OUT_1 207 /* (extern1) */ >> -#define TEGRA30_CLK_CLK_OUT_2 208 /* (extern2) */ >> -#define TEGRA30_CLK_CLK_OUT_3 209 /* (extern3) */ >> +/* 207 */ >> +/* 208 */ >> +/* 209 */ >> #define TEGRA30_CLK_SCLK 210 >> -#define TEGRA30_CLK_BLINK 211 >> +/* 211 */ >> #define TEGRA30_CLK_CCLK_G 212 >> #define TEGRA30_CLK_CCLK_LP 213 >> #define TEGRA30_CLK_TWD 214 >> @@ -260,9 +260,9 @@ >> /* 297 */ >> /* 298 */ >> /* 299 */ >> -#define TEGRA30_CLK_CLK_OUT_1_MUX 300 >> -#define TEGRA30_CLK_CLK_OUT_2_MUX 301 >> -#define TEGRA30_CLK_CLK_OUT_3_MUX 302 >> +/* 300 */ >> +/* 301 */ >> +/* 302 */ >> #define TEGRA30_CLK_AUDIO0_MUX 303 >> #define TEGRA30_CLK_AUDIO1_MUX 304 >> #define TEGRA30_CLK_AUDIO2_MUX 305 >> > This a device-tree ABI breakage and I'm not sure that it's okay to break > older device-trees (Pixel C Smaug board), maybe some kind of fallback is > needed. As provider itself changed from tegra_car to pmc, all platform=20 device-trees using CLK_OUT_1/2/3 ids from Tegra car should be moved to=20 PMC and use PMC clock ids. Based on upstream device tree search, I only see samsung t210 device=20 tree currently using CLK_OUT_2. So updated that as part of this series.