Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp5776141ybc; Wed, 27 Nov 2019 09:14:53 -0800 (PST) X-Google-Smtp-Source: APXvYqzS8UiDreFwQSbN8v9W7SgiQ5bO2ZdkeLgBOYK1vRks63kx05KagHOy2t50kSgJSKnKQNOw X-Received: by 2002:aa7:c314:: with SMTP id l20mr33239592edq.34.1574874893750; Wed, 27 Nov 2019 09:14:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574874893; cv=none; d=google.com; s=arc-20160816; b=tvsxdcQFIgMhv1gFYxAeil0nCq0WlX2R57hvscbGYb1dmvqZgsvJieVlY5dFcnapcx woLB7ejcBRnqENXgTe6VQnLfbSXq+833CwdOvx38AiGU7nl/Ck4wpgz6gh8TkBbHuJMN Vzt97q+Zj01W4LIfDBqWiyHmG/Harhs/TXCQefTkucHKOP1CzD5x0zftwcwoPgvOgApc 0WJhbt4pipSaWoGJl8OATMhDY3CyTHc5ZyFi5xtlZ3hbNNBypLZWCIK7baOZX3BAlrZF 1al2N+9QvwjL/k4NaV5i9U1F9oK11flzCuGe8wbBdwdQEusG6V01RGHB5l1AxuY+UkWv QjrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=pEDHHVwu6bn2JJ/YM1Ka+McvYISRwpXtn4e69OMZoRY=; b=dWozhv0o5qTaI5GffgjFUJ70DAhq8E4wWzCgVZS1ZBuytnbt6Munyqp5wJwFXwj8ub zaDaxqqdKUDW91K3CaVUNX2kBEl6VXvOEUgT7/3uLtTpAXdO9X862TxmHiyyNKZN6VeN g1h4I13rVaflk3Ekkwt/5iy8gS7xJ+gwjNkuxCswtxsZY/D6dZWA6/fV5ZC69g/BuYEE SslM3J4lkrbxTu2JZbwYpZUc/kel/9rxQ47Wk1fVBIpPLt337rxEiBqgRpu26LPCEWPw OlU2Y0vU5PNBDKsYrVa2s9JO6uqu6CYevCzfwnmE3gCJtnIexX/DJfi5EcHZmKpBwbQx pkJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=FrHgGXXU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h49si11162190edh.2.2019.11.27.09.14.29; Wed, 27 Nov 2019 09:14:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=FrHgGXXU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726664AbfK0RN0 (ORCPT + 99 others); Wed, 27 Nov 2019 12:13:26 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:38828 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726292AbfK0RN0 (ORCPT ); Wed, 27 Nov 2019 12:13:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=pEDHHVwu6bn2JJ/YM1Ka+McvYISRwpXtn4e69OMZoRY=; b=FrHgGXXUzlnTbKjWArLd6PYTb ptGd/xSCW7mCL42n2ht9QnfSu5p+yMMhQbgamAE+g1fmA/BoB1cD9lWaBQkgtH0Bqtf6GRjG6Gl39 UiuiXwouB1kkvbpo/tLm8ckMVYF2LkPIREf8Qu2ztxwlQiaGPF29U4Ed7+z/vn7ELN4Pgeh9j6Roh Uy3kJNDkasfGlq8LeWEYwZyanCh7RLCk/96vXOjaq4SqbEqJrPIndLN/f9lUZxtioe2OAv7dt8AWk 25Az9q76OwMcN53IYSJEPANTwqzKuwqjDvRjJ7zlviJAH3BjqFvE2CG+iNKLdH3iGEoNOKTZFfxlr yopbuTodg==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1ia0sU-0005M9-Ce; Wed, 27 Nov 2019 17:13:22 +0000 Date: Wed, 27 Nov 2019 09:13:22 -0800 From: Matthew Wilcox To: Christoph Hellwig Cc: Thomas Hellstrom , Christian =?iso-8859-1?Q?K=F6nig?= , Tom Lendacky , iommu@lists.linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dma-mapping: move dma_addressing_limited out of line Message-ID: <20191127171322.GE20752@bombadil.infradead.org> References: <20191127144006.25998-1-hch@lst.de> <20191127144006.25998-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191127144006.25998-2-hch@lst.de> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 27, 2019 at 03:40:05PM +0100, Christoph Hellwig wrote: > +/** > + * dma_addressing_limited - return if the device is addressing limited > + * @dev: device to check > + * > + * Return %true if the devices DMA mask is too small to address all memory in Could I trouble you to use a : after Return? That turns it into its own section rather than making it part of the generic description.