Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <7dd89f27e886fc73e3de4d2a92e27f443978f318.camel@linux.ibm.com>
Subject: Re: [PATCH 1/1] powerpc/kvm/book3s: Fixes possible 'use after
 release' of kvm
From:   Leonardo Bras <leonardo@linux.ibm.com>
To:     Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc:     Paul Mackerras <paulus@ozlabs.org>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Radim =?UTF-8?Q?Kr=C4=8Dm=C3=A1=C5=99?= <rkrcmar@redhat.com>
Date:   Wed, 27 Nov 2019 17:18:57 -0300
In-Reply-To: <f3750cf8-88fc-cae7-1cfb-cb4b86b44704@redhat.com>
References: <20191126175212.377171-1-leonardo@linux.ibm.com>
         <f3750cf8-88fc-cae7-1cfb-cb4b86b44704@redhat.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-svLp0XGwOGKrM1lqBRkB"
User-Agent: Evolution 3.34.1 (3.34.1-1.fc31) 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-svLp0XGwOGKrM1lqBRkB
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2019-11-27 at 17:40 +0100, Paolo Bonzini wrote:
> >  =20
> >        if (ret >=3D 0)
> >                list_add_rcu(&stt->list, &kvm->arch.spapr_tce_tables);
> > -     else
> > -             kvm_put_kvm(kvm);
> >  =20
> >        mutex_unlock(&kvm->lock);
> >  =20
> >        if (ret >=3D 0)
> >                return ret;
> >  =20
> > +     kvm_put_kvm(kvm);
> >        kfree(stt);
> >    fail_acct:
> >        account_locked_vm(current->mm, kvmppc_stt_pages(npages), false);
>=20
> This part is a good change, as it makes the code clearer.  The
> virt/kvm/kvm_main.c bits, however, are not necessary as explained by Sean=
.
>=20

Thanks!
So, like this patch?
https://lkml.org/lkml/2019/11/7/763

Best regards,

Leonardo

--=-svLp0XGwOGKrM1lqBRkB
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEMdeUgIzgjf6YmUyOlQYWtz9SttQFAl3e2jEACgkQlQYWtz9S
ttTWzxAAy+Q8kuOW+58Zujf5Pl1VAPNeOj8APWTSfbtEtYh+qeriS0Fx+MlwfycO
jKea8M8pTxuNFG88V9+rQM+qciE5UpqGYqTPkbhHEsrXYcBRPct/bS6/EmYc5wve
MeTLOTW11fnZYR9WXghKpPhM2AOCvBYPMq3nnQUFqr0DLk7tkOB7OuHk9qASTVbH
dZvU9rXIIMa5cxH4v0/qEZtzY+9/UStvDUM3cghd9p0DqDtGL396wIQwvRMfxT94
KP925KeLoi1wqIAH7VUxgrP8/SkLPfgMwG1QuyIiWO2cqHE9MpozjDU9hOebXoyb
UVJngHT/oRyG7plHLcZ6eedy75M6Z4lKv3oviezjEjIRr8pC7/xT2MZYiV3dox9c
rd9KgDTLihHEBfKmKnocErwvEleu9Dr6vJ6zBU1bWOahROryvuPdZ00SbVGZIa0U
MFyIinaBDLWwn6zhpGZVc1vUqy1lmJnS91116u+og30IgwXMYpb6sHFUWmr9B0Ai
40tdEGnFKthSCeyskqBrLab4ykV49MLJxd9cK4kwnWou1M6Fl1kDY86h1P6afqEG
RAbTtL4HCmOButVZjP5kzTnONkIZWLSmkibqSx4Gxl9Lw2u+jg523Ds9Ye2Pfqrd
NARjPJb+1h6PU2IiDLmoC7r+axcI+Np+xacERZEOFo51lE0wI/c=
=CM/a
-----END PGP SIGNATURE-----

--=-svLp0XGwOGKrM1lqBRkB--