Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp5977433ybc; Wed, 27 Nov 2019 12:45:50 -0800 (PST) X-Google-Smtp-Source: APXvYqzrNMAryXBpovNbwYZPN5bksIVAi31njc0Zg1Os0S2l7lQM+iNkKmdptOghBCYcUgMMtLtR X-Received: by 2002:a50:f699:: with SMTP id d25mr33529059edn.72.1574887549925; Wed, 27 Nov 2019 12:45:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574887549; cv=none; d=google.com; s=arc-20160816; b=Bl7KTjGofxP0/q06OGLGiwKLIvHP/HrqU41w0fYpzcsENLlPil4gvMLZUgFzJ6TtqA aMBgy19pT7zIbKZsKlkk2tOJll/UO7x60EV9H5UdDNP9mnWTUtXFP7TvJdB3XoIjpoHN nE7rasqAk5sflDA0NLUQugMf8fepv+bBnk1zs8YZdyDZ+G5IX9rJpEUuAa2XBsHNKGpW JWaAR85QHROCotbu87iWKyR72iBzzbzEnhsR5wk9rQPqqmR0IGrVD+wzCgibdUrZTK3m fmshvEQN6i0wSy5BtBvsm+60egxdn+FF/j/s8woeyibKoPF54slAztIKiyv3ekA4MJbn h/kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=F1hHBwiCJqh96ny5WDuDomsgG69DRhjjUllzVxdH7D0=; b=OLZLDGKG3zDCP5WYkblQNQEA+1unybGtt8ZNJjquGBXRIRzEwc/f2OTElr6ETDHYLp lxlU3UfhxSgQWONI9XKXBAUyISgzXsQJfrBoG7z0+MVOkubVPMjsUCceLOhhuZlAo+pI kcDqj65wh1hf0Kd54EY8SJj83DznsPKCzbB9eIgoGSVbmUSoP8coifSdyZctWUVcYXkX rkyNuJ4LbZnxYFVEW+wpQtUV3c/COxEdwEZ4UaEFVaZgMjgldLdfz2iUwRAksXnP9a8G pY5AarzP09ULrknNHSuctNWTBs7KTUlIK/4EhyM2qTHafB1ntCvAnIlThbCQ/P7DWik7 Ip7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=twf156mL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a26si10067825eje.383.2019.11.27.12.45.25; Wed, 27 Nov 2019 12:45:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=twf156mL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728918AbfK0Umn (ORCPT + 99 others); Wed, 27 Nov 2019 15:42:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:49320 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728909AbfK0Umm (ORCPT ); Wed, 27 Nov 2019 15:42:42 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4895921781; Wed, 27 Nov 2019 20:42:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574887361; bh=QI1gw+r06sE5VELa9ZX/A+y3EYDXLyXaTUSzj6BhIYo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=twf156mL1cZR8pKqWED/xPRhuuw/mIR23DO6xr4OD4vtKPyrXJufzgdKXTOSsbLsE z7yTmYa1LWL8rMtNLn9PbYcZAAlv5QoFhO2jhiHjvR/fOprXx/o+OPGNarinjXQn8/ 7KVij7Qz5hgjl5Zi/7vjTzlqbH4Zu70T03hIzUVU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Gerd W. Haeussler" , Jon Mason , Dave Jiang , Sasha Levin Subject: [PATCH 4.9 082/151] ntb_netdev: fix sleep time mismatch Date: Wed, 27 Nov 2019 21:31:05 +0100 Message-Id: <20191127203036.065261269@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203000.773542911@linuxfoundation.org> References: <20191127203000.773542911@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jon Mason [ Upstream commit a861594b1b7ffd630f335b351c4e9f938feadb8e ] The tx_time should be in usecs (according to the comment above the variable), but the setting of the timer during the rearming is done in msecs. Change it to match the expected units. Fixes: e74bfeedad08 ("NTB: Add flow control to the ntb_netdev") Suggested-by: Gerd W. Haeussler Signed-off-by: Jon Mason Acked-by: Dave Jiang Signed-off-by: Sasha Levin --- drivers/net/ntb_netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ntb_netdev.c b/drivers/net/ntb_netdev.c index a9acf71568555..03009f1becddc 100644 --- a/drivers/net/ntb_netdev.c +++ b/drivers/net/ntb_netdev.c @@ -236,7 +236,7 @@ static void ntb_netdev_tx_timer(unsigned long data) struct ntb_netdev *dev = netdev_priv(ndev); if (ntb_transport_tx_free_entry(dev->qp) < tx_stop) { - mod_timer(&dev->tx_timer, jiffies + msecs_to_jiffies(tx_time)); + mod_timer(&dev->tx_timer, jiffies + usecs_to_jiffies(tx_time)); } else { /* Make sure anybody stopping the queue after this sees the new * value of ntb_transport_tx_free_entry() -- 2.20.1