Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp5978862ybc; Wed, 27 Nov 2019 12:47:30 -0800 (PST) X-Google-Smtp-Source: APXvYqwm0PcyQbMlhaxaoe952eGcUYSRGGYEIc5m8v0lbZAqYcfSTpMLLueVRXN9kK+gzj8MU6ax X-Received: by 2002:a17:906:5e4d:: with SMTP id b13mr8597176eju.266.1574887650154; Wed, 27 Nov 2019 12:47:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574887650; cv=none; d=google.com; s=arc-20160816; b=bjPicwpKo4xVJ+xtYH0oRtEVIRa+710LO0MWyvxuCGqaUQTHetgT8R3ybBYidkYV7Y /LjB0NRfhftyaZPc92eUTavnAoyDaJKrABc9fqtRGaoFr5RUsEYFBwGTSd+V47BcvtaH FkOZgErU8HiLk9bHvoJtKNub4/pfnFMQd3Qh61s+ntETXy3Ez/atn5MZS+nAe0aLN5fa VU2wyeXe7zFTeaAPI3BlbLh1dcD7otCEW4Zq4p7nntN5pAGOsyKMhpOOzg9A1tIlDput sx6aTtAiRz26HW5oLIdXnZ0AFjNSO3PCW6GbAHy/hrOZKcy3B2o8ipXfMW+lAmuaXiDl hSxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=zrIGLF/E4CiY7YhMOfJe+K72yow+/WXPAK/wwkRwT1w=; b=Sqk5IHgG77JC/dBHTYEHr5ij5IyaDHYMzVVM8lcaSVe1OM92QbvDce1I0Olm0F+Dxk kxTx6iLYO0n1Xmb4T3Y/ZSaez/kjdad8E1rb/wGnF6PxKUbGorpeaeDpa8o6k6tgUxoS mae8taddEhxeFURJdZbMtaDkik7d7jLEe8R/TMBSfpKxbokRxwuFAyG4e6Pm4BiX047l 3zg93QSdmQf0V8QZGBU4EP0Abd8znbyrVEq6lGSI3Mr33fR746ff8lUgp73WxOjuLL18 Eax6TFonnmXY2y8r2MaDkvp2+P1V7962HTB1zSYdorFdq18lP6L431RLAlIPPxsn+5GV jNlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JidVmYXW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s24si11046712edx.223.2019.11.27.12.47.06; Wed, 27 Nov 2019 12:47:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JidVmYXW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729023AbfK0Uoq (ORCPT + 99 others); Wed, 27 Nov 2019 15:44:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:54546 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729639AbfK0Uoo (ORCPT ); Wed, 27 Nov 2019 15:44:44 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0712C2158A; Wed, 27 Nov 2019 20:44:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574887484; bh=IZD60WKOoIIwQZ0XlG9VB+VgoMwu1UzQuNA7TjHizyw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JidVmYXWpmebyPjgY1bOUPMsBWY1+On84oGceVIS0JTC+sHAdygNn/t4jajhxmF7K 7ZKLJEuTHdNwrKR7EiRh3z8yJ17S+8uVvib7SHp4mReTo48LCTzlswwfNVTiP62yH2 E7QS0iSVw9zmSOi2MoD0tIjro6MWDAoGhzFYt1Xc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+d93dff37e6a89431c158@syzkaller.appspotmail.com, Oliver Neukum , Sean Young , Mauro Carvalho Chehab Subject: [PATCH 4.9 129/151] media: b2c2-flexcop-usb: add sanity checking Date: Wed, 27 Nov 2019 21:31:52 +0100 Message-Id: <20191127203046.084865383@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203000.773542911@linuxfoundation.org> References: <20191127203000.773542911@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oliver Neukum commit 1b976fc6d684e3282914cdbe7a8d68fdce19095c upstream. The driver needs an isochronous endpoint to be present. It will oops in its absence. Add checking for it. Reported-by: syzbot+d93dff37e6a89431c158@syzkaller.appspotmail.com Signed-off-by: Oliver Neukum Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/b2c2/flexcop-usb.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/media/usb/b2c2/flexcop-usb.c +++ b/drivers/media/usb/b2c2/flexcop-usb.c @@ -538,6 +538,9 @@ static int flexcop_usb_probe(struct usb_ struct flexcop_device *fc = NULL; int ret; + if (intf->cur_altsetting->desc.bNumEndpoints < 1) + return -ENODEV; + if ((fc = flexcop_device_kmalloc(sizeof(struct flexcop_usb))) == NULL) { err("out of memory\n"); return -ENOMEM;