Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp5980488ybc; Wed, 27 Nov 2019 12:49:40 -0800 (PST) X-Google-Smtp-Source: APXvYqytdNyanVBTTBbgqbSXQDMTTzhuBgnk1Et660/WMoyuF7nA2JZl6g7JC3qp87TejBUm6Na/ X-Received: by 2002:a50:f987:: with SMTP id q7mr34199368edn.205.1574887780153; Wed, 27 Nov 2019 12:49:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574887780; cv=none; d=google.com; s=arc-20160816; b=h5IoZl+5g3IfSt6cthXxlsp1fEwzThnUpDzcDtE0YW1sxbvtpflWsA8p61dSP2zYIg 9Wj/66ZcOZ5J9JVmdAV07d3LcD0MvalNLlHPBemWN1KCRMnHxREYR496E3vugmHGOVKy qri85cBHfvMjjY7hBcbbR6/qoprXhl19lU/hjOUPd2b/Q/FsCRRH57kzuYcURxwP0Gun PyUk3RGomWMwXBXsf/kScmtsalr4sBQ7nvPOl0BBUr0b9O+DH6grkOIu8Chx+kch9OMw REiCzHG43CbAHqveTfJA8v3ixfXjYafBh/qxegJa8GKEzrHH8j6/IN0sP7deMKBJ24Am Zscg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/xkbznjiZQf597aGpruvQE22heK05iiX4J1dLfPryQw=; b=i9Wd6IwW8iEALLyTI4PBXiYAmc0yvH7vcrffnLZ/0d5sVWOjCBLVtjsJeRoseGWXI8 UqVxpj5Sy95K7C2ecR1bpc/YnholLklPnRtWRKCXHfmK2y+RQaXeIqdUfYELehmR/+Qo J9i7Nm3eFFHUi7uh/53D2AxFokJbPDQitZ08F59S7nEZvDVLzTZUh0e5BU5rFFjx9sH3 /TGllGIZ/LA3F59OOr5CPj9YEbWHtYo2rl0E1teXyC4g4lERi6+Uh5WOGpYqa7jxacUQ Kh/RA/ojHLtX8Q0SIUOja44/zlZGv5RF1MiGLunTj7O9kjlliBEoPHjjj/kPUC/Sx0cS 5D2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=up6oTUEK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l23si12788439edc.279.2019.11.27.12.49.16; Wed, 27 Nov 2019 12:49:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=up6oTUEK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728308AbfK0UrD (ORCPT + 99 others); Wed, 27 Nov 2019 15:47:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:59478 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729952AbfK0UrA (ORCPT ); Wed, 27 Nov 2019 15:47:00 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 53989217D6; Wed, 27 Nov 2019 20:46:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574887619; bh=E2ZUTU5HCdCqmIb+dDMKUbL0XKlBuy6jI6sjlPvGW1I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=up6oTUEK4fgVmVqOBJTvsGgXH7PyS8L+RErqAKut5P71bablFH8eyBvVGwCLkEfBG YK1/TQKD2MpzYmLHOof27YGvREg6EyLyt6sPC0YN7kSNGUBUiX6a5T/tdLC4hCa91p LJgH6Q+1VGQ4qYMwEu5Osg1T/tzmV7H00MEloyk8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jens Axboe , Sasha Levin Subject: [PATCH 4.14 029/211] skd: fixup usage of legacy IO API Date: Wed, 27 Nov 2019 21:29:22 +0100 Message-Id: <20191127203054.105908708@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203049.431810767@linuxfoundation.org> References: <20191127203049.431810767@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jens Axboe [ Upstream commit 6d1f9dfde7343c4ebfb8f84dcb333af571bb3b22 ] We need to be using the mq variant of request requeue here. Fixes: ca33dd92968b ("skd: Convert to blk-mq") Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/block/skd_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c index 64d0fc17c1742..95649025cde77 100644 --- a/drivers/block/skd_main.c +++ b/drivers/block/skd_main.c @@ -1417,7 +1417,7 @@ static void skd_resolve_req_exception(struct skd_device *skdev, case SKD_CHECK_STATUS_BUSY_IMMINENT: skd_log_skreq(skdev, skreq, "retry(busy)"); - blk_requeue_request(skdev->queue, req); + blk_mq_requeue_request(req, true); dev_info(&skdev->pdev->dev, "drive BUSY imminent\n"); skdev->state = SKD_DRVR_STATE_BUSY_IMMINENT; skdev->timer_countdown = SKD_TIMER_MINUTES(20); @@ -1427,7 +1427,7 @@ static void skd_resolve_req_exception(struct skd_device *skdev, case SKD_CHECK_STATUS_REQUEUE_REQUEST: if ((unsigned long) ++req->special < SKD_MAX_RETRIES) { skd_log_skreq(skdev, skreq, "retry"); - blk_requeue_request(skdev->queue, req); + blk_mq_requeue_request(req, true); break; } /* fall through */ -- 2.20.1