Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp5981282ybc; Wed, 27 Nov 2019 12:50:39 -0800 (PST) X-Google-Smtp-Source: APXvYqyGU5Y978u2OX6JtBILkiSNOncIZi4jaoQncgJu/VF6e2iP/2/lP/ZiINcFGFM16ebE9cxB X-Received: by 2002:a50:da43:: with SMTP id a3mr33999489edk.229.1574887839840; Wed, 27 Nov 2019 12:50:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574887839; cv=none; d=google.com; s=arc-20160816; b=i8+vZYo72C1eEFcA8RE6VY9gJCEduuHGdOiRQFWqToJWPog9Q0iI295jIopcJKIL3l phUFae+KDx4JwqBVRvSQ256jt5XAZenq4x5qCQCJG+WCjCs4lmAK7s0A+IUkcmBO5Dtz Ka7sKisrbDJZgfRXL5kqc6GSL40D15vajwjJ0lTTTEy/q9Jml/EjNMTbQy6q7zMq36H+ WpnZr7ZcMdHXwyO2U5zU+0Agkw5Zv7vFKaM6pO+cLasBk1Rm1qodhPQkWyEEI7xAfptQ sA5n8d7/VokOh6jSg+nSTQrmVDqhn8ycdbU940F4WFccT1zQrSbR/1MbXOoDfdAdOaSo HLBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/vOm5qUYusNCfWR9O3+gMv2+gbPYmQk9GqRqczVeI1E=; b=zKtidZnyHh3h6kp07cyloX65UNXwX0vLCQhVA9AdkM6oWMBAmQ59u1vsdLTS0D9Vaz tOBEr0W8zuXlbrsKJyxRiSyZS5odI73Z97hbAoRvhB+Dat4htbreYhpWtbskePvUmgT/ P3ylkvzzbHOgjJpXa8EJXtBv1gghtER8g5OUfVTXzC7D7+UTwl33lT8oo/+rxGq/32Kp v+t/ioDbQ/PO6fXYupVKD+fRnl5Pyzbhpg03CdU2+nFVANqylLsk/4FKy1NkNL+W5ThF gSud6YujZj7X12LXXymletMljBaAI8joBKCG2LIVVhCfw8GMgfw3WXddrPDeYW2/bhk0 PQTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=foW6wZxl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c13si786467edt.98.2019.11.27.12.50.16; Wed, 27 Nov 2019 12:50:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=foW6wZxl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729605AbfK0UsM (ORCPT + 99 others); Wed, 27 Nov 2019 15:48:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:33222 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730088AbfK0UsJ (ORCPT ); Wed, 27 Nov 2019 15:48:09 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 37BA421845; Wed, 27 Nov 2019 20:48:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574887688; bh=wm40pxxZ59JGzonob8Ges0kmf+882DncGH3d04jzJGs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=foW6wZxlCBQcKpIJy1Zeb2EnhBZ3dcRfi5rv/4FaUR/XC83xlWJhe8BSX1UZg73++ vOur9qImODc+sNeg/MxJCa7SkdnpVRM6wOZhtwsOemzuFxPuDKtFJB/6uaYLZXCKHr HHA8owrhgK9dgV1ro9GuMLhyI6VNw0Vq4qtRkMw0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kyeongdon Kim , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 057/211] net: fix warning in af_unix Date: Wed, 27 Nov 2019 21:29:50 +0100 Message-Id: <20191127203059.494818272@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203049.431810767@linuxfoundation.org> References: <20191127203049.431810767@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kyeongdon Kim [ Upstream commit 33c4368ee2589c165aebd8d388cbd91e9adb9688 ] This fixes the "'hash' may be used uninitialized in this function" net/unix/af_unix.c:1041:20: warning: 'hash' may be used uninitialized in this function [-Wmaybe-uninitialized] addr->hash = hash ^ sk->sk_type; Signed-off-by: Kyeongdon Kim Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/unix/af_unix.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index 4de9dfd14d09d..99f581a61cfac 100644 --- a/net/unix/af_unix.c +++ b/net/unix/af_unix.c @@ -225,6 +225,8 @@ static inline void unix_release_addr(struct unix_address *addr) static int unix_mkname(struct sockaddr_un *sunaddr, int len, unsigned int *hashp) { + *hashp = 0; + if (len <= sizeof(short) || len > sizeof(*sunaddr)) return -EINVAL; if (!sunaddr || sunaddr->sun_family != AF_UNIX) -- 2.20.1