Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp5983429ybc; Wed, 27 Nov 2019 12:53:22 -0800 (PST) X-Google-Smtp-Source: APXvYqw5cn5FlKV8sHUYo/jyRhSdDPQOog15q4uDbw8CJfgP6sD2WNM3A/SkoepRP3ai/jLAUbN8 X-Received: by 2002:a17:906:82ca:: with SMTP id a10mr3322454ejy.40.1574888002330; Wed, 27 Nov 2019 12:53:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574888002; cv=none; d=google.com; s=arc-20160816; b=yY8FzsTVjDVoPQn6pxBlurKDcL6DacWNeJK+fwnuzDq9nD/0ZH+/CRxgqZWTU/gi/r VhcIvtKuvfL5ezPM5pJZ81cd+KOsf5nu1MS/y5BLGByMRSGcASFa8nJkIAZAk9yrHBvN 6YjVNgsBbgB07pn+46L9rxgguxJRIXxbr8ffV/qWgO+Wc9A75fiLbjXZydJiv+/773gp TYusO7rYcQyrKF5OMZE5s0RBX5nvXFyi97vEkZk4J1bBtWamFVuWZfZk0dnqjAM3JRhD tzBMaDTRXPLjPd6RMwzPIw/BQXesYsKUssy9lVp2MFgTJ8ttAHxiDKTautXia0jRvEeE be+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6+Vr4Jet7/vdSViA9+VmPbOjulE6T3rFfYlkO8sktFw=; b=GPvjSMUITkwCOSW6puUHm5Gvw+RhI7YwYIEXkgd1oPlN9TyeZ1HogyDSScbKE1VWCA 1WSDwleEr8RO3oi+7lWM9u4F6sp/L5P3eiQdGrZYQxG+/j7eN3T4/mQ56pEuHNJKFU70 9fzts7jNJWh6rfdVVwtFRFmuqspzXx245VqGjaCK3Xw6CDZsbT9f+XtAXmP+vAMvNnW3 wyId3fxQlI3LCLkDIT8ezcuM/Mgod4bnHdUH6QS0Ff2viMjET2v5mBM5i9RCme2pWaGj tnRwLGgE3U4Nyq+3BUHo0NcQ0xE16ENjtp2kuQ9eGg+5kalHLLsX0gj3hSKkL+MxbswZ o7hw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xysraq16; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b5si11389392edy.149.2019.11.27.12.52.58; Wed, 27 Nov 2019 12:53:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xysraq16; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727008AbfK0UvT (ORCPT + 99 others); Wed, 27 Nov 2019 15:51:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:37810 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730454AbfK0UvP (ORCPT ); Wed, 27 Nov 2019 15:51:15 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A1A5721847; Wed, 27 Nov 2019 20:51:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574887875; bh=IM1t6g1nMjKWhDLnyHsa0pI2DuK8mSYSBKumetio6Ws=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xysraq16mvTf55O7A9cdEOBNuRp7rSNUpIA3c4bqTpysgCtA8a/vzYqQ/LwCfQEeF M4Aqw1m0AuVhCNV73TFBIryDQVgsKvyMkdqnou3TvckrP6KmbaBvR4jX7ZK+jfQ6F2 p4PGhQyuVUvQlVoQaRmM3YN6g4vGluulFDk6x2Jo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Peter Zijlstra (Intel)" , Linus Torvalds , Thomas Gleixner , Ingo Molnar , Sasha Levin Subject: [PATCH 4.14 127/211] sched/topology: Fix off by one bug Date: Wed, 27 Nov 2019 21:31:00 +0100 Message-Id: <20191127203106.103789668@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203049.431810767@linuxfoundation.org> References: <20191127203049.431810767@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Zijlstra [ Upstream commit 993f0b0510dad98b4e6e39506834dab0d13fd539 ] With the addition of the NUMA identity level, we increased @level by one and will run off the end of the array in the distance sort loop. Fixed: 051f3ca02e46 ("sched/topology: Introduce NUMA identity node sched domain") Signed-off-by: Peter Zijlstra (Intel) Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: linux-kernel@vger.kernel.org Signed-off-by: Ingo Molnar Signed-off-by: Sasha Levin --- kernel/sched/topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 9dcd80ed9d4c1..867d173dab482 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -1347,7 +1347,7 @@ void sched_init_numa(void) int level = 0; int i, j, k; - sched_domains_numa_distance = kzalloc(sizeof(int) * nr_node_ids, GFP_KERNEL); + sched_domains_numa_distance = kzalloc(sizeof(int) * (nr_node_ids + 1), GFP_KERNEL); if (!sched_domains_numa_distance) return; -- 2.20.1