Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6003454ybc; Wed, 27 Nov 2019 13:13:42 -0800 (PST) X-Google-Smtp-Source: APXvYqyGEQsE0LtrAxLgKUd9uteuWzrO4RrmS9sARA/agntPIEK3AYXtPjoXgsyAqn6yI0TsSLb7 X-Received: by 2002:a50:99cc:: with SMTP id n12mr3201451edb.66.1574889221910; Wed, 27 Nov 2019 13:13:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574889221; cv=none; d=google.com; s=arc-20160816; b=hBXBJZXeq1NjQFfVbvFZusD42xLgE+4GPagRhlkY2B80S0KG7wb40L3UUlzGqd3xjS 7wmfHOt7FTR/VatnkjBegZUeGw3L1HfrwWA4UC30mGJ7Ub3KUlpo55K0fcQQy54hSFqi PsuTJMCN/yA2uzakzIZ9z6JPhb9waZ5TPyzUtSeCBGJlgMRT5vG6QpgMu4Ya/3zNg1xX dvISIYGJswtx5XoLoP1VxWPSsJUevOcYEq0TMxZmXk76thFqSxGGxervbDr1BRo354Mb ywGT7XHPRF77z4t4x3mSw9JwQIsVmX8efJhRDVMyjvmDIF/B7gL7Ay7p1gKAH66DXagP OgSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Oq+tvfeWRjDDVOR+3j14Oxfc2deRPz4JuVknEpqy3+w=; b=pSAnqxW+I2R71iSg/7ylmWNif14dE0GhWRdCYUa95W9p90IK+Rf/EqBzqRA7hs7lEL aCLdI08izvO4B8vXcF6C7BhAKkw1keBSeULHk11KjWvlHkdTmARRJ/e8xunbKI2tEmDk prs882Yaxiz5oNI5Hie6++/6qkT/L1PYGnkp4krRfljNgxfVFgTgzc24bg1UB63k/Nho GkZL9o+03KYf2kMd4DHzsooKs65YlwIwE3YKw6oZroZcNlEVjBdWVwe0kgPPAE231KMp Tp70itBbosTpWBiD6FK4j7aLD7OmcaWHsQZ/K9AcDDAKeq8DK+PwojrAQlW4/OiVeWfw HCjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ulmy4lwy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u2si10079068ejo.137.2019.11.27.13.13.17; Wed, 27 Nov 2019 13:13:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ulmy4lwy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732210AbfK0VJO (ORCPT + 99 others); Wed, 27 Nov 2019 16:09:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:35814 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732198AbfK0VJN (ORCPT ); Wed, 27 Nov 2019 16:09:13 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0ED792086A; Wed, 27 Nov 2019 21:09:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574888952; bh=FqJdKg0k9uBG6oJRzwGizfjzoPk3wcAiHCDz427tDiU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ulmy4lwyB/PRhW4bUVnve87cZvcx9nQOsrXyhKcVlmI/eAylZjR39MxypPuiR0Ry1 ZPsK5kgIpdbpCmek1j3RzcEVCq/QHRhkKTz0R/mG1UFh2bWKjgZa1VzRKKgn75t1Qv BmQNiYDANYzYNmWlaym9uLJFGN0AzbVR5yGJIxIo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wei Wang , "Michael S. Tsirkin" , David Hildenbrand Subject: [PATCH 5.3 26/95] virtio_balloon: fix shrinker count Date: Wed, 27 Nov 2019 21:31:43 +0100 Message-Id: <20191127202853.159506349@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127202845.651587549@linuxfoundation.org> References: <20191127202845.651587549@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wei Wang commit c9a6820fc0da2603be3054ee7590eb9f350508a7 upstream. Instead of multiplying by page order, virtio balloon divided by page order. The result is that it can return 0 if there are a bit less than MAX_ORDER - 1 pages in use, and then shrinker scan won't be called. Cc: stable@vger.kernel.org Fixes: 71994620bb25 ("virtio_balloon: replace oom notifier with shrinker") Signed-off-by: Wei Wang Signed-off-by: Michael S. Tsirkin Reviewed-by: David Hildenbrand Signed-off-by: Greg Kroah-Hartman --- drivers/virtio/virtio_balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -820,7 +820,7 @@ static unsigned long virtio_balloon_shri unsigned long count; count = vb->num_pages / VIRTIO_BALLOON_PAGES_PER_PAGE; - count += vb->num_free_page_blocks >> VIRTIO_BALLOON_FREE_PAGE_ORDER; + count += vb->num_free_page_blocks << VIRTIO_BALLOON_FREE_PAGE_ORDER; return count; }