Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6003988ybc; Wed, 27 Nov 2019 13:14:14 -0800 (PST) X-Google-Smtp-Source: APXvYqxZLxFqvvdYA4bBWQYxbQyrtzpLDuIX3wHNcr4N99ADeOcc1Q5ESrItx+foE+T0H1VO2sQB X-Received: by 2002:aa7:d342:: with SMTP id m2mr34360589edr.215.1574889254524; Wed, 27 Nov 2019 13:14:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574889254; cv=none; d=google.com; s=arc-20160816; b=RBoOAJ5X5kUeG70YEmmR8rhU+zzwAoZWAQ+cgxC5yGWX3gHR1LwRiJdmae+r2svx+t nNRDYsr+9bmfcmkxkfk0s4PBt/WApPkXrE8EqGLWC46he/wcwvxwrmS0upl89mo4ucCV jOxyb2wgaHFSx55NyXEeqLtRh5zR1McvUTdg5bKf3oorc0NokPCMx+kO6I8mnTLkvOU+ cwTzaYrMCqniyxBREwaulT8GZLbPhEDsgyl2+ZE828qytwfjHdEWJyFKzjs6JpSGNFIu MRW8ndpTZ+rTrFvSCGovBPVmn8JW6JX2kPc3Hltjy8ddl0Z2V6IkAxAG7roHO93TZaL1 4oWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+fRTC88wyWGRUS8TdB37+yb6EAfnP1z85ZRdK/w35gY=; b=pfU8h5HG2/i+M4iA90kRnJtPOALt3XKcdElhZP0QJXvd1vnquETlGhxx8SlslTbXsI ytOg3bHk+G1ZjBNkXoSPEBDXejdFbAcbB9wf5T6UL3xHE0DjIz9O696A8t8t1nVJh4UK JeWPcoDqh82sYs/JiQmnU4XJ9twPYqfoA6a70ROQubOf9n5n0lj2d5M0M27/tbhk5/JP nuxOnrymWhbKGEpNrrKpDiC4dmoO6/ZZA3sUXlFLtMU3qdcXclZh6DsOMcPr2Fk4FJW7 J7e09GwfJAe30mN0lpCeWLGWinLBvUduUvrK4R5uDiiqymzv13hVDWTNj/p42SK5tVcX mQhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=giOzjXzt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j20si1112214edj.385.2019.11.27.13.13.50; Wed, 27 Nov 2019 13:14:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=giOzjXzt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732170AbfK0VLo (ORCPT + 99 others); Wed, 27 Nov 2019 16:11:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:40654 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733208AbfK0VLm (ORCPT ); Wed, 27 Nov 2019 16:11:42 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9DC4D21555; Wed, 27 Nov 2019 21:11:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574889102; bh=in531OI/aSvSHnK/VUVcGLFwWJ/vlmpNhxmEMvrlhx0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=giOzjXztk7ATahFiFb23C0CIN8RXNy1TCQ/U3G28rtY5XxgEqBPG+cOshZRC0zM3J nZm2w795ooyXD42j1/4FDmYAmkPTaU2wfqlaTvrEIK+s7U2/KBI8kIfpSObj2TUABk smQMvvQ9mzHM8Tc7l68X+me5nW0vdfn5NX7YRiHI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hewenliang Subject: [PATCH 5.3 82/95] usbip: tools: fix fd leakage in the function of read_attr_usbip_status Date: Wed, 27 Nov 2019 21:32:39 +0100 Message-Id: <20191127202950.051880520@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127202845.651587549@linuxfoundation.org> References: <20191127202845.651587549@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hewenliang commit 26a4d4c00f85cb844dd11dd35e848b079c2f5e8f upstream. We should close the fd before the return of read_attr_usbip_status. Fixes: 3391ba0e2792 ("usbip: tools: Extract generic code to be shared with vudc backend") Signed-off-by: Hewenliang Cc: stable Link: https://lore.kernel.org/r/20191025043515.20053-1-hewenliang4@huawei.com Signed-off-by: Greg Kroah-Hartman --- tools/usb/usbip/libsrc/usbip_host_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/tools/usb/usbip/libsrc/usbip_host_common.c +++ b/tools/usb/usbip/libsrc/usbip_host_common.c @@ -57,7 +57,7 @@ static int32_t read_attr_usbip_status(st } value = atoi(status); - + close(fd); return value; }