Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6004321ybc; Wed, 27 Nov 2019 13:14:33 -0800 (PST) X-Google-Smtp-Source: APXvYqzqHeOtQ0YHoECUp4FvObvGsYWnhDvspZEmnJCzCN4a2O5fWYp7XABdT73Gg/XrQwBPcQi3 X-Received: by 2002:a17:906:bc9:: with SMTP id y9mr51031681ejg.64.1574889273516; Wed, 27 Nov 2019 13:14:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574889273; cv=none; d=google.com; s=arc-20160816; b=xcCarPBwSgxkywJWyaGqJwA3LW3MDesj36FNAPGpvQgBgH8LJZzBcQQtyba3yVn5NA apwpT3EJLKA9Ex51cYpmxotRdTs+AQmwAyLRaWT4yiTCWG0lQICzPYpXzGe1q1NR/Vnu VfRzUjYBpFLL+EqWIUSEUYol2xTPbOHb/abMhsnNAjmQ0U+t+bIdL3MnyIp4qWlcXOPd AoMxbNDApZbugU8Gh+URFcG4QD5LzLK8C/+4vmrtocjIrrzHbAswza2shrA8fg2OrJYC VBlq1f8QSjN0tliWsLA3daJ5Spr091MqRvsyMzo+B9aiUIo9WdOueDbHdsuOb+59zQFI riWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/zX9UDxnZ/962EGWzVg0UsMxjxLadIT9xDliWUo7Tgg=; b=hIgitm/out0Qxkq4Vykpjj3RzwnC8AmMI7GfWsCRHCZsxZaf9zWvOZv1olEvOoFyVO mMIPQbvcH90ovPR7jkrjnYEbRWgAfM5g3IoaTSsbMGOuHZ2d3dS2CZ9A91CASzM/WfEe rJVMnPQXLARZJC/+DyuzsnAWC/pPxxXq5se/FOvm7oI1iZoAPqc2wGvaUBQoT2XS5Gpk zS2tqocftGOcFl3upRx60QDooW3KttC5LbR5tgu8buG8/cy0m/N9Dwfn0oHCXvBYpvYQ HI3U5AtgWfjA+mlR8hdLVu2VGw6qBSIXMCnHZx1/bqt7wuEtBaw9iyv8VTG3iK1DzIvF 9iFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cThZn7Nm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p17si10621763ejm.4.2019.11.27.13.14.09; Wed, 27 Nov 2019 13:14:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cThZn7Nm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732954AbfK0VJ6 (ORCPT + 99 others); Wed, 27 Nov 2019 16:09:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:36754 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732561AbfK0VJz (ORCPT ); Wed, 27 Nov 2019 16:09:55 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7BA17216F4; Wed, 27 Nov 2019 21:09:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574888994; bh=57A37uReFpaoVHM91/3bIBAXphIRLjuVkZlIK30VGwc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cThZn7NmW4EfARCzFit9hn68ysHhIVtVsq8bozAU4ak0+Rg69SBzJOrHI+zJT9G8q cKu3ilmdkdiiLQOH5pZJmM8nBn8A9kqCOWU73ZV1LjFBY2lSiGUxcagBi4axN6MV8d Los0wobamBn5xS6hMD7hHCDQdPveEd49ABzQykjA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Rajkumar Manoharan , "John W. Linville" , Kalle Valo , "David S. Miller" , Denis Efremov Subject: [PATCH 5.3 40/95] ath9k_hw: fix uninitialized variable data Date: Wed, 27 Nov 2019 21:31:57 +0100 Message-Id: <20191127202906.069482258@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127202845.651587549@linuxfoundation.org> References: <20191127202845.651587549@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Denis Efremov commit 80e84f36412e0c5172447b6947068dca0d04ee82 upstream. Currently, data variable in ar9003_hw_thermo_cal_apply() could be uninitialized if ar9300_otp_read_word() will fail to read the value. Initialize data variable with 0 to prevent an undefined behavior. This will be enough to handle error case when ar9300_otp_read_word() fails. Fixes: 80fe43f2bbd5 ("ath9k_hw: Read and configure thermocal for AR9462") Cc: Rajkumar Manoharan Cc: John W. Linville Cc: Kalle Valo Cc: "David S. Miller" Cc: stable@vger.kernel.org Signed-off-by: Denis Efremov Signed-off-by: Kalle Valo Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c +++ b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c @@ -4183,7 +4183,7 @@ static void ar9003_hw_thermometer_apply( static void ar9003_hw_thermo_cal_apply(struct ath_hw *ah) { - u32 data, ko, kg; + u32 data = 0, ko, kg; if (!AR_SREV_9462_20_OR_LATER(ah)) return;