Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6010111ybc; Wed, 27 Nov 2019 13:20:31 -0800 (PST) X-Google-Smtp-Source: APXvYqwniH4BsvlJDB5R2Zex325zGVyZpEzH1vDSSE2aqdTeygI5sgsBkZASCW58yZHm/dhI2UAf X-Received: by 2002:a17:906:32d0:: with SMTP id k16mr27343971ejk.155.1574889631708; Wed, 27 Nov 2019 13:20:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574889631; cv=none; d=google.com; s=arc-20160816; b=gO1hJGbtywM5KP51RbITT2pxt4mPPM01yfhl1q5XNHo2dLxlBSqJPZr9dCETH7zaPP HRsGIKiJDxC0DQ94atCCoVcK+vAHrtXz6p5/n7+Y1Vd0Guix2sp98n1kibItUuS9U1jb FI39EO1wPAF79iNvc+hR+q+to+wqUAAECHPO8Ou4AbSCzvtuLraRCFvZL9/VRJPwjyWy qZTWGWjJbytcwP+IBREVKkXpDeF0eWhTiPgyJI7jkwWQicL/HrxMGwXt+JqYDsqjaWrX noXLHYkxDRC5gvYaE0xVhuDzubsG6CvAZfLZXSE/EkwAzuBRfKCZarIrrRaVz4AqUrs0 ARQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=sv+gOvTfHB8qO2cbih5VPm9VWCovd1l5X7RQd6B3LDg=; b=xzeiFC6S4VTHKo5nZkenH1Am9DjUxJZTiGw8FMQsewLQzKoCzyN2KUGNzIAfzKGVhH whl5b0inhxpW2caqLi45BQMB7zDWZjKuaVSBHk+UhvfYXk8I55hJe1uYzl8q2VZurR1w bGwR7ZZFnXc2HjTSS7UBHO0x71MNtyR0HzBgla0Dh25O3632XEm6PUhk/HrwKcY4yznt LtJ4rF9tvKL+NT0qvmpvwJv/blKadpn2JXE1AQ/6fpBRqGG/EjgKrwMFN9Qu8Slyrvc2 ASYDRcxi32hZJFo/VR9O0f/IK8/5b9kUcdSkmLv71pMnudWWZ3LRwRp5iCJqa4vKnWKg JgOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=U7ygRyqS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m10si10440751ejo.243.2019.11.27.13.20.08; Wed, 27 Nov 2019 13:20:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=U7ygRyqS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732329AbfK0VRt (ORCPT + 99 others); Wed, 27 Nov 2019 16:17:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:42942 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732615AbfK0VMY (ORCPT ); Wed, 27 Nov 2019 16:12:24 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D7BEF21850; Wed, 27 Nov 2019 21:12:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574889143; bh=KamOJ0k99dLB3F5Z9KJH8d9epqyB7CNyLPOeg5wb4vQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U7ygRyqSIFA/ejKRU37VzNNwNcoM+U1fyuo93f2kqr1k2DRPvaeRxFx5VxivJ2yKr lzaUYFtbvOMOPe/TlojhwBApAQk+MwGcPndEGaQ5CTxL/u7YrpbKvv+c5PGrJGXKyM gqU3+vWIgjWJR2qXIeO+/M0rMUrREDJHC6Fn3u10= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Michael Ellerman , "Christopher M. Riedl" , Andrew Donnellan , Daniel Axtens Subject: [PATCH 5.3 93/95] powerpc/64s: support nospectre_v2 cmdline option Date: Wed, 27 Nov 2019 21:32:50 +0100 Message-Id: <20191127203001.996994315@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127202845.651587549@linuxfoundation.org> References: <20191127202845.651587549@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Christopher M. Riedl" commit d8f0e0b073e1ec52a05f0c2a56318b47387d2f10 upstream. Add support for disabling the kernel implemented spectre v2 mitigation (count cache flush on context switch) via the nospectre_v2 and mitigations=off cmdline options. Suggested-by: Michael Ellerman Signed-off-by: Christopher M. Riedl Reviewed-by: Andrew Donnellan Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20190524024647.381-1-cmr@informatik.wtf Signed-off-by: Daniel Axtens Signed-off-by: Greg Kroah-Hartman --- arch/powerpc/kernel/security.c | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) --- a/arch/powerpc/kernel/security.c +++ b/arch/powerpc/kernel/security.c @@ -28,7 +28,7 @@ static enum count_cache_flush_type count bool barrier_nospec_enabled; static bool no_nospec; static bool btb_flush_enabled; -#ifdef CONFIG_PPC_FSL_BOOK3E +#if defined(CONFIG_PPC_FSL_BOOK3E) || defined(CONFIG_PPC_BOOK3S_64) static bool no_spectrev2; #endif @@ -114,7 +114,7 @@ static __init int security_feature_debug device_initcall(security_feature_debugfs_init); #endif /* CONFIG_DEBUG_FS */ -#ifdef CONFIG_PPC_FSL_BOOK3E +#if defined(CONFIG_PPC_FSL_BOOK3E) || defined(CONFIG_PPC_BOOK3S_64) static int __init handle_nospectre_v2(char *p) { no_spectrev2 = true; @@ -122,6 +122,9 @@ static int __init handle_nospectre_v2(ch return 0; } early_param("nospectre_v2", handle_nospectre_v2); +#endif /* CONFIG_PPC_FSL_BOOK3E || CONFIG_PPC_BOOK3S_64 */ + +#ifdef CONFIG_PPC_FSL_BOOK3E void setup_spectre_v2(void) { if (no_spectrev2 || cpu_mitigations_off()) @@ -399,7 +402,17 @@ static void toggle_count_cache_flush(boo void setup_count_cache_flush(void) { - toggle_count_cache_flush(true); + bool enable = true; + + if (no_spectrev2 || cpu_mitigations_off()) { + if (security_ftr_enabled(SEC_FTR_BCCTRL_SERIALISED) || + security_ftr_enabled(SEC_FTR_COUNT_CACHE_DISABLED)) + pr_warn("Spectre v2 mitigations not under software control, can't disable\n"); + + enable = false; + } + + toggle_count_cache_flush(enable); } #ifdef CONFIG_DEBUG_FS