Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6011045ybc; Wed, 27 Nov 2019 13:21:19 -0800 (PST) X-Google-Smtp-Source: APXvYqwGGBVn5jS+zemUKiCH1zGHcK7xu/LOqysrmzdy/li0ZWV08sKxqKQLv9sChWsgVhJ85oFj X-Received: by 2002:a17:906:1395:: with SMTP id f21mr49929395ejc.152.1574889679572; Wed, 27 Nov 2019 13:21:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574889679; cv=none; d=google.com; s=arc-20160816; b=lldtB/LHkbrBqCkbBy2RvKc+wH7PoJxa/byej18E3KoA9MesScELsAHjx504QHNvGU Q6xFY05JIq80v+YqnKbColXf8NCBDb8clKw87XelH4hDvZmJIJmxoeMVVnijnTcktVme S+4TAxRWsJVJ+u8tIlKODgkS7rlI8faVsKwuYtpm9JAP0gF28ssQfe1LS99rdWqyUh8k j7Z6tWtjrE0iz52IuZ/FTw7zRQnpg5iGLjW1HLsEkhsMesC7Px0lRGjkSnV6yv9u3FKa 7Oivlaw7EsJiJnY4OUgJvSq6//AyEEn6NQsrPT0CM1kubhk1c+yqY7PUaEvm9R5xiUMM TFDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=rLwnRcPIm6Jc2oP7Jmvt/5TGe9ysJp6wAHcymY4POgo=; b=gQRhbwmP2/OQWFBHEloxzdHAvS24sNiWqoQf9IonA0ypfLtqKONPdENx1OhQQY3qu8 ZiaLSNlisB0h31gD+/5wx/iQo7XEybNVf/SY3UWy9gpz6TOPEBeUXa+IPQHZgsniZ6lj T3i0ynCFX3s6g4gFE6B7kqOgEUiBPjpQEHgGzHNl+YBDQ3L8N0hOnxbzUK5Wehk62FCq dAehR0OQI3DorUugBYaapHTWk1nSHU+KdNqjyPk6OX0WVaaZIssb1qdcmIRRuH7kyzuV Yptx2ucwkk8y2JOd2odiJwu6HpoUYrsiwn6a2nMPsnf2DGqLXr4ReS0tDrprQFEV0mmI S5uQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ys9c11P8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 27si12439837eji.207.2019.11.27.13.20.55; Wed, 27 Nov 2019 13:21:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ys9c11P8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730472AbfK0VN7 (ORCPT + 99 others); Wed, 27 Nov 2019 16:13:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:46838 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387500AbfK0VN4 (ORCPT ); Wed, 27 Nov 2019 16:13:56 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8A70D21556; Wed, 27 Nov 2019 21:13:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574889236; bh=edJx2cAHfixmC0zyvlsHBTeDbnwMU/Lbodnd4g+u4rk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ys9c11P82Z8aJ5JkZF6AK93QSoUgzAJydb+aOSPjWz0GaNv38x2j8sQ0EWwPQW0Jk oaAQwcxvDheOyVk8tJgpX6KTkLf9z/tX3ShmZifhl8guwuyAU4+RQ2RZcT8zXZ05Nx 45HIOtiRy6Rxu2wXsbYlgQpqXoHG1T9FoTqhX/kw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "Peter Zijlstra (Intel)" Subject: [PATCH 5.4 39/66] futex: Split futex_mm_release() for exit/exec Date: Wed, 27 Nov 2019 21:32:34 +0100 Message-Id: <20191127202720.161543786@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127202632.536277063@linuxfoundation.org> References: <20191127202632.536277063@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thomas Gleixner commit 150d71584b12809144b8145b817e83b81158ae5f upstream. To allow separate handling of the futex exit state in the futex exit code for exit and exec, split futex_mm_release() into two functions and invoke them from the corresponding exit/exec_mm_release() callsites. Preparatory only, no functional change. Signed-off-by: Thomas Gleixner Reviewed-by: Ingo Molnar Acked-by: Peter Zijlstra (Intel) Link: https://lkml.kernel.org/r/20191106224556.332094221@linutronix.de Signed-off-by: Greg Kroah-Hartman --- include/linux/futex.h | 6 ++++-- kernel/fork.c | 5 ++--- kernel/futex.c | 7 ++++++- 3 files changed, 12 insertions(+), 6 deletions(-) --- a/include/linux/futex.h +++ b/include/linux/futex.h @@ -93,14 +93,16 @@ static inline void futex_exit_done(struc tsk->futex_state = FUTEX_STATE_DEAD; } -void futex_mm_release(struct task_struct *tsk); +void futex_exit_release(struct task_struct *tsk); +void futex_exec_release(struct task_struct *tsk); long do_futex(u32 __user *uaddr, int op, u32 val, ktime_t *timeout, u32 __user *uaddr2, u32 val2, u32 val3); #else static inline void futex_init_task(struct task_struct *tsk) { } -static inline void futex_mm_release(struct task_struct *tsk) { } static inline void futex_exit_done(struct task_struct *tsk) { } +static inline void futex_exit_release(struct task_struct *tsk) { } +static inline void futex_exec_release(struct task_struct *tsk) { } static inline long do_futex(u32 __user *uaddr, int op, u32 val, ktime_t *timeout, u32 __user *uaddr2, u32 val2, u32 val3) --- a/kernel/fork.c +++ b/kernel/fork.c @@ -1285,9 +1285,6 @@ static int wait_for_vfork_done(struct ta */ static void mm_release(struct task_struct *tsk, struct mm_struct *mm) { - /* Get rid of any futexes when releasing the mm */ - futex_mm_release(tsk); - uprobe_free_utask(tsk); /* Get rid of any cached register state */ @@ -1322,11 +1319,13 @@ static void mm_release(struct task_struc void exit_mm_release(struct task_struct *tsk, struct mm_struct *mm) { + futex_exit_release(tsk); mm_release(tsk, mm); } void exec_mm_release(struct task_struct *tsk, struct mm_struct *mm) { + futex_exec_release(tsk); mm_release(tsk, mm); } --- a/kernel/futex.c +++ b/kernel/futex.c @@ -3661,7 +3661,7 @@ static void exit_robust_list(struct task } } -void futex_mm_release(struct task_struct *tsk) +void futex_exec_release(struct task_struct *tsk) { if (unlikely(tsk->robust_list)) { exit_robust_list(tsk); @@ -3679,6 +3679,11 @@ void futex_mm_release(struct task_struct exit_pi_state_list(tsk); } +void futex_exit_release(struct task_struct *tsk) +{ + futex_exec_release(tsk); +} + long do_futex(u32 __user *uaddr, int op, u32 val, ktime_t *timeout, u32 __user *uaddr2, u32 val2, u32 val3) {