Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6011863ybc; Wed, 27 Nov 2019 13:22:03 -0800 (PST) X-Google-Smtp-Source: APXvYqx29iDHkGP8Wz3QZ9BD+rZFCY87TG8ehFTmK80eKZGB/kgyMrZv2zSAhYOCdkqKVablZ4h1 X-Received: by 2002:a50:d0d0:: with SMTP id g16mr27997800edf.75.1574889723691; Wed, 27 Nov 2019 13:22:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574889723; cv=none; d=google.com; s=arc-20160816; b=M6qdTY/sFkapcF/cKoOrMjJwV/z9SrtwhpfFfBbv7zYGveJLMMp1Dn2CySGlHYXrWO 4i5bwtLxL3nVHwjY82TvKGl0/KfNA/NKM7WZXaGrA/Zd3MiNau6nCWrMl1aPzYpR/tOV xJtvtXXUEAOn01U2nTZmTZbWTa2xOKcocaeqJ2/JLGg6DX3HooJhmrOjzRAAmVOOP0q5 g3RB7LQCOvlB5DsvVlOGPy6R/e61FT8f/PFGV4am8xvj6XPLUv77W+Ij7YtEI74ObAN+ yyGiH0viXQ/X6G3+UleMMEDpl1K8n3/BDB0Gb3+0h6JTXuY62f+cEUxS/HaGcN553Oqn iGsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=zrIGLF/E4CiY7YhMOfJe+K72yow+/WXPAK/wwkRwT1w=; b=nFDIbBdQS/zSZFZtyRmSwSuD/n7Xl5cJh08q8WBPSFFGbQCmwNEazeuKKGoGXkaGi6 rjn4EG6/9S6fwuleyHKVj7YOk4mChe+MbWVWzDPdLmfrhG+qqHrJAa+3r3EF3zmcwwrB BTRzE/bLjpMfpkNuT2/feM3+dnHISE3zUWwI0G7DhOf8K9R4Drk6SVZdsN2H4tJZc38E CNXyJ5Exo/23pfFnNU95qS16NEYnceu7sOZD8PQfhciJeW9ESUh+iEtsNZ7kHLvqXJZl PmqXgsbPW5GS3AXpRO+PxslNGJQKQWlxmnDQav54tVOwxMf10ZlvNDBGFvQ7p+ltv3sj ZpWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pvMIPncc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ci20si10511310ejb.20.2019.11.27.13.21.39; Wed, 27 Nov 2019 13:22:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pvMIPncc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732323AbfK0VSc (ORCPT + 99 others); Wed, 27 Nov 2019 16:18:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:39862 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728335AbfK0VLY (ORCPT ); Wed, 27 Nov 2019 16:11:24 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 63D952086A; Wed, 27 Nov 2019 21:11:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574889083; bh=IZD60WKOoIIwQZ0XlG9VB+VgoMwu1UzQuNA7TjHizyw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pvMIPncckvPJeTcBds/zi81bKDNKVqgWoFrdsDYN9T6bq0km4GgnPJTY7K1ItboaQ xuriVPxZn3o4Vb77Pqo1uQ9ZF2z0T8LX7dotnj4zjvM0/P+YYFfo1Z3g1O5xQjExug unLv46ZIYiDBFPO754/GVKy/icFLowhldzDVTUbQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+d93dff37e6a89431c158@syzkaller.appspotmail.com, Oliver Neukum , Sean Young , Mauro Carvalho Chehab Subject: [PATCH 5.3 76/95] media: b2c2-flexcop-usb: add sanity checking Date: Wed, 27 Nov 2019 21:32:33 +0100 Message-Id: <20191127202943.105318630@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127202845.651587549@linuxfoundation.org> References: <20191127202845.651587549@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oliver Neukum commit 1b976fc6d684e3282914cdbe7a8d68fdce19095c upstream. The driver needs an isochronous endpoint to be present. It will oops in its absence. Add checking for it. Reported-by: syzbot+d93dff37e6a89431c158@syzkaller.appspotmail.com Signed-off-by: Oliver Neukum Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/b2c2/flexcop-usb.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/media/usb/b2c2/flexcop-usb.c +++ b/drivers/media/usb/b2c2/flexcop-usb.c @@ -538,6 +538,9 @@ static int flexcop_usb_probe(struct usb_ struct flexcop_device *fc = NULL; int ret; + if (intf->cur_altsetting->desc.bNumEndpoints < 1) + return -ENODEV; + if ((fc = flexcop_device_kmalloc(sizeof(struct flexcop_usb))) == NULL) { err("out of memory\n"); return -ENOMEM;