Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6013008ybc; Wed, 27 Nov 2019 13:23:18 -0800 (PST) X-Google-Smtp-Source: APXvYqynnDTlAalN2MuCXs/Z4a5GJJA+1tUCagNViOMjI9LPeI5wW/8Na1k0bTyPU941eQ6P3HSk X-Received: by 2002:a50:c048:: with SMTP id u8mr3873084edd.226.1574889797982; Wed, 27 Nov 2019 13:23:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574889797; cv=none; d=google.com; s=arc-20160816; b=xKlF53u+nigWeWthPPPsjaawWR1nypT++gzHivMoX/pGwOxph2FAhO5s/53HlpJK1c 8ZPC2eDtHLIdoB194VBB9gh1eGjFysk81YSYrEK7aa3ucakSNnBo1AJOQsW61YtX21j4 ApnRJRY2XgMONCOZhj7AOr/o6CrMsHj66CGUecyGJz7YjgLDY4Tl/R4Q5iji+wdOpoFB VFcG7r2NGJIIXAxWMacVOGLlT+Pvm/G/qCi/EeAXckQinQTIWo1dbrjvjxk0dSx+XVfx tTY5WGxRI46/O/P+ckupCOJ9FE2z1fPZhFGY0ASroh0XCaSFSO3s7okTqGQurqBtWgAe u2Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DUUHQceZTuDbGMadm39KvVwAWf9/t/R605jfrJcJwdo=; b=S8aI6osDLkELB4GGdMT53fv6zxaltfHsvq1dmF7MAuqtfLpumD6T5WYYJjC7GUHm5Q eyFs2y5K77ONWOiWJ1zNYYFIZy+rm81eP62bpTUTvGyDd//s6scJdMLJH9gZkQ3KKu5T 94qTRmVF8CUat/RSqeoFf3iOjJau/VZRR3FL+lULTsqDAOQSiIA0RWOTOIhgItOSoxfR J3J9kr2YOif6iaQoQOyzr/cMHGEhNeQCmaYMEJMH1z4m+3HQOAnuq7glbRnzzCRi6He5 l8erHhNxcO+oyp9oaWvIK9Lif/v0HKlsBjwi43S/aLF+hbegVZy0WTTQ9Jdsx3Qbh6RK BImg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gLlY7HMb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id dk20si4609772edb.413.2019.11.27.13.22.53; Wed, 27 Nov 2019 13:23:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gLlY7HMb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732949AbfK0VUe (ORCPT + 99 others); Wed, 27 Nov 2019 16:20:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:35430 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732415AbfK0VIy (ORCPT ); Wed, 27 Nov 2019 16:08:54 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6A4332086A; Wed, 27 Nov 2019 21:08:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574888933; bh=++ufQvgnwa0RLQFr/tm5QXSA/TA2OxsMUekOA1cGmQk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gLlY7HMbyRerevrEIJ0wDk8QEY0nUkGkX9cbbl+UItTz5HxcYMzOBAxr+kvEtD184 /5D+dNjn9PfVd+G0GpkySdBw0+qRazNFJzjx24wgZfk/bEhhZTn8FEQjL9atcpaQ+X LqF/SNGNqlPpQYRgNA7lDL7VlhL3KpY4I3O0fs8E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Luigi Rizzo , Tariq Toukan Subject: [PATCH 5.3 02/95] net/mlx4_en: fix mlx4 ethtool -N insertion Date: Wed, 27 Nov 2019 21:31:19 +0100 Message-Id: <20191127202848.171035665@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127202845.651587549@linuxfoundation.org> References: <20191127202845.651587549@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Luigi Rizzo [ Upstream commit 34e59836565e36fade1464e054a3551c1a0364be ] ethtool expects ETHTOOL_GRXCLSRLALL to set ethtool_rxnfc->data with the total number of entries in the rx classifier table. Surprisingly, mlx4 is missing this part (in principle ethtool could still move forward and try the insert). Tested: compiled and run command: phh13:~# ethtool -N eth1 flow-type udp4 queue 4 Added rule with ID 255 Signed-off-by: Luigi Rizzo Reviewed-by: Tariq Toukan Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c @@ -1745,6 +1745,7 @@ static int mlx4_en_get_rxnfc(struct net_ err = mlx4_en_get_flow(dev, cmd, cmd->fs.location); break; case ETHTOOL_GRXCLSRLALL: + cmd->data = MAX_NUM_OF_FS_RULES; while ((!err || err == -ENOENT) && priority < cmd->rule_cnt) { err = mlx4_en_get_flow(dev, cmd, i); if (!err)