Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6015000ybc; Wed, 27 Nov 2019 13:25:54 -0800 (PST) X-Google-Smtp-Source: APXvYqytYYDjBB7i2TzXsdEtpzOpHO1t1DCZYgC00ayumdzPl6l1AwR7CbgH/7UnaNiBMkhb3Q1k X-Received: by 2002:aa7:c5d3:: with SMTP id h19mr34788835eds.120.1574889954670; Wed, 27 Nov 2019 13:25:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574889954; cv=none; d=google.com; s=arc-20160816; b=QXnaxwFhiJIP3JgDBhxxsgMBn9nX7Y2q62Q7fCjLZUFKrehphCmyQrF1SN8SGuz06U LlqyLhAYkRSEBXTkYtepNKUqzLqF4T3nlNkVpQ3oGpT2NbynFCMhk91RF+O3Oogv49jH JJHcQ7zTyuN670wR7Y7D7b4Qe09tPLgZIyQMyxX5PA3Z802JdDChWb7MiQb+CD0J1APw 3tdzFkOlcNp4QO13r+RBIlUtytyi5sX0SU/qZEcmrIRMV+IFhGYn0ePZKXxpv3zRedWc zMvFaEMbzClbCvYImXLyHrBwAwYWAV0FYjlRYlITKqx8Lqgm7RiQT/MzqccqNMqWKMm2 msXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=QA9pgT2GLdGz9QHzu7EU5yT6wtX6bebWCNg8A3l8ego=; b=acZ2ujNURFw9d4tR6IcxdhErk3WxoIdd72tFgyDXOIaxA4Ivn7tCP4dwFsc7aY7mZP 3QUNiN5k3CrwqDYAWEriOJ/Q+H/pMaL7dh70Nwd2kxGSk5/Pz2Ks3TBSFrILwYeXLR+A 7JQqYa1FTzCjf+NSm6QZTrZfeTMttusUFv6EiA+xt/MGg9IQ1hRwoUXvQT33RNxewbbO DG3og5UPSrn4e7JZdYeaTButojDlzHeC1Eoniu+VQI8LTm35X988pr75nKf/7tz33mcT 9JMBtwNQLVKYpNLrrVz4MW/py+V2pdZ2iUBchoORckbMqaJ5NJJYBJe4uFf1zU/cx91w yK6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AJoHCIPM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f25si10700776edq.132.2019.11.27.13.25.30; Wed, 27 Nov 2019 13:25:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AJoHCIPM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732638AbfK0VVJ (ORCPT + 99 others); Wed, 27 Nov 2019 16:21:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:34008 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732043AbfK0VHq (ORCPT ); Wed, 27 Nov 2019 16:07:46 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D155020637; Wed, 27 Nov 2019 21:07:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574888866; bh=ofE2EqY7W9xW3Wu4tt2rqooLZDzue3n24dtJOdV27bA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AJoHCIPM9L8Zw8C9jpQHph3fRYurI783V79vSz6B/sJmxaWIPA65/YU7itMWuxI6Q oBrt6489RhtRH2A/L4namlHRxsZjk1zI29Nt/wWLIde1cYtFVoLnOLzh/7Zn3taLmr ml3BDKqAeUzW2TPx3SycT6mGh/NVTrfdC2hWCpsk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 4.19 300/306] USB: serial: mos7840: fix remote wakeup Date: Wed, 27 Nov 2019 21:32:30 +0100 Message-Id: <20191127203136.638683675@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203114.766709977@linuxfoundation.org> References: <20191127203114.766709977@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 92fe35fb9c70a00d8fbbf5bd6172c921dd9c7815 upstream. The driver was setting the device remote-wakeup feature during probe in violation of the USB specification (which says it should only be set just prior to suspending the device). This could potentially waste power during suspend as well as lead to spurious wakeups. Note that USB core would clear the remote-wakeup feature at first resume. Fixes: 3f5429746d91 ("USB: Moschip 7840 USB-Serial Driver") Cc: stable # 2.6.19 Reviewed-by: Greg Kroah-Hartman Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/usb/serial/mos7840.c | 5 ----- 1 file changed, 5 deletions(-) --- a/drivers/usb/serial/mos7840.c +++ b/drivers/usb/serial/mos7840.c @@ -2325,11 +2325,6 @@ out: goto error; } else dev_dbg(&port->dev, "ZLP_REG5 Writing success status%d\n", status); - - /* setting configuration feature to one */ - usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0), - 0x03, 0x00, 0x01, 0x00, NULL, 0x00, - MOS_WDR_TIMEOUT); } return 0; error: