Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6015134ybc; Wed, 27 Nov 2019 13:26:02 -0800 (PST) X-Google-Smtp-Source: APXvYqwUvzwsrM+oApQ6YiiLJvvY0HFt/3mB8UUyARUU6jYpmpfFMVqDEdf6yg+0wsB998XlzvXd X-Received: by 2002:aa7:d8d4:: with SMTP id k20mr28192870eds.144.1574889961901; Wed, 27 Nov 2019 13:26:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574889961; cv=none; d=google.com; s=arc-20160816; b=fC5lI5aBDLXe8JnvehSF+UFCrI+X2WHhd9UhEN7ANDLcbNhukbhpVY/Px4NR3euC6a a9xwg06205YiD4xxInUW8xPPKNqIFEQKjTq+Xm2me/yHumH4GaXv80cR/0l6RL8TtPbR 1EwO3DSQxxuAuAnxZemSE3UQibcNM5/lLquiGPku/nIsVn+n2/2ctJM5efkkivrjfzTe XKcqhOHKmc3+oKCgszv/frr+eR2JpyAvpY5M+SDWQpnBJ5yibgURFaL5xhTlnR2e37hc m88zvooXwXT2QV2mz7v+MDlQO71jKdnRcg294u30D/Ors2vwhLFQfoGBJYcdEWUNtuVS oZ2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=v2EKhrgssNRMVxBHrLGwSTKMl07AubGaIEAIJiuW+6c=; b=QJe0kbXTzES9KMp6eo3c1gb1S9iXGFYZIeb9MovcH3ZaCBqK7sGJ5yMFAR2drzQze1 Asw4MoUXlbvSCxjoBZZ0qoshdw7QFhdXy9nFYc03Goj9jXfGx4NCdjPZtBYfXLVI3yN6 zFL1mhQUKdPVdT1M+MRgbd8UYCTBDE/f6SlTcmIgU5GsU9fx9oS51Susud128abE3D3E E1IdGrMy3sY3eSeu+WH+WSqE2Hh+mfnRljK2AKHQUC1dyVDj66QTjyogh5OTBwHzw836 H9ZqAFnXnJ+syPEkWXzRnC7uwoFSaTtk/2ypuDoFlA6Npj1LOwylhm8OTFjHxbZf3ZM/ 1WYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="mZL3F/Qa"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id dm19si3152038edb.214.2019.11.27.13.25.38; Wed, 27 Nov 2019 13:26:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="mZL3F/Qa"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732145AbfK0VE1 (ORCPT + 99 others); Wed, 27 Nov 2019 16:04:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:57884 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732141AbfK0VEX (ORCPT ); Wed, 27 Nov 2019 16:04:23 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 83DBE20637; Wed, 27 Nov 2019 21:04:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574888663; bh=soeUHr+11ttwbqIpHKGJFhQFwzuNjuqD2hkS2VnUn/E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mZL3F/QaTKNCkWhL3uxZSWnkyrkDb8br2h+H+AIsET97mxx4DErLS518wD9Y+XNl8 5ro7e3ARKX6ElGqSIX6MFJwze7FK+5cVT+MXqO/ZfQgKMJXH79y3wCq05acv5HDHrX KJcYgkur43ez4XJv4EsGk2KrycQy1jSmS8TCBVGQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ali MJ Al-Nasrawy , Kalle Valo , Sasha Levin Subject: [PATCH 4.19 220/306] brcmsmac: never log "tid x is not aggable" by default Date: Wed, 27 Nov 2019 21:31:10 +0100 Message-Id: <20191127203131.122529619@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203114.766709977@linuxfoundation.org> References: <20191127203114.766709977@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ali MJ Al-Nasrawy [ Upstream commit 96fca788e5788b7ea3b0050eb35a343637e0a465 ] This message greatly spams the log under heavy Tx of frames with BK access class which is especially true when operating as AP. It is also not informative as the "agg'ablity" of TIDs are set once and never change. Fix this by logging only in debug mode. Signed-off-by: Ali MJ Al-Nasrawy Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- .../net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c index 81ff558046a8f..6188275b17e5a 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c @@ -846,8 +846,8 @@ brcms_ops_ampdu_action(struct ieee80211_hw *hw, status = brcms_c_aggregatable(wl->wlc, tid); spin_unlock_bh(&wl->lock); if (!status) { - brcms_err(wl->wlc->hw->d11core, - "START: tid %d is not agg\'able\n", tid); + brcms_dbg_ht(wl->wlc->hw->d11core, + "START: tid %d is not agg\'able\n", tid); return -EINVAL; } ieee80211_start_tx_ba_cb_irqsafe(vif, sta->addr, tid); -- 2.20.1