Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6017692ybc; Wed, 27 Nov 2019 13:29:24 -0800 (PST) X-Google-Smtp-Source: APXvYqxMkZBwLr313XBPGmiJiUXuXCczYpuJSD3UMqMxUIeXA0WXmAdys91UvKdB69ICOSs7JNhL X-Received: by 2002:aa7:d496:: with SMTP id b22mr34362549edr.122.1574890164190; Wed, 27 Nov 2019 13:29:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574890164; cv=none; d=google.com; s=arc-20160816; b=wvxnXPMRFIHlr43McTaxbeBNiX46Cw8z0cCysWAm8hnKljsubluYBxVfPXlhNXnOeJ HjogVTW598gummhb7U0clhYLxEzwiaCBlcZFVPkU1SVRVlpPFYaTvrTU5XnBf9zC00xF RfNPK89jFI7WKOGDDijEQDN19zXGEVYIPId5fCS58B7nyh/kbvqphednucPLAU8d42AC bHX+4TNu7bcr6SL1Xa/ky/2Eto2DU2ztvBhNbUQxRYa3UjPTxZxSkjvbKALkus3hPkIt Nl+u/iymXPjHexzQ4TwjsAMl2p9vOPHp/Uxy7ayCB3Z9nCOWC9bhdcTFUAzlqQmXhNFl C86g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=kbLKVH4E9PZIEWaCcEeo/Y16oYF8MIC2r991Ork1Pls=; b=BvrNKfbd+NLKS8QvfPUWi2rFbLtI0Q7782c/aH05YOUiwd74QYeX28iW1PlpuMbJjw zJykeOZ8AF5PMzhMjHnctNFL1DK37q0X4zCV7DjZeMIh5bjsBe/Q0pmn2Ubtm0snMnVo P4IK1g7W36uMsEIqCcgBAC4jGkp1NRgHv1eajhZqOSDz18mA9pJT4H4US7P8ND35oZts 8VuTb7BV+oKKAKPoQZGUmc6JIUgDJZWqsVRcauG5RCjzGOtVphqUv0fiBlxrEqcoJTUV ODbra8b0YXUZPQ3cjFEiyYGLzvE8z1Ve5ysW1EF0EAESbtzDEahKCeRr728YVctXIeO8 6GXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="dv/WpRHF"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g12si10986216edp.190.2019.11.27.13.29.00; Wed, 27 Nov 2019 13:29:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="dv/WpRHF"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731304AbfK0VAZ (ORCPT + 99 others); Wed, 27 Nov 2019 16:00:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:52132 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731269AbfK0VAR (ORCPT ); Wed, 27 Nov 2019 16:00:17 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B6FD92154A; Wed, 27 Nov 2019 21:00:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574888417; bh=IjvQhKnlcixplGYef5OlTSVczlEn23RmU4lkJjnJ5sw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dv/WpRHFnAhcuKpHJxWY9wo2axTx7BrC/k1lCrlshKMX6ZGqXi66e8INfgI5xgZRI O2IetCYs5+1NQoZj60r0KqsWdb9tbSolczn8svkpSu/POcqLA0TmKG+KcYI9hztWEX pYdkKf8rqUyp01VMErMcMjY7XoueisowiL6O3IE8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Heinz Mauelshagen , Mike Snitzer , Sasha Levin Subject: [PATCH 4.19 099/306] dm raid: avoid bitmap with raid4/5/6 journal device Date: Wed, 27 Nov 2019 21:29:09 +0100 Message-Id: <20191127203122.125456304@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203114.766709977@linuxfoundation.org> References: <20191127203114.766709977@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Heinz Mauelshagen [ Upstream commit d857ad75edf3c0066fcd920746f9dc75382b3324 ] With raid4/5/6, journal device and write intent bitmap are mutually exclusive. Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer Signed-off-by: Sasha Levin --- drivers/md/dm-raid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index b78a8a4d061ca..6c9b542882613 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -2475,7 +2475,7 @@ static int super_validate(struct raid_set *rs, struct md_rdev *rdev) } /* Enable bitmap creation for RAID levels != 0 */ - mddev->bitmap_info.offset = rt_is_raid0(rs->raid_type) ? 0 : to_sector(4096); + mddev->bitmap_info.offset = (rt_is_raid0(rs->raid_type) || rs->journal_dev.dev) ? 0 : to_sector(4096); mddev->bitmap_info.default_offset = mddev->bitmap_info.offset; if (!test_and_clear_bit(FirstUse, &rdev->flags)) { -- 2.20.1