Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6020849ybc; Wed, 27 Nov 2019 13:32:14 -0800 (PST) X-Google-Smtp-Source: APXvYqzCeib8sK23sg1pPdK4mONi7WL/Yfs124TbtbZbZr+qO2bLw/NinvB49yvnbrcrz7hvE/w+ X-Received: by 2002:a17:906:6403:: with SMTP id d3mr52282557ejm.258.1574890334540; Wed, 27 Nov 2019 13:32:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574890334; cv=none; d=google.com; s=arc-20160816; b=HgthwpGWVywg82Llfz/YVMXG+tW2DbUIPVH2u4Prbhp3rpSDNtpU2rS4LsTqPYxrty 6cqz727d9PRjmLqk+1qCKPTtSASga1HgmxKHFFb0XrPH8TArpgd1dwvOC59c7eLEEejR Se5wiCWOmAOkPC5LM4rEHd5rB8pSAGeH0H3IvRJxEWCIPJ4zy3EsAcGh/KNflSEHJ0Ec 5STJiaS7nUlAx4gpUHfgcaIH1oY44NCnLeYKjkKk9xF2a1rsdpWGyWGYI4+MCHilaaYt iN3oo2T8RFo8xDGXRBJzuj6LDcKF9cvbQM+ZVJn+8QySky9nQfE8Bd2iJ0XYDmRTl619 yqeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=VEKGgHp31BwUzSb8eAWUVoS3BTB4RoOrBxcAtMsyaPQ=; b=RKjlSLLc5/yuYGzG//O2JSL4/jbPts9UILR0aXDZf0z0+I1xi13CwtArrM8bFTwz4K 6CGVrd3tfocR7gygiO2zhho3yopfDrHAcobbTd82ZOe32JSvP7U28MwAYXer95S0UkWw Zo/XVM9N4Wq9nlPb/yihFdGn02t9PhaRmjWQYovaiTfjjzNgIBNZzNrJWjW4cg+NfJW9 7Blbd5XcHX/joMbtr/4Vi+jwkH4eI2ityly4zeHK3qk34OyH4Ek+q+RkHUNkmCZ4m7ZO yOOoQPdvXWeBcJBpGic/1zsklHxFSxw36gO8m2PHghai/K76ECIyzxGXSax5QyFmIfBz jZnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yxdjey30; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bt2si1901263edb.324.2019.11.27.13.31.51; Wed, 27 Nov 2019 13:32:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yxdjey30; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731099AbfK0U4o (ORCPT + 99 others); Wed, 27 Nov 2019 15:56:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:47518 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730176AbfK0U4m (ORCPT ); Wed, 27 Nov 2019 15:56:42 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1581020862; Wed, 27 Nov 2019 20:56:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574888201; bh=E+336G3Zqyz4BvpRIJ6RtfyKVtr1OG5s4I4J4q3nsHU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yxdjey30MvxHVWXhy3o7GU3GWyZDiGyB18ITXWkZYvJZzO+58JdYtMAvNi5rnW5iI g6JmKQA22TzH0lRmpPqlr6mjLF8cVWH8bbc6NPvi/kmbPyEDi2QpVunMPOl0gEF4MY tg9lPpYs210xBTtsUS/DhD7OaGQvcdlXCsda9kJY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jens Axboe , Sasha Levin Subject: [PATCH 4.19 042/306] skd: fixup usage of legacy IO API Date: Wed, 27 Nov 2019 21:28:12 +0100 Message-Id: <20191127203117.912903311@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203114.766709977@linuxfoundation.org> References: <20191127203114.766709977@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jens Axboe [ Upstream commit 6d1f9dfde7343c4ebfb8f84dcb333af571bb3b22 ] We need to be using the mq variant of request requeue here. Fixes: ca33dd92968b ("skd: Convert to blk-mq") Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/block/skd_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c index 87b9e7fbf0621..27323fa23997d 100644 --- a/drivers/block/skd_main.c +++ b/drivers/block/skd_main.c @@ -1416,7 +1416,7 @@ static void skd_resolve_req_exception(struct skd_device *skdev, case SKD_CHECK_STATUS_BUSY_IMMINENT: skd_log_skreq(skdev, skreq, "retry(busy)"); - blk_requeue_request(skdev->queue, req); + blk_mq_requeue_request(req, true); dev_info(&skdev->pdev->dev, "drive BUSY imminent\n"); skdev->state = SKD_DRVR_STATE_BUSY_IMMINENT; skdev->timer_countdown = SKD_TIMER_MINUTES(20); @@ -1426,7 +1426,7 @@ static void skd_resolve_req_exception(struct skd_device *skdev, case SKD_CHECK_STATUS_REQUEUE_REQUEST: if ((unsigned long) ++req->special < SKD_MAX_RETRIES) { skd_log_skreq(skdev, skreq, "retry"); - blk_requeue_request(skdev->queue, req); + blk_mq_requeue_request(req, true); break; } /* fall through */ -- 2.20.1