Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6021459ybc; Wed, 27 Nov 2019 13:32:54 -0800 (PST) X-Google-Smtp-Source: APXvYqzxMZAQ2AFu9tzZHluTEbcLCIyYO4l9UR5P52hGy8sjcnDlONBBx+D4NyOK886Z/94MDZUp X-Received: by 2002:a17:906:82d0:: with SMTP id a16mr23613563ejy.206.1574890374727; Wed, 27 Nov 2019 13:32:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574890374; cv=none; d=google.com; s=arc-20160816; b=hnBw//9CFgl37ym8REdP8FWClnwkxEABC7fJqByXqem7FnzjhllctXn3KYeKIlRTEb Spo2hLPdPeCHjMStH3D247OgOV/HXDJNGq867DSosisl96lQH47zK3NpO+0SlsXxijpu 05BS6YD+zlFSftumtLBsyFuuYq4hc3nVVI8lfyn6QGILuqzcd9B5OaauSUw2b0QZMqD4 YxEs3pwbnULsf2YjcCj+ccLNCP4xev4+taDz8VHWxwfVmEw6N/oyXJbwPN/Mqw3nH9X/ mpYnrvAO6Ar4wsXBbyvihoF4kBLhEXwt0G0PhyeDscxeAlV11rM40P8t31rc5MawyEKC NEGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=1510cbrcAtFvUZ9sa3SWHbzwFpTvi1uSwB1g9Kxd1lQ=; b=mCEmsuPrCVSHuE49dRH+J0Cuywmr8pL8/DojnJ7XaOWXqF8R7RcIuELc1tQwCa8AoW wQmk/k3NzTskLPdfOvQSMUWjxW3mWjxqBDbt8BOy8wdy22XLayRbHp01cUAaobNjcSEo IA1Nf/ksWV47amQvk5Bj0kqCqVZwrauC8EEi4a6CCHcTUsTQBIXk74V038P5Dv82qaOZ UcnYVC3L9lfdmZOf1p6Hl5mMqFDkmb/1nh8DhurZxsLa8BqJnQH01gwUzYAO/4HTSRto f1LZ2RMkXYLgLHHCmr7hz29eLMoaB3i10Nb6pXBIw3xCEQbfqmOYCKo1YBI2ZNBKyCu1 Yv+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YmTwYmY1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gt1si1858342ejb.144.2019.11.27.13.32.31; Wed, 27 Nov 2019 13:32:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YmTwYmY1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731337AbfK0VaP (ORCPT + 99 others); Wed, 27 Nov 2019 16:30:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:46708 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731017AbfK0U4A (ORCPT ); Wed, 27 Nov 2019 15:56:00 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9AA082084D; Wed, 27 Nov 2019 20:55:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574888160; bh=mdj7XPfQr7aTT3QJ1EjZS6B280N60fbSQCKhLUyoZvw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YmTwYmY14XQ97vVEy1LPhK/fjSK9o69Le4yFmU2v8WEZnAHed15feS1z8VxYUUw6a lBwDKLoeDzsrKeH+ysU4KvVP4XFvc7+b/IG3/f9z19O3lHO59vdYmaA+EZiPVifp+D bJFj2bmD/ITshCaJKfQvd/5QYp+P7ZvXY131mrAQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alan Douglas , Lorenzo Pieralisi , Sasha Levin Subject: [PATCH 4.19 027/306] PCI: cadence: Write MSI data with 32bits Date: Wed, 27 Nov 2019 21:27:57 +0100 Message-Id: <20191127203116.673854739@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203114.766709977@linuxfoundation.org> References: <20191127203114.766709977@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alan Douglas [ Upstream commit e81e36a96bb56f243b5ac1d114c37c086761595b ] According to the PCIe specification, although the MSI data is only 16bits, the upper 16bits should be written as 0. Use writel instead of writew when writing the MSI data to the host. Fixes: 37dddf14f1ae ("PCI: cadence: Add EndPoint Controller driver for Cadence PCIe controller") Signed-off-by: Alan Douglas Signed-off-by: Lorenzo Pieralisi Signed-off-by: Sasha Levin --- drivers/pci/controller/pcie-cadence-ep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-cadence-ep.c b/drivers/pci/controller/pcie-cadence-ep.c index 6692654798d44..c3a088910f48d 100644 --- a/drivers/pci/controller/pcie-cadence-ep.c +++ b/drivers/pci/controller/pcie-cadence-ep.c @@ -355,7 +355,7 @@ static int cdns_pcie_ep_send_msi_irq(struct cdns_pcie_ep *ep, u8 fn, ep->irq_pci_addr = (pci_addr & ~pci_addr_mask); ep->irq_pci_fn = fn; } - writew(data, ep->irq_cpu_addr + (pci_addr & pci_addr_mask)); + writel(data, ep->irq_cpu_addr + (pci_addr & pci_addr_mask)); return 0; } -- 2.20.1