Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6024956ybc; Wed, 27 Nov 2019 13:36:45 -0800 (PST) X-Google-Smtp-Source: APXvYqwzGy4if3hfpYVVAdpo05hYn0c2YcrzterXIVoJjsE/AH0jF69AgRffBKWrvdAcu8Kw/7W4 X-Received: by 2002:a17:906:1d41:: with SMTP id o1mr52309818ejh.333.1574890605767; Wed, 27 Nov 2019 13:36:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574890605; cv=none; d=google.com; s=arc-20160816; b=yMzVppkl/6lBPWqa5swKQammC+g8w5o2Mfgc+8H8vd46wC/m/DS3lUE3P6hupjoRrz B/Ndf8iTcW0ngrbniUeZzIqs/IjfCKwn70OltZzugZJQKKeuw9PG1jfCuJhYuwj/9Uez cEi5+14MN5xJ5CTaf7QyyL5iv9JyeWFi4Psn6lCNkn+4KIjhEuAlH2YdIB5DPARs20Nq MkTSu3e1DuVtBTWBc0xUe65nZY5FpR8gC4wzR/M1usgkcl5LL/wOnICgrj8vo+5VSWGC 25GicAPxFmD2WsbLfM+NxaeIUZowzhnoNVxp5oCe1j1ZS8AI7gmlylEAfKK9KbvlTaDe TSWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=rXOLG0NsKA8nA1kGInwTOkb5ZvbLhlMd1DT/ubqoflc=; b=iMUe8YidRIpPgtG2c3VsgeYSsDvYy+a5ItICGaJ3O+Gru1yEVqjoD5u5fF/zonpjVK UjsuzMaP2osrbVvV2z8ZE6inErVzXNTuK5tPFVf7XgJAthZB1ejpJNjRL+gfWfBPrHvp rXPX1X4qiJsmlhxWo6wK0jJiqHnoin6uPs9200VECwgZII1YS8/FpmFnJDxOksObjOwB cIC00OLSlqXw7QYSH1YSAZJUL1+Cv8JvLXVVzYFTxzREkP61nm7UJR0SaZ2AUtjP4/dq X6FFm1e2dT93zaQo1i942qNEnMvHlIA++TG8hpNcY/k5Mz+7uA56xHVY+vw7KyiZ+g+r kURQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PJxwfoZV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id dd28si12618021edb.99.2019.11.27.13.36.22; Wed, 27 Nov 2019 13:36:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PJxwfoZV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727280AbfK0Uxw (ORCPT + 99 others); Wed, 27 Nov 2019 15:53:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:43008 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730764AbfK0Uxq (ORCPT ); Wed, 27 Nov 2019 15:53:46 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6FDCA2068E; Wed, 27 Nov 2019 20:53:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574888025; bh=JFkH838InWF4Uk6kpUipLTfcZq+Or1Xb9dh4tiaBm7U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PJxwfoZVEtfSlpiNtnDEGMclCcUQFngrG80ARLcS+q+kbOGXdYwTso1i+7md9BN1L e4Eawpqo7VybLDEyTk1XZOveeU2ysleB85xSBCv5NAdeSFgs4Q0pC33GfRpxgilCGM 2EvfflUUMXcxT/8W+7mYAQM5kxY8rdYhfC+3p+vM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ali MJ Al-Nasrawy , Kalle Valo , Sasha Levin Subject: [PATCH 4.14 136/211] brcmsmac: never log "tid x is not aggable" by default Date: Wed, 27 Nov 2019 21:31:09 +0100 Message-Id: <20191127203106.881430566@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203049.431810767@linuxfoundation.org> References: <20191127203049.431810767@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ali MJ Al-Nasrawy [ Upstream commit 96fca788e5788b7ea3b0050eb35a343637e0a465 ] This message greatly spams the log under heavy Tx of frames with BK access class which is especially true when operating as AP. It is also not informative as the "agg'ablity" of TIDs are set once and never change. Fix this by logging only in debug mode. Signed-off-by: Ali MJ Al-Nasrawy Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- .../net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c index 257968fb3111f..66f1f41b13803 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c @@ -846,8 +846,8 @@ brcms_ops_ampdu_action(struct ieee80211_hw *hw, status = brcms_c_aggregatable(wl->wlc, tid); spin_unlock_bh(&wl->lock); if (!status) { - brcms_err(wl->wlc->hw->d11core, - "START: tid %d is not agg\'able\n", tid); + brcms_dbg_ht(wl->wlc->hw->d11core, + "START: tid %d is not agg\'able\n", tid); return -EINVAL; } ieee80211_start_tx_ba_cb_irqsafe(vif, sta->addr, tid); -- 2.20.1