Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6025982ybc; Wed, 27 Nov 2019 13:37:55 -0800 (PST) X-Google-Smtp-Source: APXvYqx2a/aZboWPQJ22v1Dnnv69xvNrTmRqbyrkmTpvvTf03i991CVaisq3ymzceAVhnfl0e50c X-Received: by 2002:aa7:d0d4:: with SMTP id u20mr34777415edo.112.1574890675763; Wed, 27 Nov 2019 13:37:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574890675; cv=none; d=google.com; s=arc-20160816; b=Y1pWwQDJNvseG7vuHiSa7bcXm3g8GF/79s9vcjkK5vyKB1BJ3GLO3pOdXgpAJWm8Gf 3diqsbtQBHn1oibu0gH0ca3FhGSlCO9328obSXYszii/+QGzrrMAXPYPggi7xq6gtB4v OV/q6KQVSlOcQO88b15DevJYJLti3KkHpYJMRAfljX5nYmJIWPNLuJiNqmcbpv1qH4lK 5YYTTcqEPtlmeCgy8JkONGTUjRvDLb+B5WRmAbULr/YW3ltfGdHE/Ph74yM8+LM/7fpS WYlZ0B4FvO2iu8Cp0f1FgaF4aVVB2hVqA4zyPhGELNFFcB/DYS9mUCxMZYQSxF4Lf1oA Yg1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YtMMD3FG7IOtbDc41ij249x6BxD+5tk2wV1zOXkF0Uk=; b=n9vGTp+tFZraUr1fUL1pLDDwH19qVLBvf1OvNG0Ay2o+vvdmu1g7lADHib1FMzK6Sd 0YbebsKATClBph0jg8kEn//nJppf0B3HQprWO4AmcQY5KP5nl98RK/x8uIFB9K2Qies5 0mBr0Litgwotyfd8KLg+5w+/jwfcu5HW7ptp0XpxBNMd7wwQ+IWUkPVcA42YKqFFHDlp /ZrE/+jJoxm4prQ3BfYQTo72cmPx48tg12TazHQ8v3n6fmXPLzvAl/bqDaBhHika5RKh XK62dhzmuPooMreZucAkSIBc2bqabmlldsWQ+rQ6pEtFM5MwuYHJCV5eLqj/KYIns3In g+Pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="y/eLl+RZ"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id jp18si9948181ejb.318.2019.11.27.13.37.31; Wed, 27 Nov 2019 13:37:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="y/eLl+RZ"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730071AbfK0Ve0 (ORCPT + 99 others); Wed, 27 Nov 2019 16:34:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:37306 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730412AbfK0Uu5 (ORCPT ); Wed, 27 Nov 2019 15:50:57 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B1C9421871; Wed, 27 Nov 2019 20:50:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574887857; bh=wu8iWbB/vI5j91N6tp1uS1uxExscGnc+y38dgtOkPU8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=y/eLl+RZPL83SVWckG/gNA/xtLOMId5ATqtIQPY43PzIamoJbmOW2/eI0kahfAVbU EA8Kbfj9Gi0iawtTZ5i9hK/pQhSgfArTx/GO+JCedtNlVxiD2Fwg6hO5Nne6PXHOaW XveOo1LMfWS+OwqEl+7j1Cl4BZGKRIixMByADrdY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Gerd W. Haeussler" , Jon Mason , Dave Jiang , Sasha Levin Subject: [PATCH 4.14 121/211] ntb_netdev: fix sleep time mismatch Date: Wed, 27 Nov 2019 21:30:54 +0100 Message-Id: <20191127203105.588112666@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203049.431810767@linuxfoundation.org> References: <20191127203049.431810767@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jon Mason [ Upstream commit a861594b1b7ffd630f335b351c4e9f938feadb8e ] The tx_time should be in usecs (according to the comment above the variable), but the setting of the timer during the rearming is done in msecs. Change it to match the expected units. Fixes: e74bfeedad08 ("NTB: Add flow control to the ntb_netdev") Suggested-by: Gerd W. Haeussler Signed-off-by: Jon Mason Acked-by: Dave Jiang Signed-off-by: Sasha Levin --- drivers/net/ntb_netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ntb_netdev.c b/drivers/net/ntb_netdev.c index 0250aa9ae2cbc..97bf49ad81a6d 100644 --- a/drivers/net/ntb_netdev.c +++ b/drivers/net/ntb_netdev.c @@ -236,7 +236,7 @@ static void ntb_netdev_tx_timer(unsigned long data) struct ntb_netdev *dev = netdev_priv(ndev); if (ntb_transport_tx_free_entry(dev->qp) < tx_stop) { - mod_timer(&dev->tx_timer, jiffies + msecs_to_jiffies(tx_time)); + mod_timer(&dev->tx_timer, jiffies + usecs_to_jiffies(tx_time)); } else { /* Make sure anybody stopping the queue after this sees the new * value of ntb_transport_tx_free_entry() -- 2.20.1