Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6028032ybc; Wed, 27 Nov 2019 13:40:11 -0800 (PST) X-Google-Smtp-Source: APXvYqxWFmuYM5mNdX/XVG4HQIXqj4kv/GgPdpjXXQJWmk5AgsZU+KwIgTWJ2ZSpYHvhqc2kFX1Q X-Received: by 2002:a17:906:b2c7:: with SMTP id cf7mr50009662ejb.218.1574890811536; Wed, 27 Nov 2019 13:40:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574890811; cv=none; d=google.com; s=arc-20160816; b=a91iUHEkhH/t3htqwZiKS7VXM/Kp3oE5F6jlbF77UyKltKGlCSEDejJtuHkNmuwUb6 fNKFC4zVZZ4npPBchbA9CJclinSfQQVo6u9OuVGL1fiLYUCnWUH/3ikzb+3tCwROpp+D oGmEeA8vq7I3G/IqRkg6+qHCz4X0FaWAc7LsTi9B3KptCzwOPqFyrVPFo/9T4jsI6Ku4 +DDlVeaBKv9ygkc/RQ2cQMoslojWPp2v8HxXD1+QNtS1Agn6eV4I6Ier8jqMUvvPob6j pU+SILEsskqtFmJHRpFoRD+ZrTxrbNYoTPcx6qZPe5Tm3QBcRNRvZ3Qc2AYao2YQN8/T 4U6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=3hb8YbDt09X5HVe44SK9prgWwyFPwaLRj9ukLes2euQ=; b=jmrweFQ7fUHsHfZYurEeTZ7PpLFqvOQdqERtBwECpFPLCfpDbErSbE+3U3V2Nw2tTc hxEi1y+j04mhXmnB/CIKQGW1nigObaQ9YFyFbeWwO9gt/MGgDk0SMy8SsT00/oAiRyxD WiUtyOrAquARreemdaNZAXpCnwqXEntWkjtesM9HkJTSiHEoCxaHp7VwNwc/V3B9muMW 75sPp+z5HNU28i+Y/s3REZs+hLSFRVB7xNNhA8ROjLVlaGvhNYR32fYQ6/L1E2E48MM5 cmxTWk3I2V8rKJqqDnZtOG/dNEgnRVMSuNrKguT/UH5wsMPqdnAk29leTQFGh85ehSiq wxlw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GyWzdLYI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j30si1720321ejo.214.2019.11.27.13.39.47; Wed, 27 Nov 2019 13:40:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GyWzdLYI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728934AbfK0Uql (ORCPT + 99 others); Wed, 27 Nov 2019 15:46:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:58754 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729909AbfK0Uqj (ORCPT ); Wed, 27 Nov 2019 15:46:39 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C1D212166E; Wed, 27 Nov 2019 20:46:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574887599; bh=aJtFH0CzECT2feA/hIGxX4skKXjsT+Xn0WFyS4eiy04=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GyWzdLYI7wXZFKgPoSNvHg4x15/zmHxttcQkcoEo3rwVAB45bRG4g2OUzoyIIyHyU xuFxKgQBdT1vsXcynHIGK6HrcQc9/GFrvVZ9c52LOnp5u31zCcaREIkV/6X3dTMjmd 4DW6RH6jRkZPjaQnZ3q0Rlow2E3W2yZUMXc+pLfU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Roi Dayan , Vlad Buslov , Saeed Mahameed Subject: [PATCH 4.14 004/211] net/mlx5e: Fix set vf link state error flow Date: Wed, 27 Nov 2019 21:28:57 +0100 Message-Id: <20191127203049.881825779@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203049.431810767@linuxfoundation.org> References: <20191127203049.431810767@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Roi Dayan [ Upstream commit 751021218f7e66ee9bbaa2be23056e447cd75ec4 ] Before this commit the ndo always returned success. Fix that. Fixes: 1ab2068a4c66 ("net/mlx5: Implement vports admin state backup/restore") Signed-off-by: Roi Dayan Reviewed-by: Vlad Buslov Signed-off-by: Saeed Mahameed Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c @@ -1783,7 +1783,7 @@ int mlx5_eswitch_set_vport_state(struct unlock: mutex_unlock(&esw->state_lock); - return 0; + return err; } int mlx5_eswitch_get_vport_config(struct mlx5_eswitch *esw,