Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6028224ybc; Wed, 27 Nov 2019 13:40:25 -0800 (PST) X-Google-Smtp-Source: APXvYqxohJtKSUcNrjsFsA/tb9g1fpwB9lEc8iK+HPkHUAv766J6DygVFW55mqMKEb/oO4/+hAd+ X-Received: by 2002:aa7:d44a:: with SMTP id q10mr488704edr.45.1574890825459; Wed, 27 Nov 2019 13:40:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574890825; cv=none; d=google.com; s=arc-20160816; b=fnO1kaj8gU9Bpo6Vv+x2nHgTugus9+ysT1JIIosK565a2x1axaopKcotfifibyyeX5 SaMqrhidfgqrDSoFqCmSPCXIqZ/4Lv7TZIigyUQozoqonPhw/2XFtkwCLJsU07Zg7RpZ qLhAP1ikYq/WGujdNNbuzoxZWhpC8BGPccYHX3OsqeIC1/ToQWu3EByXuo9yU6hnXSep s0wknE3Q2eSmZH9Bl4oBuC5xKgJUoPvj5GkJsX0UWIrPIOG+vaXT1g0YFLzAb1EvVvKc eNlPIoyq/pSp5nNOrAOOlhuQ/NkbRbB4ePpMXh+m3MW004VIRIPED9dVQN+/somsRAwZ 7ZXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YqXKr6f75pywcoSq8QxcCSQyKZUNRoLoh+tP6QKoB0s=; b=Sat4DwtCsV7T7/BFBAp6EDQtmAiAMYrJsjactsWI5sWPBcvv++ZKpzidcTL0CAZbzl OyoFOLp0kY9ixajg/11eyqh1hmIYtgt8xTdzQjHEiWWltNLp9FgqfnyagnFZkUGqB6SO 54akuOmXmK8JfiWRIwAti8oO7pFnAaham/hMHqg+xHW3Xsb3o+M5gBgUuhmqh2TYP+9m WJzFYL8/J6AySMo9senw7Eh9UdZSYdKBz0Pa8SaaPI5K+gYjz2Dx1RbDLkieUT73tLxr iqW7nspZGViWb338xGu2KjMg46pWAU2UGLraXynQJpcSwVmuz6l76+CdFAquBa6vXF6L I2Sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hwcm+NZM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g6si13157395edk.210.2019.11.27.13.40.02; Wed, 27 Nov 2019 13:40:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hwcm+NZM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730840AbfK0Vfu (ORCPT + 99 others); Wed, 27 Nov 2019 16:35:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:34428 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728003AbfK0Us6 (ORCPT ); Wed, 27 Nov 2019 15:48:58 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BD0B9217C3; Wed, 27 Nov 2019 20:48:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574887738; bh=VE3R3aiHUNjnBCnPqcjznNJBj+dctkdav0mNL+LP5Y0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hwcm+NZMUCgWTk0Y/Ad6AJ/QnuJP1DJXayBewyL8lCeGCvLJmMSXJXC2pQE7CdIpD dtmFTcAwmoMR3KRXhLNWgkeLs7L6FmVXB7YgEqwFjP/XIPBOIzBVmeCBtTv+UDFfJj 0dY2w7SlcoHlHQK/gRTGc8WnopmSvRj1nbm/bOa4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Yan, Zheng" , Jeff Layton , Ilya Dryomov , Sasha Levin Subject: [PATCH 4.14 075/211] ceph: fix dentry leak in ceph_readdir_prepopulate Date: Wed, 27 Nov 2019 21:30:08 +0100 Message-Id: <20191127203100.909688424@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203049.431810767@linuxfoundation.org> References: <20191127203049.431810767@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yan, Zheng [ Upstream commit c58f450bd61511d897efc2ea472c69630635b557 ] Signed-off-by: "Yan, Zheng" Reviewed-by: Jeff Layton Signed-off-by: Ilya Dryomov Signed-off-by: Sasha Levin --- fs/ceph/inode.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c index 3818027c12f5a..5999d806de788 100644 --- a/fs/ceph/inode.c +++ b/fs/ceph/inode.c @@ -1631,7 +1631,6 @@ int ceph_readdir_prepopulate(struct ceph_mds_request *req, if (IS_ERR(realdn)) { err = PTR_ERR(realdn); d_drop(dn); - dn = NULL; goto next_item; } dn = realdn; -- 2.20.1