Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6028969ybc; Wed, 27 Nov 2019 13:41:22 -0800 (PST) X-Google-Smtp-Source: APXvYqw0MFZmhDrIgXClL9i1HO1/Z+C22ag1+1P72Pt6fXdpkzuGEYZy5u4oA26voMX3tQNg8g4s X-Received: by 2002:a05:6402:611:: with SMTP id n17mr34442112edv.143.1574890882534; Wed, 27 Nov 2019 13:41:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574890882; cv=none; d=google.com; s=arc-20160816; b=lHd0Kv1R91lY/Cd93lOdmHD80hw/YU3q/ze8QsKtzXHKGg0bl7ERc2HnBMO+IhgCvM mAqGuy+A0VAW2agpyRcEIAcQqNg3Mbhpnl5lVZ5pT+VtqqOcJOFTPKLCh3rSDhwX+f8f z2zRx+BnUEj4If44IIH+znAjiLKEwqIohCV2KGjkPJHXfvA9jBkRRnToqpcFo8btxmbN Jpx+/acm8SnCLlJdiUOgpUNKP5z71l1l0D9VnrGLmtbshf1X+Ao+Lhwcmum4sXJPwTax vQ9oCSlzSjQOxniTFbszUKHO9JH133Zfe78edx1JioBCoIYaPIf/cGDZSu8rIFIyb4sw 3S2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=NKmVMQ15EBlpxaQVVIo96BfJP9Aeeso6upJecFbmvXM=; b=iUHEmIJYA0qIrz+Z9npVfXoh+YOvim7BM8IdHZIDRSl8xdIF3KVQ8DXkFL9XSLN+XC Q1NZ8VKVI8l3Tj31s0E3+OCja3qcz2MP4dsA6Ds2K2JUH+sufkSlT1CpbSi+UWzd6Iot DklE14uCrtb+9cSPFnOBTs+CLcb/Gv2akgfqc89WhL3Cli61pxjRSkjYSJa4cKpWl8PU An5tKziZkNOSf6LrwDsjTrLiQGl5y7tpO3jIydkG4XXjRmIgqucNpAXsrV0F3OOzMFF6 uwq1gLHMy8IKOxlm3Sw87X8iazvJp8AUIonfqqMv50rXxQPHLsQUWzstj6ztcpdNnQJs GdAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iliAc86Y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o21si10296561ejj.188.2019.11.27.13.40.59; Wed, 27 Nov 2019 13:41:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iliAc86Y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729942AbfK0Vin (ORCPT + 99 others); Wed, 27 Nov 2019 16:38:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:55636 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728220AbfK0UpM (ORCPT ); Wed, 27 Nov 2019 15:45:12 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 895A0217BC; Wed, 27 Nov 2019 20:45:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574887512; bh=5W9Egi4zKehIZf+zXK06b5qupqNkKPfecanbW4wj9z8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iliAc86YCcibNHQGOzatS33tSIHBw8ojHVtYxsX1JV9+b+XZxMRqJFynypve8Mbew HIEMvf4cePt4nictKsYNvdbXd18TQY5yJbiKKCoBLiyREidw98doVwZaJd5UdRe4ML xAtUXFF/2dZ8faLA+8Z6OADxDG0Ap9Q1ic+9dImA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hewenliang Subject: [PATCH 4.9 139/151] usbip: tools: fix fd leakage in the function of read_attr_usbip_status Date: Wed, 27 Nov 2019 21:32:02 +0100 Message-Id: <20191127203046.982958231@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203000.773542911@linuxfoundation.org> References: <20191127203000.773542911@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hewenliang commit 26a4d4c00f85cb844dd11dd35e848b079c2f5e8f upstream. We should close the fd before the return of read_attr_usbip_status. Fixes: 3391ba0e2792 ("usbip: tools: Extract generic code to be shared with vudc backend") Signed-off-by: Hewenliang Cc: stable Link: https://lore.kernel.org/r/20191025043515.20053-1-hewenliang4@huawei.com Signed-off-by: Greg Kroah-Hartman --- tools/usb/usbip/libsrc/usbip_host_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/tools/usb/usbip/libsrc/usbip_host_common.c +++ b/tools/usb/usbip/libsrc/usbip_host_common.c @@ -69,7 +69,7 @@ static int32_t read_attr_usbip_status(st } value = atoi(status); - + close(fd); return value; }