Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6029376ybc; Wed, 27 Nov 2019 13:41:54 -0800 (PST) X-Google-Smtp-Source: APXvYqzgxNF7Ro+oTD1e0BKR3l3X5ee0Y2X4ignMjWtCsQfusLAY/eLuu+tIdo1M+P/rvuTwPj9C X-Received: by 2002:a05:6402:799:: with SMTP id d25mr11621167edy.221.1574890914860; Wed, 27 Nov 2019 13:41:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574890914; cv=none; d=google.com; s=arc-20160816; b=c165y3nrln8mU7GVQP5aCQYP0sK6C4rVtOI30V5A3Yl23yVojz4TiWne7wwiW1/J4i rEZWZcA6fw4AS+y3W/drR5iG5wUnkxq/6v5LKp7JcTL7j6fKwHJY/9qChHCB07UvggUh dW2B2XkgYgigz8tOTe89eaZfNstb2IqUSCF838sBsX8eGc3HP/wm2C+MaaOw8ofP173q BhY96pqJ+lO8PDdOwjFCp60t+VFSyfXres5ZJ+292iuqUGDm+q1D+VTZu9IiRtIAVEcg aXy57A4hQzdVPDz/fxg//KRBH7w2EFcK8PDgBcf+Xhw1WaegKoxaDXyqII/aKZcmOpGe qceA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fJigTN52L8ga1nOX28uHZrVRxZ6k8jfmfprxzzwaG3s=; b=ymWSRHYkys2Zwg4ChKo2o+Ht+fF/o1g16qsRRKkgH7efFnHHyQ/YvcpAD7sM8jNGuU qvweIva5fV8jOJdUs791YE917liW/TelnI63nNctN148CdZRtEyt5TzxEv1EhIv81n/h +McaUY//Ji16FNeb9SixHF/pSmW8Nhi7mk/GV2X9Ow+yMXQcFNwW50LVk4Y8ndDlnRsw /epjbNS1V997LQWDIDvgLlt6zkpS4UbbGGQFMiuLfqxDRYOG79FD7XR6vMgM9prI4Pyt pwS/VL6rjBcY1LZ69Yz+iDnIYJMsWvOQEjHbl2j+j60mC7mdtXkqFZS75LDR5efTVAl3 n3Vg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ge01y1Q+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 8si11144865edz.90.2019.11.27.13.41.30; Wed, 27 Nov 2019 13:41:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ge01y1Q+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729763AbfK0Upi (ORCPT + 99 others); Wed, 27 Nov 2019 15:45:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:56632 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729760AbfK0Upg (ORCPT ); Wed, 27 Nov 2019 15:45:36 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 696D721741; Wed, 27 Nov 2019 20:45:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574887535; bh=qt2ZaBJBkqKDo6O0kCiyXnG1cMLezHLkJkx66ql/bfQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ge01y1Q+6ZkgB+AfVwvuwJXuHC7Mhy7GPqJL+o2J94niNCOwij27DtVc6Wag7auYZ c8RpIo287r2d/rUzkHPkPfiKCGkLwLXTNHNb9R/K3ZDkjXgAs9f1yqT3YxagLUgbTO OHlFJLplPd1nsPXx9Gl1mcMblH8+ZX2GCYBm907o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Rajkumar Manoharan , "John W. Linville" , Kalle Valo , "David S. Miller" , Denis Efremov Subject: [PATCH 4.9 112/151] ath9k_hw: fix uninitialized variable data Date: Wed, 27 Nov 2019 21:31:35 +0100 Message-Id: <20191127203043.201695755@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203000.773542911@linuxfoundation.org> References: <20191127203000.773542911@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Denis Efremov commit 80e84f36412e0c5172447b6947068dca0d04ee82 upstream. Currently, data variable in ar9003_hw_thermo_cal_apply() could be uninitialized if ar9300_otp_read_word() will fail to read the value. Initialize data variable with 0 to prevent an undefined behavior. This will be enough to handle error case when ar9300_otp_read_word() fails. Fixes: 80fe43f2bbd5 ("ath9k_hw: Read and configure thermocal for AR9462") Cc: Rajkumar Manoharan Cc: John W. Linville Cc: Kalle Valo Cc: "David S. Miller" Cc: stable@vger.kernel.org Signed-off-by: Denis Efremov Signed-off-by: Kalle Valo Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c +++ b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c @@ -4115,7 +4115,7 @@ static void ar9003_hw_thermometer_apply( static void ar9003_hw_thermo_cal_apply(struct ath_hw *ah) { - u32 data, ko, kg; + u32 data = 0, ko, kg; if (!AR_SREV_9462_20_OR_LATER(ah)) return;