Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6029885ybc; Wed, 27 Nov 2019 13:42:34 -0800 (PST) X-Google-Smtp-Source: APXvYqyYpPfhfDfAOwHf8WUFlwWGrD9tVKj3ELMbsJNIS5zY8W8HNgYVqd6rV/iamTi6Qu/6oGNF X-Received: by 2002:a17:906:f2c9:: with SMTP id gz9mr26549297ejb.171.1574890954249; Wed, 27 Nov 2019 13:42:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574890954; cv=none; d=google.com; s=arc-20160816; b=RUfSQzLzWtwURVpS+kBx8nYatZeePQdXJtcV0dtVMj6NeWDdBfis8Bi77CZXmU78WZ L5AyFe9m0Iblh/7t05jqR1aDMTcu934j0T4+b/GD2C9H0pIt+Sw/YiiPJprk3xHPHhtR lauveuF2yPGrnT6sgy5sH5vl2TmJKOYeNHcb6SeJL9vykUeF/dbQfGTcMryAxoV653Gf k7nTrPN16pHJo+CK+gxhp47fte/0dsmCdKNtsDdT5maVkNI35kgUnMESjZdqamoQSA99 c24ssWlLoytlzH7wpC7nQeo27YO0XviYglQARSnw76zNitynEQuQ1T534l5LgvWCz01R ToMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=9siBK0oN85H4g/579veeQcN4rB6/EiX4znT7koi8qQc=; b=NbwnE/RuvuLTn8eVGgMoflK4/Zq40dEvX3YiM6MRGXcYznGyMuagx65+yZN3FYo4OI sQvAhj7lns38H+/T2ZTa+TPAOJXRYDpUB2/jqhl/2+KMgUxi6CMdh5IuwWRUWH59ka9u o67G8iNyG3TPNjoluRV6OM5MYomluO7inEAsLSXZfomcFCYjZV+k0JKf0/VMdiBlAVYO j9QzoOAIqQ/GL0nNG7KOc9fxrtnV3JGMl9cL8j6VkDEirkdmol9wGijkqoyr7Gq+gPYx V7TlGUlTMUBOX7nNH0AD5z6tj9vvxbKdCXbwttf2Zw2XrW5wN4XNG8F1pyUX14+Vz/F0 hHxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ey9d9Qb6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g10si10167156ejh.271.2019.11.27.13.42.10; Wed, 27 Nov 2019 13:42:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ey9d9Qb6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729463AbfK0VkB (ORCPT + 99 others); Wed, 27 Nov 2019 16:40:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:51018 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729444AbfK0UnW (ORCPT ); Wed, 27 Nov 2019 15:43:22 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0447E21741; Wed, 27 Nov 2019 20:43:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574887402; bh=I/rpMijM4yMNwtU+bEGKgo77Et0G0y1kjG99Mgh7nHg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ey9d9Qb6w2XC7DC+D9LDSsIos0DvAigudVUbObE9Y+Hb2gF7Qo4u4tc6grRsABW7a 5fejqfgaSx/vpPg+sV9qK6Z3km17KKduE+54ynKZTeCXSqjNp8/u6ItgyfiYh+R/Co MQrK+RIG6jgJ43N+pGzW7AECT3D+6EzOdsC77PXg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Suganath Prabu , Bjorn Helgaas , Andy Shevchenko , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.9 096/151] scsi: mpt3sas: Fix driver modifying persistent data in Manufacturing page11 Date: Wed, 27 Nov 2019 21:31:19 +0100 Message-Id: <20191127203038.698696986@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203000.773542911@linuxfoundation.org> References: <20191127203000.773542911@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Suganath Prabu [ Upstream commit 97f35194093362a63b33caba2485521ddabe2c95 ] Currently driver is modifying both current & NVRAM/persistent data in Manufacturing page11. Driver should change only current copy of Manufacturing page11. It should not modify the persistent data. So removed the section of code where driver is modifying the persistent data of Manufacturing page11. Signed-off-by: Suganath Prabu Reviewed-by: Bjorn Helgaas Reviewed-by: Andy Shevchenko Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/mpt3sas/mpt3sas_config.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_config.c b/drivers/scsi/mpt3sas/mpt3sas_config.c index cebfd734fd769..a9fef0cd382bd 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_config.c +++ b/drivers/scsi/mpt3sas/mpt3sas_config.c @@ -674,10 +674,6 @@ mpt3sas_config_set_manufacturing_pg11(struct MPT3SAS_ADAPTER *ioc, r = _config_request(ioc, &mpi_request, mpi_reply, MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, config_page, sizeof(*config_page)); - mpi_request.Action = MPI2_CONFIG_ACTION_PAGE_WRITE_NVRAM; - r = _config_request(ioc, &mpi_request, mpi_reply, - MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, config_page, - sizeof(*config_page)); out: return r; } -- 2.20.1