Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6030084ybc; Wed, 27 Nov 2019 13:42:49 -0800 (PST) X-Google-Smtp-Source: APXvYqwWznj35Vqyk5MW/eic4bSaYo2k5H0ax5nMEmRc2rAHqWV3Uv1OAgPmCwvNZLUtJ3LijEjI X-Received: by 2002:a17:906:2ad8:: with SMTP id m24mr3416955eje.180.1574890969664; Wed, 27 Nov 2019 13:42:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574890969; cv=none; d=google.com; s=arc-20160816; b=FVUdxUymzVgHG/BCriCusSK/zriPPb6RwJfm4tkmmQV6xMPetlwfJoN+PZthcpzopl s5gr0zDz9MjGACSEON3ivTykPbzwMDhirx8N/TJQAMcn7V4r2FhF+WJot9pbB6CPM7MI m6SQEOFkz1kMuV7j0993KyaJhPNFpOcQcDDo4gHIU3Vuurrs1L/Y3thOHF3Dy+xGC14/ EXJ26pfDy7dg+/KzmZdOkxw7wbu/bXqjY2eMy+7P6jd88UQhvg/7o3OX7GRPdiIFZg41 HpzomCXB5IjIf04uXLKg7I/a1HSZAi6igqxEYm9figkrL9ixQP8Sc1fGn5wDGYpaAxZp Bt+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6mKBylIedi8Y7u86B2soLTKqy/F0EbA16cnMCiaBv3A=; b=P2mjcTXhkQP4CseWh8jQHAigBoC5zowsejhshrMbzP01wVe3WoE+ZKiwb+PB15JRA8 e0+Xj4kyWYt5cjNLnqs5BzPxwc8anKn+T9Fe4N6mTYVdUak9hh47ykGBJ3Xb+dADoDqY gHmjW92tk9t4bOUrG9fYrnTifRS01bCIb57zNlpehCW84fLLPhQACPA/SlKZT1pagsRQ ER+yrbV2qAG4vfV0A2yeOV3SBSo8pTd+ZLHzhtlBpYTBtMaaXt8/A39TSyZY83z5458H PnLGHlAne6clyp/uRJg3AYIPoK5OFKI1KV6UD1NAgNnHxjGmQH2HyRf7hoQi5YBluGKP OL2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LSi5PPV6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a14si11758604edm.344.2019.11.27.13.42.26; Wed, 27 Nov 2019 13:42:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LSi5PPV6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729790AbfK0Upv (ORCPT + 99 others); Wed, 27 Nov 2019 15:45:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:57088 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728185AbfK0Upt (ORCPT ); Wed, 27 Nov 2019 15:45:49 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8C9B22178F; Wed, 27 Nov 2019 20:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574887549; bh=E7bp0BOM3t1qTKZFsIcbtokzuEIIenJD4UwrpLkgBBE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LSi5PPV6g/7TT52jlO+XxvYZ9tt5xvNBPpFQFBN3BACLHqkTQp0+q+91RGXdqyrNv NZmnQJ5kLElLjQnlxnyAQeuCl5FVVKO62ugPAYncVv8vgP0kOuH2Qjmgk/wVwncBck cPBdgLbM1SwOE1AL85Jce4pHidva/s1Gw30WpAHU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bart Van Assche , Mike Snitzer , Lee Jones Subject: [PATCH 4.9 113/151] dm: use blk_set_queue_dying() in __dm_destroy() Date: Wed, 27 Nov 2019 21:31:36 +0100 Message-Id: <20191127203043.434613352@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203000.773542911@linuxfoundation.org> References: <20191127203000.773542911@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bart Van Assche commit 2e91c3694181dc500faffec16c5aaa0ac5e15449 upstream. After QUEUE_FLAG_DYING has been set any code that is waiting in get_request() should be woken up. But to get this behaviour blk_set_queue_dying() must be used instead of only setting QUEUE_FLAG_DYING. Signed-off-by: Bart Van Assche Signed-off-by: Mike Snitzer Signed-off-by: Lee Jones Signed-off-by: Greg Kroah-Hartman --- drivers/md/dm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/drivers/md/dm.c +++ b/drivers/md/dm.c @@ -1946,9 +1946,7 @@ static void __dm_destroy(struct mapped_d set_bit(DMF_FREEING, &md->flags); spin_unlock(&_minor_lock); - spin_lock_irq(q->queue_lock); - queue_flag_set(QUEUE_FLAG_DYING, q); - spin_unlock_irq(q->queue_lock); + blk_set_queue_dying(q); if (dm_request_based(md) && md->kworker_task) kthread_flush_worker(&md->kworker);