Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6035395ybc; Wed, 27 Nov 2019 13:49:31 -0800 (PST) X-Google-Smtp-Source: APXvYqyAd5VUlN9NBa15wjmwqEY8hvex1noL+hNsPaz0HsKGiJptRd7Z97zoHspV42xFkQWSeWho X-Received: by 2002:a05:6402:544:: with SMTP id i4mr30976806edx.175.1574891371260; Wed, 27 Nov 2019 13:49:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574891371; cv=none; d=google.com; s=arc-20160816; b=rKBZzBJWnhU4cCq3LeE6VtJM5GGE2fXG0VmnyIGOY22ck49G0Sp/IBY5QRJXIxBlCp 9rP8oNa/ZLBIJCuwvSoETOzX5xboCC4SsyqX1xeuOUDdZt/q6fk5/EqScVfYFdrQzY8c GCSvzwgsuo3c56w+5eAeKDRc3Xtjfjqye3ShQd5xKInXqW6B8iqYvaEvGzyFuUw4hrK6 B3/S2Ac8FZ+VZbLs4usOwhJSnMMznSublv7kESzOWQWwccjXHGJ56YBnXSVLjiEquK12 Wa/pRGTV2pZC6m6FcFI+/0cvhllq5DuAzINMjYGFNBJKHSDBSm3/go2ruCciKAZhXBNv AWSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=n1Pm3ausCCAqSuk5ygw0ls6QLPP7xcKlOYCqMfRPOAg=; b=QMyDwRr/CfVlCZcLetbjWoIAXAB+ovcpBCONTs4lB9Oe1jk8/F+KtM8r9CV+QaFgHU 7Aee2b2p8YpXNfPClI2gVxXRPNyAnPlmSeAx4Ntd0cm4VINST21pFZpzxF6rTkQg320v /9ixnBrKTIoskO3+ZrVap5bOaGIDL859ivrKiUqfy3WLvTcR2iDLyyuKhC8W7SDcQkKY oidFfaXL8IpwbMCyCvJrwHht0BQwnV1NhDbpQ6t4J8xi4/lKyw6pJnPZmOo8zS1oh+H/ if+mhanGeN6/iGIgdJvpXiqcubfCN/0Wg++AZ7PyBYtHj1Awcw2a27nw7YZrtaFRsKyG RsBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OY2U8Rd0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g21si207829ejr.195.2019.11.27.13.49.08; Wed, 27 Nov 2019 13:49:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OY2U8Rd0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727649AbfK0Vpn (ORCPT + 99 others); Wed, 27 Nov 2019 16:45:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:36302 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727829AbfK0UfR (ORCPT ); Wed, 27 Nov 2019 15:35:17 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2A5E72154A; Wed, 27 Nov 2019 20:35:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574886916; bh=H6bctPRfq8XqJuzYNECQWMiThWRjYOGOSX2ux+jZzI4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OY2U8Rd0Plq9Pl8zWWOaiNR+tfjOcTvXsgsaXBh70VNiFnA4vPHTEW+ovEs5u87Id WESrRGGhystIPcIQVu92FHzPI3QE5N1gORcXJo2icM3BpugPe8yZHtZ8L9OgES+2CW HiJdCOEN+u03aSvITmGLWlKP5y0Z029Des/5tcNY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kyeongdon Kim , "David S. Miller" , Sasha Levin Subject: [PATCH 4.4 042/132] net: fix warning in af_unix Date: Wed, 27 Nov 2019 21:30:33 +0100 Message-Id: <20191127202937.623909833@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127202857.270233486@linuxfoundation.org> References: <20191127202857.270233486@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kyeongdon Kim [ Upstream commit 33c4368ee2589c165aebd8d388cbd91e9adb9688 ] This fixes the "'hash' may be used uninitialized in this function" net/unix/af_unix.c:1041:20: warning: 'hash' may be used uninitialized in this function [-Wmaybe-uninitialized] addr->hash = hash ^ sk->sk_type; Signed-off-by: Kyeongdon Kim Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/unix/af_unix.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index b1a72615fdc30..b5e2ef242efe7 100644 --- a/net/unix/af_unix.c +++ b/net/unix/af_unix.c @@ -224,6 +224,8 @@ static inline void unix_release_addr(struct unix_address *addr) static int unix_mkname(struct sockaddr_un *sunaddr, int len, unsigned int *hashp) { + *hashp = 0; + if (len <= sizeof(short) || len > sizeof(*sunaddr)) return -EINVAL; if (!sunaddr || sunaddr->sun_family != AF_UNIX) -- 2.20.1