Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6040755ybc; Wed, 27 Nov 2019 13:57:03 -0800 (PST) X-Google-Smtp-Source: APXvYqw/LINcsJbcVrbqgDxgkdaae9A2wn70HJzliAZp5rskapy4bUsuF9lbWNSVgUBYNsT/o22V X-Received: by 2002:a17:906:5049:: with SMTP id e9mr50999590ejk.53.1574891823533; Wed, 27 Nov 2019 13:57:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574891823; cv=none; d=google.com; s=arc-20160816; b=s2j5CYnA7M6/dLpKdS9vh02ffPituWjp8Zemb227AzFp3Hg3hoA438xLlW5mCmHV8j uVhiaQ7Ievw+/cYv2l3RI+Zng8tqIWxjfAY9kkXsEpQa1XasE+KLg+mhVIK2b1fUiTrl dQLLrzu4yB8HY6b2tGs2eczeLT+fcBoTREqHkNE4B91I2sCNT7L+kqTL9hKEOhh59dyg 9xHHJjsRoZeWxMqEtJvBITHsNJ660+S2iecfHcuwYKaJneoww6y8lPUyTrooh9NvsXq+ XnCWYNmb+TXlGj6ertqZPHBVm6noNRBES82PJxyEOOl+zb0NnVhvv8PY39Tbnsaqe2ms cMJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=S7sSrpO1yWbZ4TlmFC/AvJyU9OBxFyKuHJdD3qXJvhM=; b=I7KZUZ2cp/iNAvX8y6CnlBZ7tHcrfAybZcuygMuJgJ6/17TKeG9OZ+wxxlg08ki7TI PnILZAYiTneX/n/01VQGWnoBsU2dm7+sMsBHfUgUnhirtFhPAGu+Sue4fx+doesTjhwS 25oKli5bGphgXTFXPfu+eO+t74GEAvPgbPgdga/nFjxwUO9COAQrJK1td6WdlZ4oSl6R N0vm09yJZyR4NmmoUjq97QRq739/Ocne/PG1pLxN3jCqY9T7FkXYlcvuZXDMxP7U5Hvr lT6zY2ZacuJFQPFYz5sqMAvQBjsHHF9v237c0xU0D09v1A1O2A0B8HVGWtcSGMQmV8Dv D3ow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yS5eNp9e; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h1si10860027edn.404.2019.11.27.13.56.40; Wed, 27 Nov 2019 13:57:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yS5eNp9e; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727156AbfK0Udu (ORCPT + 99 others); Wed, 27 Nov 2019 15:33:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:33800 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727010AbfK0Udu (ORCPT ); Wed, 27 Nov 2019 15:33:50 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 93BBF207DD; Wed, 27 Nov 2019 20:33:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574886828; bh=sph2R7pishUgeqOmCYzrLpe0s/ZA4/j+OqsawcNw1Uw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yS5eNp9eTl6SH8mOXb7dSMlSwfPsl7Cps2If09fqcWOJer1M7HQfJLFdiZnEt2S4h cyy5a8GupBu5Pp/EW6WPyz7NMdvSViM+LVDG1t6lmnJF3v717Sk0gnwJAZMeakMNZO 8jTVOau2IrdblK3sZB9+1toq56Lnkp2FTKTdjzB4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Luigi Rizzo , Tariq Toukan Subject: [PATCH 4.4 001/132] net/mlx4_en: fix mlx4 ethtool -N insertion Date: Wed, 27 Nov 2019 21:29:52 +0100 Message-Id: <20191127202858.337504458@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127202857.270233486@linuxfoundation.org> References: <20191127202857.270233486@linuxfoundation.org> User-Agent: quilt/0.66 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Luigi Rizzo [ Upstream commit 34e59836565e36fade1464e054a3551c1a0364be ] ethtool expects ETHTOOL_GRXCLSRLALL to set ethtool_rxnfc->data with the total number of entries in the rx classifier table. Surprisingly, mlx4 is missing this part (in principle ethtool could still move forward and try the insert). Tested: compiled and run command: phh13:~# ethtool -N eth1 flow-type udp4 queue 4 Added rule with ID 255 Signed-off-by: Luigi Rizzo Reviewed-by: Tariq Toukan Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c @@ -1667,6 +1667,7 @@ static int mlx4_en_get_rxnfc(struct net_ err = mlx4_en_get_flow(dev, cmd, cmd->fs.location); break; case ETHTOOL_GRXCLSRLALL: + cmd->data = MAX_NUM_OF_FS_RULES; while ((!err || err == -ENOENT) && priority < cmd->rule_cnt) { err = mlx4_en_get_flow(dev, cmd, i); if (!err)