Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6042135ybc; Wed, 27 Nov 2019 13:59:02 -0800 (PST) X-Google-Smtp-Source: APXvYqwoBtDu0gxd8+wKWLGuoWIxVG/xYqwXuenJrzTFVVGOF0e+1tVFZuVc3cl5MkbgfUMJsEYM X-Received: by 2002:a17:906:27cc:: with SMTP id k12mr52461982ejc.181.1574891942844; Wed, 27 Nov 2019 13:59:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574891942; cv=none; d=google.com; s=arc-20160816; b=BRK+6Fy2kn67cNuaYjgAxph3twzf9fSvk3gzsv1HpyVFkmOAEZTg/aaiF3kh4OCH2b s4jSRcr1+km8ExisSMuTEeQiK3gvhpZHiuxqOscIU5naGa7AZvcPi29cjkK+QWti6HTF 85x82LJE3t34CF7LEMOP/xEZU1L9zbFDtezQVBKAIuEvVk1UTU+qowXXm5NjbapRJSqy rv9+XtCle6Is7fY3H0e60dMed1BC9ttYauF1fW+owcz/WPswLSMCMHJJTtQTS8nBR6Fn 0hXLOxwBzpzNAJt/mG4zor1yxl6Gn5S1koZTjFPsFyHckE/1F1QI+3tsD831MuLm8hA6 CSWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=uMTsIBpyJMhbm26kSFAWWIWR9QAAAt4EUNrP68DMuO8=; b=bHF0MYZtUfyvp0jaBtrnfR0XnLrs+G8yyDIeN6efAs6sEoJiNcogKBtTBvRxoXGbB0 ZSyoPoVV9qsqe2y1ndS1r5sY8a7rqwU9Mg3FYCd1XSsyeDxAONcO7hyd+FS9MwB5IyS+ +SdfEgVSjoL+fl4+eHJBPQh1jw0NHrsJ5F6tc1X7+I7RZgQvOzsOYfWp+NAn0wSlgqPW Pdpc32AiPEZ7tTXdmHdQYvfZDV2QovwHedq/VEaokZfksr303Rab2nAc9lKZBRPgHujE Yp6Cv5En5Pbf2k9gtgpqM2K5EW26zB2QN8PZMrcLY+rHaNQhlTI0NPoljN6/+LKu5MKP Kckg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xYxnYDWj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z12si10904340edx.47.2019.11.27.13.58.37; Wed, 27 Nov 2019 13:59:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xYxnYDWj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732432AbfK0VLI (ORCPT + 99 others); Wed, 27 Nov 2019 16:11:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:38870 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733097AbfK0VK6 (ORCPT ); Wed, 27 Nov 2019 16:10:58 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1F79D21775; Wed, 27 Nov 2019 21:10:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574889058; bh=sDzY29B+fqQFh7q2y2OrABZsUQVM1JjkS1wKHq8bNn0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xYxnYDWjnBfWFWdyHmz2s0AysIonH5CKJ/fOazP9b/qHocvdfnBhhtyo70BqV5H2y orusAH0NeKjmGEPT5rU7IJP7jj2SWeLkoUjgQZysUHWcc96Slz5Du9fFDhlYC7fhZ7 1xr6qKA/iUURddKTxasGPWcG4YX4EX6LloYtuFpc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+a36ab65c6653d7ccdd62@syzkaller.appspotmail.com, Dan Carpenter , Takashi Iwai Subject: [PATCH 5.3 67/95] ALSA: usb-audio: Fix NULL dereference at parsing BADD Date: Wed, 27 Nov 2019 21:32:24 +0100 Message-Id: <20191127202932.253077014@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127202845.651587549@linuxfoundation.org> References: <20191127202845.651587549@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Takashi Iwai commit 9435f2bb66874a0c4dd25e7c978957a7ca2c93b1 upstream. snd_usb_mixer_controls_badd() that parses UAC3 BADD profiles misses a NULL check for the given interfaces. When a malformed USB descriptor is passed, this may lead to an Oops, as spotted by syzkaller. Skip the iteration if the interface doesn't exist for avoiding the crash. Fixes: 17156f23e93c ("ALSA: usb: add UAC3 BADD profiles support") Reported-by: syzbot+a36ab65c6653d7ccdd62@syzkaller.appspotmail.com Suggested-by: Dan Carpenter Cc: Link: https://lore.kernel.org/r/20191122112840.24797-1-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/usb/mixer.c | 3 +++ 1 file changed, 3 insertions(+) --- a/sound/usb/mixer.c +++ b/sound/usb/mixer.c @@ -2930,6 +2930,9 @@ static int snd_usb_mixer_controls_badd(s continue; iface = usb_ifnum_to_if(dev, intf); + if (!iface) + continue; + num = iface->num_altsetting; if (num < 2)