Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191127054358.GA59549@LGEARND20B15> <46dfe877-4f32-b763-429f-7af3a83828f0@cogentembedded.com>
 <CADLLry4jOr1S7YhdN5saRCXSnjTt_J=TB+sm=CjbcW9NJ4V7Pg@mail.gmail.com> <0101016ead12c253-18d4624e-98eb-4252-ba3a-fabf74d831f2-000000@us-west-2.amazonses.com>
In-Reply-To: <0101016ead12c253-18d4624e-98eb-4252-ba3a-fabf74d831f2-000000@us-west-2.amazonses.com>
From:   Austin Kim <austindh.kim@gmail.com>
Date:   Thu, 28 Nov 2019 07:21:40 +0900
Message-ID: <CADLLry7Dcdz9bcfK2BQY3UcYVEL7z+cYqMjab916B8fkfDqHFA@mail.gmail.com>
Subject: Re: [PATCH] brcmsmac: Remove always false 'channel < 0' statement
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
        arend.vanspriel@broadcom.com, franky.lin@broadcom.com,
        hante.meuleman@broadcom.com, chi-hsien.lin@cypress.com,
        wright.feng@cypress.com, davem@davemloft.net,
        linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com,
        brcm80211-dev-list@cypress.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2019=EB=85=84 11=EC=9B=94 27=EC=9D=BC (=EC=88=98) =EC=98=A4=ED=9B=84 10:35,=
 Kalle Valo <kvalo@codeaurora.org>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> Austin Kim <austindh.kim@gmail.com> writes:
>
> > 2019=EB=85=84 11=EC=9B=94 27=EC=9D=BC (=EC=88=98) =EC=98=A4=ED=9B=84 7:=
48, Sergei Shtylyov
> > <sergei.shtylyov@cogentembedded.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=
=B1:
> >>
> >> On 27.11.2019 8:43, Austin Kim wrote:
> >>
> >> > As 'channel' is declared as u16, the following statement is always f=
alse.
> >> >     channel < 0
> >> >
> >> > So we can remove unnecessary 'always false' statement.
> >>
> >>     It's an expression, not a statement.
> >>
> >
> > According to below link, it is okay to use 'statement' in above case.
> > https://en.wikipedia.org/wiki/Statement_(computer_science)
>
> I don't have time to start arguing about this, and I'm no C language
> lawyer either, but all I say is that I agree with Sergei here.

Thanks for your opinion.
I will use 'expression' rather than 'statement' when I upstream
similar patch later.

>
> > Why don't you show your opition about patch rather than commit message?
>
> But this comment is not ok. Patch review (including commit logs) is the
> core principle of upstream development so you need to have an open mind
> for all comments, even the ones you don't like.

Oh! I Agreed.
If I were you, I would leave similar comment.

Thanks,
Austin Kim

>
> --
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpa=
tches