Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6121256ybc;
        Wed, 27 Nov 2019 15:29:14 -0800 (PST)
X-Google-Smtp-Source: APXvYqz3pNDjlRxh4lbzCU/LTHUBDsVG7xyz6VDKYbk3qknbMGwyTSOLdathvhR6eBGwdLsJdMgy
X-Received: by 2002:a17:906:32d3:: with SMTP id k19mr51617311ejk.75.1574897354599;
        Wed, 27 Nov 2019 15:29:14 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1574897354; cv=none;
        d=google.com; s=arc-20160816;
        b=od8FtaPfU8EV9LfbZGoEmmWpo3neDT3wEmEOnfezrjshPqhOgIf3ta0EAtGwWB1rKQ
         YmyjyYztthg2sly550rbh28oCHqCc/UgZJV66uapQQprebuV+RTcAfj5XaUCd95BogvE
         2LtGuhuC9yoWpcz3Vrw+6F634CS49ALbFrOHYSQQSHN0ZVZ1k+0RiYPa7XKO3utQJHQW
         KWH3eDXdMK3IM7nbFIYZgKjl4qLGRgj6NDnUo2k8j3hVpNVD18bgt0EEtXOrE2dkrGPl
         mTOJgJF71u1psOSGdPqJyz5nrmzQwKSZulbj+kxYH/XZGBG920bY4+41/gpWIFb8KYNK
         m1+A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:subject:cc:to:from:date:references
         :in-reply-to:message-id:mime-version:user-agent:dkim-signature
         :dkim-signature;
        bh=yBXiasXxv0gjhYCb054yfAMOsqC33OBWoEwFmmhBlDA=;
        b=H9uoOzBQk1R5enMoSz/+QKp7skmWIuW/JVChKJRGTeVEngSfZV27mxnBoJeyYa/0Cx
         uXj9NVkOWIDOF6mIWq1b88F+l6ZfrlJs36G2PD0H7d9Tjo4rRAXHJQUn+fg4Mxp223yX
         EnUeoOs+/GvPQGoknnPkDscmGZsbh89JDX1VgXrkbiCrRyDKvepsLRwQGqpO7z/B3k5c
         GWqMZHzGIbKS3qFDKHzpvspOZYgNV+poJEb4+WMPvFcMgk0qnhLphc8TEqRw1rYJTbU+
         FUk9P9wkTRkeYQP5fTYWjkpJpM1zgEZp/aNEYSYVtKxTOoQW1wUC8vlwz8LB48EKtVVl
         5smg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@aj.id.au header.s=fm1 header.b=CtG0VEmf;
       dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=DpByWhco;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id t7si3433647ejs.17.2019.11.27.15.28.50;
        Wed, 27 Nov 2019 15:29:14 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@aj.id.au header.s=fm1 header.b=CtG0VEmf;
       dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=DpByWhco;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727227AbfK0X1J (ORCPT <rfc822;lunatang2017@gmail.com>
        + 99 others); Wed, 27 Nov 2019 18:27:09 -0500
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:60689 "EHLO
        out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1727031AbfK0X1I (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 27 Nov 2019 18:27:08 -0500
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
        by mailout.nyi.internal (Postfix) with ESMTP id D30B52268A;
        Wed, 27 Nov 2019 18:27:07 -0500 (EST)
Received: from imap2 ([10.202.2.52])
  by compute4.internal (MEProxy); Wed, 27 Nov 2019 18:27:07 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=
        mime-version:message-id:in-reply-to:references:date:from:to:cc
        :subject:content-type; s=fm1; bh=yBXiasXxv0gjhYCb054yfAMOsqC33OB
        WoEwFmmhBlDA=; b=CtG0VEmfW54ClNVWa6lkKSLgU4CLCQgybG6EGbYDalGEPMm
        FsfG7J8/ig4x8DxwEx4qV8A0Ee9hyFFq8lWl3gdqqfoR87ebIFaXR44g+OhSlsmJ
        i0k7hHmyN5LIrZ+S26rzmj088HzrgGasbH9fDkmPxMvu9AmvvPKaMYZ/5w/W75DJ
        kysFPwMZzoDoe0gxM7H7fnP1l1mVEHWMTpXMbARASNSlRPlKec1+xAaz1u/upT8K
        DcswakEHKtFx3GETC2SaeHZnQ2dF1O+ixFwNUL6gyxgKwh3kjCHW94PToi0UN3XC
        2DTJ+KQLjGJTiO0Rb3eFZcx7YJRxZqT5QTJi+3g==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
        messagingengine.com; h=cc:content-type:date:from:in-reply-to
        :message-id:mime-version:references:subject:to:x-me-proxy
        :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=yBXias
        Xxv0gjhYCb054yfAMOsqC33OBWoEwFmmhBlDA=; b=DpByWhcoz5fQJTyByH06/r
        fV2sTlTnBpTfBb1dElxF+kpeEGdEMDuDgAXddJ94Gs4/oVUHHzJH1L1xq4LDGqnD
        aW+CP5ZJs1JliPsmOKcAvG5tTGujC0QzHLLzbu0i6P3oyDT6nyD38Yf2Mgxj09e+
        vWnRXTxMSDTEemm6vlwA0hPCJQ8bh3xyTHRBRXLKrP/LyAnnaIIA2+APKmrKHuCj
        LOPL9gQQxpg2spwsorgVdpj2HhAmt4ubR3JUZFjfa2CDxX4xEGsAphDemb8rLPfm
        fFyGY38TkaUPPSRg6vM6tR6bWq/muWCVl/45L83/bLxvxU/uavkAS5HMwlZYzkYg
        ==
X-ME-Sender: <xms:SgbfXUZ0teA62JsetIiouIbDFZ2wIgIqrkoRupzWmriMeaGyUtpNjw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudeiiedgtdelucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepofgfggfkjghffffhvffutgesthdtredtreertdenucfhrhhomhepfdetnhgu
    rhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecurfgrrh
    grmhepmhgrihhlfhhrohhmpegrnhgurhgvfiesrghjrdhiugdrrghunecuvehluhhsthgv
    rhfuihiivgeptd
X-ME-Proxy: <xmx:SgbfXfYtg8mGRSgkaeRQJoYHgqYG_HscXjG5EWhiN1ea-XhZYQldpg>
    <xmx:SgbfXW1-LZMMZWOA9WIfrTeapZOF5tT2yYOuUDAk2IHQM0AssjTJ5A>
    <xmx:SgbfXdUd-QLH1pe_RzGcVR2_qv5okNT5u4viCWCC_2jLajY4XBTsbA>
    <xmx:SwbfXWwI73HKS4JN_feji9NFDdfWof7FuLFkS5jmB9G3Gj7ny05Edw>
Received: by mailuser.nyi.internal (Postfix, from userid 501)
        id 3CAF8E00A2; Wed, 27 Nov 2019 18:27:06 -0500 (EST)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.1.7-578-g826f590-fmstable-20191119v1
Mime-Version: 1.0
Message-Id: <01b18f38-2faa-4896-9a61-d0c657596c6f@www.fastmail.com>
In-Reply-To: <493e2f9ed5aff112519adcdf2d3044bf54c2d91a.1572945709.git.matti.vaittinen@fi.rohmeurope.com>
References: <cover.1572945709.git.matti.vaittinen@fi.rohmeurope.com>
 <493e2f9ed5aff112519adcdf2d3044bf54c2d91a.1572945709.git.matti.vaittinen@fi.rohmeurope.com>
Date:   Thu, 28 Nov 2019 09:58:35 +1030
From:   "Andrew Jeffery" <andrew@aj.id.au>
To:     "Matti Vaittinen" <matti.vaittinen@fi.rohmeurope.com>,
        mazziesaccount@gmail.com
Cc:     "Linus Walleij" <linus.walleij@linaro.org>,
        "Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
        "Joel Stanley" <joel@jms.id.au>, linux-gpio@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/62] gpio: gpio-aspeed: Use new GPIO_LINE_DIRECTION
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On Tue, 5 Nov 2019, at 20:42, Matti Vaittinen wrote:
> It's hard for occasional GPIO code reader/writer to know if values 0/1
> equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and
> GPIO_LINE_DIRECTION_OUT to help them out.
> 
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>

Not sure where the series is at, but this looks fine to me:

Reviewed-by: Andrew Jeffery <andrew@aj.id.au>