Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6142855ybc; Wed, 27 Nov 2019 16:00:10 -0800 (PST) X-Google-Smtp-Source: APXvYqyYEZRpgTSc0iuCXG+Jo7xfu9oIehbP1nm322mZ3Ht+V2QUfIwoLi9E/Onl9qge4qN70v6Y X-Received: by 2002:a17:906:3e90:: with SMTP id a16mr52004657ejj.265.1574899210421; Wed, 27 Nov 2019 16:00:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574899210; cv=none; d=google.com; s=arc-20160816; b=ul7n8FVPzC70IbVXT9dTXZW6Nw8KhkMo7f4jpZ4oxPDoDtH4W+8TpD5NQuVibVS75g ALORTKCz70QYvrVRPRyzIdTn5GnifIoPNhCkbylu2HOiS5LQxF+TzDDrPS6YVJcXBlI8 o0kkPWtTuYeSW1/0M/iBjTkTTwnPfmwUCkZWgtbFRv9MFuaNINyxt0ajB4ak0ERnFLyG 2deiGv6PDXGzLdGEwGM8lotFmKLfmUKWh6x9o1NrnedYvqT498UjmGeRYt4Zb3q+EefD xEf79jP8XtdbiPNkDp/4Zh31F3TqMGLKlj9zTf7ikmRXVIx9Pd/HNKGaaxTWCOG7+EFx fpbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=a3WUEtOVqQkZFCkhjjxrIAxoTowOJXCq4QS2LfgvlaI=; b=yj6kifTYdElWfmjeKvotlThZ+7uDXKWfMyY7nPLhzkITvWVHCk/rLZqWDVTtxYo+fv ReRBYo8Bk/7icy6nH9WFu48cOFmYjCST9NmHo8BC7eLdUBci4GI9nRXCS4Gn9A1+y9pa LTyDpWG31n2dWAjodhp2rWicXuO+fo5F7Pk4CJxeZPm2LwepIL0YS1buHLV7xAE49GGs 3GOcEx9iXM4CWXsY1asfApAOFi8V9AAoHCwc+Uu3D0GmFeczp/OusGXKu0hwGmW3lpfu dba695NqUa4g8yS7b4x61tNPd6VJelACwevrh5lVSO7XwwQq6kfTiTz/Lxr5tfmsxpFy sb7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Aah2cc2Y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gx4si10740585ejb.182.2019.11.27.15.59.46; Wed, 27 Nov 2019 16:00:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Aah2cc2Y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727545AbfK0X6m (ORCPT + 99 others); Wed, 27 Nov 2019 18:58:42 -0500 Received: from mail-qk1-f196.google.com ([209.85.222.196]:40332 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727282AbfK0X6l (ORCPT ); Wed, 27 Nov 2019 18:58:41 -0500 Received: by mail-qk1-f196.google.com with SMTP id a137so19373304qkc.7 for ; Wed, 27 Nov 2019 15:58:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=a3WUEtOVqQkZFCkhjjxrIAxoTowOJXCq4QS2LfgvlaI=; b=Aah2cc2YM0jiYqAcIE90XoHLZdq3QXri37FqgF0EOP/1wTYW0fOKqBoH6Dg7Tn3vyc rWEhzubRlIOLm/FBQQYQzEtLXgDutfIIdqu9qRVDooFgUO/VBXsjovf2B2s5LTpM5lpq q27Hd52fANKgRR7OX7YQG+IMEvhfGQYx0bnLdHr+J7v79SHHvw+B7OxARdFOK+UBUcQt 2+V9ZO3voPpLxGBxvm/ik5CHf2NNL6iOQsz8VVQjZtAXgv0/yiugtYawzJY/VcP0jF6z PoHpjGMr7fQO14OANPj/rf5nyjjvnDmD+adXc7+FBKaVp5dyDApcac/pb0hISkTdeKxy jKsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a3WUEtOVqQkZFCkhjjxrIAxoTowOJXCq4QS2LfgvlaI=; b=JcZsjuGsX5c81St0pUD/nxBpTu8FC4g3XOj+YRkryvqVHzA6PEGPiHDxIbP2FbK9hn 3qnwQAjAM3jV3mCI08BA+ccRgGfa6jC2gCDbGCilmW28BZwq48mKacyfzqRP9K/CAEQd a38mPPo8tSZD4GspQ3owxNmx4tmRURnO/B818WfCgBcVr3qhdKR9AXw+eB2KLRtyQvL/ 5omuOhfdXho7oqnRL8EHMkDgSAgG9e4NJIb+T6sQpKkN7z3j+4Lf0zK1+pgtJ3j3vr7/ 7x82f7odS+vgio+U+h3idwCgQ2rXBmWERL2DUDfHrnd85woXAKgGIjT+oXTYdrJ/rXKo sDrA== X-Gm-Message-State: APjAAAVYVn9sbuvI4s7JqxzRNjJpDe8YgH4s6AGm18z5CbrPZ4hyk7FG Q4nuQc4oeDFva5UUxNfTWl8vZnAmcK9Uovlnlxyulg== X-Received: by 2002:a37:a08d:: with SMTP id j135mr7499764qke.455.1574899120904; Wed, 27 Nov 2019 15:58:40 -0800 (PST) MIME-Version: 1.0 References: <20191127231926.162437-1-heidifahim@google.com> In-Reply-To: <20191127231926.162437-1-heidifahim@google.com> From: Heidi Fahim Date: Wed, 27 Nov 2019 15:58:29 -0800 Message-ID: Subject: Re: [PATCH] kunit: testing kunit: Bug fix in test_run_timeout function To: Brendan Higgins , David Gow , shuah@kernel.org Cc: sj38.park@gmail.com, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 27, 2019 at 3:19 PM Heidi Fahim wrote: > > Assert in test_run_timeout was not updated with the build_dir argument > and caused the following error: > AssertionError: Expected call: run_kernel(timeout=3453) > Actual call: run_kernel(build_dir=None, timeout=3453) > > Needed to update kunit_tool_test to reflect this fix > https://lkml.org/lkml/2019/9/6/3 Wrong url, here is the correct link to the fix that caused this bug: https://lkml.org/lkml/2019/9/6/351