Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 28 Nov 2019 08:42:28 +0800
User-Agent: K-9 Mail for Android
In-Reply-To: <20191127152612.21945-1-linux@roeck-us.net>
References: <20191127152612.21945-1-linux@roeck-us.net>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH] MIPS: Fix boot on Fuloong2 systems
To:     Guenter Roeck <linux@roeck-us.net>,
        Paul Burton <paulburton@kernel.org>
CC:     Ralf Baechle <ralf@linux-mips.org>,
        James Hogan <jhogan@kernel.org>, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org
From:   Jiaxun Yang <jiaxun.yang@flygoat.com>
Message-ID: <1F64121F-0A46-41C2-ABE0-917A1A968A3E@flygoat.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


=E4=BA=8E 2019=E5=B9=B411=E6=9C=8827=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D=88=
11:26:12, Guenter Roeck <linux@roeck-us=2Enet> =E5=86=99=E5=88=B0:
>Commit 268a2d60013049 ("MIPS: Loongson64: Rename CPU TYPES") changed
>Kconfig symbols as follows:
>	CPU_LOONGSON2 to CPU_LOONGSON2EF
>	CPU_LOONGSON3 to CPU_LOONGSON64
>	SYS_HAS_CPU_LOONGSON3 to SYS_HAS_CPU_LOONGSON64
>
>It did not touch SYS_HAS_CPU_LOONGSON2E or SYS_HAS_CPU_LOONGSON2F=2E
>However, the patch changed a conditional from
>
> #if defined(CONFIG_SYS_HAS_CPU_LOONGSON2E) || \
>     defined(CONFIG_SYS_HAS_CPU_LOONGSON2F)
>
>to
>
> #if defined(CONFIG_SYS_HAS_CPU_LOONGSON2EF)
>
>SYS_HAS_CPU_LOONGSON2EF does not exist, resulting in boot failures
>with the qemu fulong2e emulation=2E Revert to the original code=2E
>
>Fixes: 268a2d60013049 ("MIPS: Loongson64: Rename CPU TYPES")
>Cc: Jiaxun Yang <jiaxun=2Eyang@flygoat=2Ecom>
>Signed-off-by: Guenter Roeck <linux@roeck-us=2Enet>
Acked-by: Jiaxun Yang <jiaxun=2Eyang@flygoat=2Ecom>

Apologies for the mistake=2E I ran some tests before sending the
patch but probably get this missed due to
difference between my local tree and next tree=2E

Thanks for catching that!
>---

--=20
Jiaxun Yang