Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; 
  s=zapps768; d=zoho.com; 
  h=subject:to:references:cc:from:message-id:date:user-agent:mime-version:in-reply-to:content-type; 
  b=jsuc/yQzIANxqCDQWoGtmfpWcSw3cLnu4Qih+yV4ilYpQSi1QSyWHgeGUcRT9UNYmIDOcKAfg7T4
    4Opn16zsro+W+TjtjAdS8B5vF6JPK9diNJ2qHFzpdXQ76jBEcW8B  
Subject: Re: [PATCH v4 5/6] MIPS: X1000: Add pdma controller DT node.
To:     Paul Cercueil <paul@crapouillou.net>
References: <1574787974-58040-1-git-send-email-zhouyanjie@zoho.com>
 <1574787974-58040-6-git-send-email-zhouyanjie@zoho.com>
 <1574873298.3.0@crapouillou.net>
Cc:     linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, robh+dt@kernel.org,
        paul.burton@mips.com, paulburton@kernel.org, jhogan@kernel.org,
        mripard@kernel.org, shawnguo@kernel.org, mark.rutland@arm.com,
        syq@debian.org, ralf@linux-mips.org, heiko@sntech.de,
        icenowy@aosc.io, laurent.pinchart@ideasonboard.com,
        krzk@kernel.org, geert+renesas@glider.be,
        prasannatsmkumar@gmail.com, sernia.zhou@foxmail.com,
        zhenwenjin@gmail.com, 772753199@qq.com
From:   Zhou Yanjie <zhouyanjie@zoho.com>
Message-ID: <5DDF3E81.2060502@zoho.com>
Date:   Thu, 28 Nov 2019 11:26:57 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <1574873298.3.0@crapouillou.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Paul,

On 2019=E5=B9=B411=E6=9C=8828=E6=97=A5 00:48, Paul Cercueil wrote:
> Hi Zhou,
>
>
> Le mer., nov. 27, 2019 at 01:06, Zhou Yanjie <zhouyanjie@zoho.com> a=20
> =C3=A9crit :
>> Add the appropriate DT node to probe the pdma controller driver
>> using the devicetree.
>>
>> Signed-off-by: Zhou Yanjie <zhouyanjie@zoho.com>
>> ---
>>
>> Notes:
>>     v4:
>>     New patch.
>>
>>  arch/mips/boot/dts/ingenic/x1000.dtsi | 13 +++++++++++++
>>  1 file changed, 13 insertions(+)
>>
>> diff --git a/arch/mips/boot/dts/ingenic/x1000.dtsi=20
>> b/arch/mips/boot/dts/ingenic/x1000.dtsi
>> index 9e55edd..edfa70d 100644
>> --- a/arch/mips/boot/dts/ingenic/x1000.dtsi
>> +++ b/arch/mips/boot/dts/ingenic/x1000.dtsi
>> @@ -1,5 +1,6 @@
>>  // SPDX-License-Identifier: GPL-2.0
>>  #include <dt-bindings/clock/x1000-cgu.h>
>> +#include <dt-bindings/dma/x1000-dma.h>
>
> You're not using any macro from that include file, so there's no need=20
> to have it here.
>

Sure, I will fix this in v7.

Thanks and best regards!

> Cheers,
> -Paul
>
>
>>
>>  / {
>>      #address-cells =3D <1>;
>> @@ -173,4 +174,16 @@
>>
>>          status =3D "disabled";
>>      };
>> +
>> +    pdma: dma-controller@13420000 {
>> +        compatible =3D "ingenic,x1000-dma";
>> +        reg =3D <0x13420000 0x400
>> +               0x13421000 0x40>;
>> +        #dma-cells =3D <2>;
>> +
>> +        interrupt-parent =3D <&intc>;
>> +        interrupts =3D <10>;
>> +
>> +        clocks =3D <&cgu X1000_CLK_PDMA>;
>> +    };
>>  };
>> --=20
>> 2.7.4
>>
>>
>
>