Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; 
  s=zapps768; d=zoho.com; 
  h=subject:to:references:cc:from:message-id:date:user-agent:mime-version:in-reply-to:content-type; 
  b=lBCHJiRIvFhUZqNr1O4QsrNCRpDsIY9aa5fM4zsrfiT5SzpUP3lpY75BY+edpRROefN6KOtsOAR4
    ZDZ5sN5NyhahT/70slJRuAghLLqpxNeR+B0VOqUtZvnGTrl8RRQ8  
Subject: Re: [PATCH 4/5] dt-bindings: clock: Add USB OTG clock for X1000.
To:     Paul Cercueil <paul@crapouillou.net>
References: <1574825576-91028-1-git-send-email-zhouyanjie@zoho.com>
 <1574825576-91028-5-git-send-email-zhouyanjie@zoho.com>
 <1574875148.3.3@crapouillou.net>
Cc:     linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
        robh+dt@kernel.org, paul.burton@mips.com, paulburton@kernel.org,
        mturquette@baylibre.com, sboyd@kernel.org, mark.rutland@arm.com,
        syq@debian.org, sernia.zhou@foxmail.com, zhenwenjin@gmail.com
From:   Zhou Yanjie <zhouyanjie@zoho.com>
Message-ID: <5DDF5EA9.8030007@zoho.com>
Date:   Thu, 28 Nov 2019 13:44:09 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <1574875148.3.3@crapouillou.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Paul,

On 2019=E5=B9=B411=E6=9C=8828=E6=97=A5 01:19, Paul Cercueil wrote:
> Hi Zhou,
>
>
> Le mer., nov. 27, 2019 at 11:32, Zhou Yanjie <zhouyanjie@zoho.com> a=20
> =C3=A9crit :
>> Add the USB OTC clock bindings for the X1000 Soc from Ingenic.
>>
>> Signed-off-by: Zhou Yanjie <zhouyanjie@zoho.com>
>> ---
>>  include/dt-bindings/clock/x1000-cgu.h | 23 ++++++++++++-----------
>>  1 file changed, 12 insertions(+), 11 deletions(-)
>>
>> diff --git a/include/dt-bindings/clock/x1000-cgu.h=20
>> b/include/dt-bindings/clock/x1000-cgu.h
>> index bbaebaf..c401fce 100644
>> --- a/include/dt-bindings/clock/x1000-cgu.h
>> +++ b/include/dt-bindings/clock/x1000-cgu.h
>> @@ -29,16 +29,17 @@
>>  #define X1000_CLK_MSCMUX    14
>>  #define X1000_CLK_MSC0        15
>>  #define X1000_CLK_MSC1        16
>> -#define X1000_CLK_SSIPLL    17
>> -#define X1000_CLK_SSIMUX    18
>> -#define X1000_CLK_SFC        19
>> -#define X1000_CLK_I2C0        20
>> -#define X1000_CLK_I2C1        21
>> -#define X1000_CLK_I2C2        22
>> -#define X1000_CLK_UART0        23
>> -#define X1000_CLK_UART1        24
>> -#define X1000_CLK_UART2        25
>> -#define X1000_CLK_SSI        26
>> -#define X1000_CLK_PDMA        27
>
> You can't do that. These macros are ABI now, since they are used in=20
> the devicetree. Just use the next valid number for your OTG clock.
>

My fault, I will fix this in v2.

> Cheers,
> -Paul
>
>> +#define X1000_CLK_OTG        17
>> +#define X1000_CLK_SSIPLL    18
>> +#define X1000_CLK_SSIMUX    19
>> +#define X1000_CLK_SFC        20
>> +#define X1000_CLK_I2C0        21
>> +#define X1000_CLK_I2C1        22
>> +#define X1000_CLK_I2C2        23
>> +#define X1000_CLK_UART0        24
>> +#define X1000_CLK_UART1        25
>> +#define X1000_CLK_UART2        26
>> +#define X1000_CLK_SSI        27
>> +#define X1000_CLK_PDMA        28
>>
>>  #endif /* __DT_BINDINGS_CLOCK_X1000_CGU_H__ */
>> --=20
>> 2.7.4
>>
>>
>
>