Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
To:     LKML <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>
From:   Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Optimization in pick_next_task
Message-ID: <9af14b44-81c7-cdb1-ed4f-2f684f9fdbb3@rasmusvillemoes.dk>
Date:   Thu, 28 Nov 2019 08:46:35 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

In kernel/sched/core.c, we have

        /*
         * Optimization: we know that if all tasks are in the fair class
we can
         * call that function directly,

But then the code goes on to do

                p = fair_sched_class.pick_next_task(rq, prev, rf);
                ...
                if (unlikely(!p))
                        p = idle_sched_class.pick_next_task(rq, prev, rf);

which still loads a function pointer and calls
pick_next_task_{fair,idle} through that. Should those be made extern and
used here, or am I misinterpreting what "directly" refers to?

Rasmus