Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Henry Lin <henryl@nvidia.com>
To:     Peter Chen <peter.chen@nxp.com>
CC:     Felipe Balbi <balbi@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Romain Izard <romain.izard.pro@gmail.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        EJ Hsu <ejh@nvidia.com>
Subject: Re: [PATCH] usb: gadget: f_ncm: fix wrong usb_ep
Thread-Topic: [PATCH] usb: gadget: f_ncm: fix wrong usb_ep
Thread-Index: AQHVoCLus26pLsIkukm9vcuV6VVAeqebTyAAgAG/7WqAAA5WAIAAH+35gAENlwCAAg41Vw==
Date:   Thu, 28 Nov 2019 09:21:08 +0000
Message-ID: <MN2PR12MB3389A88286B9A8348596F947AC470@MN2PR12MB3389.namprd12.prod.outlook.com>
References: <20191121041858.15746-1-henryl@nvidia.com>,<20191125042039.GA10953@b29397-desktop>
 <MN2PR12MB33899F0DEEA0A22086ACE0ECAC450@MN2PR12MB3389.namprd12.prod.outlook.com>,<VI1PR04MB53277359AF0E283AE948F34C8B450@VI1PR04MB5327.eurprd04.prod.outlook.com>
 <MN2PR12MB33894E3D1D9AC14B8C9E2966AC450@MN2PR12MB3389.namprd12.prod.outlook.com>,<VI1PR04MB532730D2E1BA4108B37155D08B440@VI1PR04MB5327.eurprd04.prod.outlook.com>
In-Reply-To: <VI1PR04MB532730D2E1BA4108B37155D08B440@VI1PR04MB5327.eurprd04.prod.outlook.com>
Accept-Language: en-US, zh-TW
received-spf: None (protection.outlook.com: nvidia.com does not designate
 permitted sender hosts)
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d8971cb-a62a-42ad-8d9f-08d773e44d4a
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2019 09:21:08.0734
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DpTNLd5s1gEz5upX1/UjHCz5Uws4AZbIgnhvz0far+iB3+Uhva5XND+xtMVoA/lFMHP13v6sZ9sq3lQGbjXPBQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB2911
X-OriginatorOrg: Nvidia.com
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1574932871; bh=wy4iaTloM7+Gs5azlBg0dcZ7PJkh1HmJ2bmBMWp4qMY=;
        h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature:
         ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:
         Thread-Index:Date:Message-ID:References:In-Reply-To:
         Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:
         authentication-results:x-originating-ip:x-ms-publictraffictype:
         x-ms-office365-filtering-correlation-id:x-ms-traffictypediagnostic:
         x-ms-exchange-transport-forked:x-microsoft-antispam-prvs:
         x-ms-oob-tlc-oobclassifiers:x-forefront-prvs:
         x-forefront-antispam-report:received-spf:
         x-ms-exchange-senderadcheck:x-microsoft-antispam:
         x-microsoft-antispam-message-info:MIME-Version:
         X-MS-Exchange-CrossTenant-Network-Message-Id:
         X-MS-Exchange-CrossTenant-originalarrivaltime:
         X-MS-Exchange-CrossTenant-fromentityheader:
         X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:
         X-MS-Exchange-CrossTenant-userprincipalname:
         X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg:
         Content-Language:Content-Type:Content-Transfer-Encoding;
        b=k2pk84EnpUQlpfrF2FniLKyas3o22UalFml4lChL6Vqgqtp9Wbz2VShxhIUQ/iJ5y
         HbyK4UvpumW0y306LI1ifV6S56uAoOrOuqdVgDnekxA0PvHglu7Wqow2wsvOtFRgLY
         mvMNboPfNoihXbyyuMYqX4rogkf5lOQIP+HHb69QnGQ4BpTvZwUYaTTRI+kmqpgcOD
         /8mSuAwCZ1iWDRJvul9BeKy+t3naSHgygm8sahbHySbzcV03QAWVClHh9FY3in0M2Y
         VXsnkAvh0QwDOm8NZ+Kuo0su0MqxNyQGYgOhVOlVe4B0Cb/6endagJ9/dHsJrLmmOg
         WkMH/5Qpp7BcA==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> >Does your UDC driver call composite_disconnect when disconnect from the=
 host?=0A=
>> >It should set all desc to NULL at related function ->disable.=0A=
>>=0A=
>> For ECM case, if ecm_set_alt() gets called with alt =3D=3D 0, in_ep->des=
c and out_ep-=0A=
>> >desc will be set up. But these two ep will not be enabled as gether_con=
nect() is not=0A=
>> executed. During disconnect from the host, ecm_disable() gets called wit=
h ep=0A=
>> disabled. In this case, gether_disconnect() will not get called to set d=
esc to NULL.=0A=
=0A=
>Would you please share your test case? I use Linux host, and the host will=
 always set alt for 1,=0A=
>and doesn't have this issue.=0A=
Using Windows host (without any proprietary NCM/ECM driver installed) can r=
eproduce set alt=0A=
to 0. We just used Win10 to confirm this.=0A=