Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Peter Chen <peter.chen@nxp.com>
To:     Henry Lin <henryl@nvidia.com>
CC:     Felipe Balbi <balbi@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Romain Izard <romain.izard.pro@gmail.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        EJ Hsu <ejh@nvidia.com>
Subject: RE: [PATCH] usb: gadget: f_ncm: fix wrong usb_ep
Thread-Topic: [PATCH] usb: gadget: f_ncm: fix wrong usb_ep
Thread-Index: AQHVoCLqKGYVyVjGs0eFFEwrEIcffKebTxyAgAHGIQCAAAb9cIAAJQiAgAEJN3CAAg+WAIAAAccg
Date:   Thu, 28 Nov 2019 09:28:32 +0000
Message-ID: <VI1PR04MB53277F89D11A5EE67F95861C8B470@VI1PR04MB5327.eurprd04.prod.outlook.com>
References: <20191121041858.15746-1-henryl@nvidia.com>,<20191125042039.GA10953@b29397-desktop>
 <MN2PR12MB33899F0DEEA0A22086ACE0ECAC450@MN2PR12MB3389.namprd12.prod.outlook.com>,<VI1PR04MB53277359AF0E283AE948F34C8B450@VI1PR04MB5327.eurprd04.prod.outlook.com>
 <MN2PR12MB33894E3D1D9AC14B8C9E2966AC450@MN2PR12MB3389.namprd12.prod.outlook.com>,<VI1PR04MB532730D2E1BA4108B37155D08B440@VI1PR04MB5327.eurprd04.prod.outlook.com>
 <MN2PR12MB3389A88286B9A8348596F947AC470@MN2PR12MB3389.namprd12.prod.outlook.com>
In-Reply-To: <MN2PR12MB3389A88286B9A8348596F947AC470@MN2PR12MB3389.namprd12.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e7da355-f8f4-474e-e16c-08d773e55621
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2019 09:28:32.5031
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0Rj1IwThvYjEw+EDHviAHweTLAuxrhQz2kO22cuulM2ZIDUg58W/AdeuR9F06duPnafgO3YyHaZ3M005fHzfHA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4063
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

=20
> >> >It should set all desc to NULL at related function ->disable.
> >>
> >> For ECM case, if ecm_set_alt() gets called with alt =3D=3D 0, in_ep->d=
esc
> >> and out_ep-
> >> >desc will be set up. But these two ep will not be enabled as
> >> >gether_connect() is not
> >> executed. During disconnect from the host, ecm_disable() gets called
> >> with ep disabled. In this case, gether_disconnect() will not get calle=
d to set desc
> to NULL.
>=20
> >Would you please share your test case? I use Linux host, and the host
> >will always set alt for 1, and doesn't have this issue.
> Using Windows host (without any proprietary NCM/ECM driver installed) can
> reproduce set alt to 0. We just used Win10 to confirm this.

Ok, feel free to submit a patch to fix it.

Peter