Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6567902ybc; Thu, 28 Nov 2019 01:30:46 -0800 (PST) X-Google-Smtp-Source: APXvYqwAfWFFyvMXrxU5VjLbj4a6Fn9Hsi5B8sirwm9bZe2YwY48qMn+ykmvYhhcDNY4E5OE0qLp X-Received: by 2002:a17:906:2505:: with SMTP id i5mr54400106ejb.18.1574933446608; Thu, 28 Nov 2019 01:30:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574933446; cv=none; d=google.com; s=arc-20160816; b=z/n/EUd2qLRxxd+cPiJKM6Y8AHR3qBTrkYuo0UXcEKM9AfKs/8KdizpKMAX3gZNNN4 z4EMPoxJNXYX2aD0sXQveiJMmdimPPg5rjxIpiUSxHI2nB/Pq6+73PntLrIYqeMT0r8S MuHbRVOavZ/VaFna8wxOzKQuuFNf9VjCsgRTaHD4ixt47Nh85SO+Qut/eZsZ+m7XVBE8 1g3mJKRvtOF3TRC/J0uMxtVNAM7CGAwrYFy01mgRQJ3H+Mge4oqHCHuUtKxduPHykxFY wp27q2FNwIgeElMv0w4HKiJp2IcoLuyHNR5TYon96aLlYZpYSqJBXj1RQxDb+EXWfiM0 I3WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject; bh=KTVoMSSyf9foSllBBmUsDqTGyvZdQUAHe78ZBGcVLgU=; b=Qrofd+mQ0cgZoE8V6TCSkAZKbyK4h62c1O2KlIWZm+fzguN4yPOcpnQY07kUUKo6D2 HiP66hWKXimdSPNgZzO6q8Os8Omiz6SjSgrgevlY0bI2dtovCN+eh/R+D1N9Sk+9xk8f QQGxewFLKue0vv4MSVRoP9Y4jWWUDe82EijeIyenQs/+orl+wzK5l+S65gBM7li8X11x 2aC9AEnj4VXFrB86zfU/sQmgoQK6JNxerZ2ay1aYCyYayofwc2jtn7jIjP5xXtuoyesN rik+Gz3hgNhVTuSBim2l1mRTNjgRPlkRNnRMB9WpedCCrViNlVTSeAUC7+l1Ojqi6fW9 Tu2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b="UpRTzl3/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id by4si12594915edb.87.2019.11.28.01.30.22; Thu, 28 Nov 2019 01:30:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b="UpRTzl3/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726856AbfK1J0b (ORCPT + 99 others); Thu, 28 Nov 2019 04:26:31 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:14597 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726092AbfK1J0b (ORCPT ); Thu, 28 Nov 2019 04:26:31 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 28 Nov 2019 01:26:33 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 28 Nov 2019 01:26:29 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 28 Nov 2019 01:26:29 -0800 Received: from [10.21.133.51] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 28 Nov 2019 09:26:27 +0000 Subject: Re: [PATCH 4.4 000/159] 4.4.203-stable review From: Jon Hunter To: Greg Kroah-Hartman CC: Guenter Roeck , , , , , , , , , linux-tegra References: <20191122100704.194776704@linuxfoundation.org> <20191122133931.GA2033651@kroah.com> <20191122134131.GA2050590@kroah.com> <20191122134627.GB2050590@kroah.com> <9f976044-2dbc-6c19-11e7-210cd7ab35ea@nvidia.com> <7edc9531-347e-9ac7-2583-5efb49acffdb@nvidia.com> <20191125094116.GA2340170@kroah.com> <20191125160305.GD2683321@kroah.com> <013aa2b3-9a68-6227-36bc-093d03547fce@nvidia.com> Message-ID: Date: Thu, 28 Nov 2019 09:26:25 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <013aa2b3-9a68-6227-36bc-093d03547fce@nvidia.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1574933193; bh=KTVoMSSyf9foSllBBmUsDqTGyvZdQUAHe78ZBGcVLgU=; h=X-PGP-Universal:Subject:From:To:CC:References:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=UpRTzl3/X1MGeIjegbw27qweF4KXJ6s21zW+qeh7DsFuaGxGq8pDv+il16dRgTQAr XimoDtDK8f9Hzww6BdwQnXLlfHzAYmWewzOpbVEz0zqfSZSz2fsmzz7fDRDcxMVDMH 1LwrCLpfXX9dzqxzSclpFeErQASp04n+eb5Cc06WULuXBrJOJWLSNV7vAZjH9LZSaJ 63KNoFLu451Ej5VApPGOe5LbDSlQy4iaSDoHYf3239WB/V4lSOrCXyv8CRbLWDg62B BU2ISEc1ND+cr0ia5UuKSpK5kcA2D3opDc3AkwC1S78FChi46+T0TLy/8/JBnNXDpE NNe2G+nqHnh2A== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/11/2019 22:45, Jon Hunter wrote: >=20 > On 25/11/2019 16:03, Greg Kroah-Hartman wrote: >> On Mon, Nov 25, 2019 at 01:22:58PM +0000, Jon Hunter wrote: >>> >>> On 25/11/2019 09:41, Greg Kroah-Hartman wrote: >>>> On Sun, Nov 24, 2019 at 08:31:46PM +0000, Jon Hunter wrote: >>>>> >>>>> On 23/11/2019 15:46, Guenter Roeck wrote: >>>>>> On 11/22/19 6:48 AM, Jon Hunter wrote: >>>>>> >>>>>> [ ... ] >>>>>> >>>>>>> Error: arch/arm/boot/dts/omap5-board-common.dtsi:636.1-6 Label or p= ath >>>>>>> dwc3 not found >>>>>>> FATAL ERROR: Syntax error parsing input tree >>>>>>> scripts/Makefile.lib:293: recipe for target >>>>>>> 'arch/arm/boot/dts/omap5-igep0050.dtb' failed >>>>>>> make[1]: *** [arch/arm/boot/dts/omap5-igep0050.dtb] Error 1 >>>>>>> arch/arm/Makefile:338: recipe for target 'dtbs' failed >>>>>>> make: *** [dtbs] Error 2 >>>>>>> >>>>>>> >>>>>>> This is caused by the following commit ... >>>>>>> >>>>>>> commit d0abc07b3d752cbe2a8d315f662c53c772caed0f >>>>>>> Author: H. Nikolaus Schaller >>>>>>> Date:=C2=A0=C2=A0 Fri Sep 28 17:54:00 2018 +0200 >>>>>>> >>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 ARM: dts: omap5: enable OTG role for DWC3 = controller >>>>>>> >>>>>> >>>>>> On top of the breakage caused by this patch, I would also argue >>>>>> that it is not a bug fix and should not have been included >>>>>> in the first place. >>>>>> >>>>>> The dwc3 label was added with commit 4c387984618fe ("ARM: dts: omap5= : >>>>>> Add l4 interconnect hierarchy and ti-sysc data"). Given the size of >>>>>> that patch, I highly doubt that a backport to 4.4 would work. >>>> >>>> Good catch, I have now dropped both of these patches and pushed out a >>>> -rc3 >>>> >>>>> FYI ... I am still seeing a build failure because of this with -rc2 .= .. >>>> >>>> Can you see if -rc3 is also giving you problems? >>> >>> Better, but I appear to be seeing some random suspend failures with thi= s >>> now on one board. I will try to bisect this. >>> >>> Test results for stable-v4.4: >>> 6 builds: 6 pass, 0 fail >>> 12 boots: 12 pass, 0 fail >>> 19 tests: 18 pass, 1 fail >>> >>> Linux version: 4.4.203-rc3-g2576206c30b5 >>> Boards tested: tegra124-jetson-tk1, tegra20-ventana, >>> tegra30-cardhu-a04 >> >> Odd. If you find anything interesting, please let me know. >=20 > Yes will do. Bisect has not found anything yet, so will keeping looking > to see if this is a false-positive or not. I have been doing some more testing and it appears that I see intermittent suspend failures on Tegra124 with linux-4.4.y. Apparently this issue has always been there and appears to be fixed in v4.5. I am still trying to find a way to fix this. The changes in v4.5 that appear to resolve this are too complex for stable (several patches in Tegra clk drivers). Anyway, ignore this for now, I will see how we can fix or workaround for linux-4.4.y. Jon --=20 nvpublic