Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6681524ybc; Thu, 28 Nov 2019 03:41:57 -0800 (PST) X-Google-Smtp-Source: APXvYqz7YyelfmduMfHTX4WTyFEiANrU04kxHhW+qB+Erd+fAsapRQuYjlIJGdNjdsI90Wm5LqGH X-Received: by 2002:a17:906:5246:: with SMTP id y6mr55211609ejm.330.1574941317456; Thu, 28 Nov 2019 03:41:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574941317; cv=none; d=google.com; s=arc-20160816; b=AcPeCSwatDu7MTA4Cg9i1KsQalbaglIDxYz/eFFmU4A+fUhFuBi2dVFPzg/dMN1TZ1 ZnnKOsBvEoOGxSbXGIgnzx+6jbmsRnidlIqp3nrfmZkP463cOrFwf0z7K4aLrg2222OQ vOZ9zQoeWVp/sutzX7xsUODydKof+x4jdVAVSTg1qpYij9gasRCMHq7GhBbLHODQ1Spg GtMgqa1QBlZTqzvd/OgeUj0GpLgsGH+aZQQPwIOjuW4X05SgxrFcp1XwRFeyiErSz6Kh wDYYz2k27l/vJimY6YypyJMQjLdbYLAedLonKvVt181Y7d+LS1upw1eNFEpiY1jdwk/R qXbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:user-agent:in-reply-to:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=x/jeELqhj5P3A7DPG/PC1XpTw6obMUxkE54tKkidDrQ=; b=utkDAYWFKU2NLZkPsfTb6VBZYbAlLWjUoGZxALjsBhBwI6C85mRHx97rS2X91tWKWy 4mFuhj4ZuxVLvgPO08Vhu0LuwCkGtIxZD2SqIhVONBwtMhvOiLVJFAm/2lZ+p2Lf8/Ct GREFh5LFFvUvlrktnCqcyTVWFgKbXd+OHOhWEurEFfSG7G9jdzB4GBChONsBaEhQkcTH hAtz54uw5wneXjAk2vzgT6l7hbBM/YcHV+29HjZ0FwhrqpIO3M4XP1CbYKmsB1nW7ev9 8pZwhDUehY4vXFrqoQBiX/Tua4ZFCvEUwhHzMORme+7vVkgDk0erUlXhHeRCPMMEXfmI YdBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=g4pwOX2r; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y23si11680792edt.366.2019.11.28.03.41.33; Thu, 28 Nov 2019 03:41:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=g4pwOX2r; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726754AbfK1Ljp (ORCPT + 99 others); Thu, 28 Nov 2019 06:39:45 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:31375 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726320AbfK1Ljm (ORCPT ); Thu, 28 Nov 2019 06:39:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574941181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x/jeELqhj5P3A7DPG/PC1XpTw6obMUxkE54tKkidDrQ=; b=g4pwOX2rQhNfvIEUgpoCchPqBRTXF9WlB5YAMdLdK1DapGKS0RWhYXqhWd3U4Dd1YNHcLh l6jYp036zIve75CJA663lxajKgV5eyVa7mFTN4U9SZahTclEpsHJ/af7BKwbBq9FurOZRY JWPuQuHxRIz0kSEboLyVXdAJwcSIJG0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-354-JkfH9-oZNDChP8mZlQBhKw-1; Thu, 28 Nov 2019 06:39:35 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1E29E107ACC7; Thu, 28 Nov 2019 11:39:33 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-67.ams2.redhat.com [10.36.116.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 526BE5D9E1; Thu, 28 Nov 2019 11:39:31 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 56292A1E0; Thu, 28 Nov 2019 12:39:30 +0100 (CET) Date: Thu, 28 Nov 2019 12:39:30 +0100 From: Gerd Hoffmann To: dri-devel@lists.freedesktop.org Cc: robh@kernel.org, intel-gfx@lists.freedesktop.org, Daniel Vetter , Maarten Lankhorst , Maxime Ripard , David Airlie , Daniel Vetter , Christian Koenig , Huang Rui , open list Subject: Re: [PATCH v3 1/2] drm: call drm_gem_object_funcs.mmap with fake offset Message-ID: <20191128113930.yhckvneecpvfhlls@sirius.home.kraxel.org> References: <20191127092523.5620-1-kraxel@redhat.com> <20191127092523.5620-2-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: <20191127092523.5620-2-kraxel@redhat.com> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: JkfH9-oZNDChP8mZlQBhKw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 27, 2019 at 10:25:22AM +0100, Gerd Hoffmann wrote: > The fake offset is going to stay, so change the calling convention for > drm_gem_object_funcs.mmap to include the fake offset. Update all users > accordingly. >=20 > Note that this reverts 83b8a6f242ea ("drm/gem: Fix mmap fake offset > handling for drm_gem_object_funcs.mmap") and on top then adds the fake > offset to drm_gem_prime_mmap to make sure all paths leading to > obj->funcs->mmap are consistent. >=20 > v3: move fake-offset tweak in drm_gem_prime_mmap() so we have this code > only once in the function (Rob Herring). Now this series fails in Intel CI. Can't see why though. The difference between v2 and v3 is just the place where vma->vm_pgoff gets updated, and no code between the v2 and v3 location touches vma ... confused, Gerd